Commit graph

100 commits

Author SHA1 Message Date
John Firebaugh
8530e3eedb AJAXy changeset history 2013-10-13 14:46:09 -07:00
John Firebaugh
a56d1036d5 pushState based navigation between map-based layouts 2013-10-13 14:46:08 -07:00
John Firebaugh
4557654ba6 Simplify layouting 2013-10-13 14:46:07 -07:00
John Firebaugh
4cc2b63d5c Factor javascript include tag to layout 2013-10-13 14:46:06 -07:00
John Firebaugh
ea6926d3de Work on changeset display 2013-10-13 14:46:05 -07:00
John Firebaugh
e8ac6bd5d9 Convert history page to sidebar layout 2013-10-13 14:45:58 -07:00
Saman Bemel-Benrud
82f8968169 Keep the map visible as the changeset page is scrolled 2013-06-10 22:34:23 +01:00
Saman Bemel-Benrud
a36f3558dd Site cleanup
I set out to do a quick and dirty typography overhaul to make things
more consistent and a bit cleaner, but I kept running into things I
didn't like, so this lead me down something of a rabbit hole of design
tweaks to the OSM site.

Goals here are to have better content hierarchy, better vertical
rhythm, more consistent UI, cleaner markup with less tables, all while
keeping the basics pretty much intact. There are a lot of things I
didn't touch even though they need to be updated (lots of tables where
stuff shouldn't be tables, mostly).

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now
a lot easier to know what you're looking at. The header has a page
title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more
rhythm and breathing room throughout the site.

I know there are other problems here or things I've missed - would
love another set of eyes to look over this! I am still getting comfortable
working on the site - it's my first time ever digging into a ruby or rails
so I'm not familiar with the templating language yet.
2013-01-14 21:27:08 +00:00
John Firebaugh
cabdb65191 Move remaining inline changeset JS to changeset.js 2012-10-05 15:20:57 +01:00
John Firebaugh
898bc32f48 Move changeset JS to page-specific script file 2012-10-05 15:20:26 +01:00
John Firebaugh
7ef803f86d Eliminate interpolation in changeset JS 2012-10-05 15:13:01 +01:00
John Firebaugh
5aa09fbfd0 Use a standard application.js bundle
Include map.js and menu.js in the bundle.
2012-08-27 20:31:17 +01:00
John Firebaugh
17b23b0756 Extract browse.js static asset 2012-08-27 20:23:24 +01:00
John Firebaugh
dcb25f0c07 Set OpenLayers lang unobtrusively
We output the locale code as the lang attribute, so
use that rather than interpolating into embedded JS.
2012-08-24 19:00:59 -07:00
Tom Hughes
3b43e4d53a Use SimplePanZoom control in changeset browser maps 2012-08-08 18:20:22 +01:00
Tom Hughes
abb13e4a91 Add paragraph tags around "no edits" message 2012-08-01 10:55:48 +01:00
Steve Singer
d2db785a2a Replace raw with a translation with the html suffix 2012-07-31 22:56:51 +01:00
Steve Singer
6403fead9c Don't show the changeset container or map if there are no changesets 2012-07-31 22:56:51 +01:00
Tristen Brown
51079ecafb Show a helpful message when there are no changesets to display 2012-07-31 21:44:22 +01:00
Sarah Hoffmann
d97d3f76a6 Replace PanZoom control with Zoom control for small maps
In OpenLayers 2.12 the event handling of PanZoom and PanZoomBar clashes
with the result that the zoom level changes by two steps every time one
of the zoom buttons is pressed. Using the Zoom control fixes this issue.
2012-07-16 18:05:02 +01:00
Tom Hughes
98445b2ab9 Replace use of Event with jQuery methods
Versions of OpenLayers before 2.12 provided a global Event object
but this has now been removed, so use jQuery methods instead.
2012-06-30 14:59:22 +01:00
Tom Hughes
770a990ed9 It's zoomToExtent, not setExtent 2012-03-15 17:01:16 +00:00
Tom MacWright
701325e9ef Change abstraction level for map functions
This commit should have no functional affect. It just changes the
abstraction level of OpenLayers from completely abstracting away
getMapExtent etc, to using OpenLayers's functionality directly but
providing proj and unproj to make projections palatable.
2012-03-14 19:01:45 +00:00
Tom Hughes
07ebb40ebb Don't show feed icons for friend and nearby user lists 2012-01-07 12:48:09 +00:00
Tom Hughes
13289d4041 Switch from Prototype to jQuery 2011-11-26 00:22:31 +00:00
Tom Hughes
716262f211 Serve OpenLayers through the asset pipeline 2011-11-25 20:07:50 +00:00
Tom Hughes
be8164cf15 Generate correct URLs for changeset feeds 2011-11-19 12:42:37 +00:00
Peter Gray
95d899786a Refactor bounding box code
Moved duplicated code into the BoundingBox class, and pass around
BoundingBox objects instead of lists of bounds.
2011-11-14 09:42:57 +00:00
Tom Hughes
b63ce5d460 Mark some locale lookups as raw 2011-11-14 09:42:52 +00:00
Tom Hughes
22594361d5 Mark some strings that shouldn't be escaped as raw 2011-11-14 09:42:41 +00:00
Tom Hughes
e5c80c80ad Use num_changes to detect empty changesets instead of the bbox 2011-07-12 15:55:17 +01:00
Tom Hughes
7e4ceec192 Wait for dom:loaded to fire before initialising the map
Also very all our use of window.onload and switch to using dom:loaded
instead where we can - the main case where we can't is when using a
vector layer as IE will fail unless the page is completely loaded.
2011-07-07 10:02:42 +01:00
Tom Hughes
e120e59fc0 Handle large bounding box changesets better
If the bounding box of a changeset is much larger than the map then
there seem to be problems with OL not rendering the feature correctly
so reduce the highlight to just be the extent of the map plus a small
margin in that case.
2011-05-13 17:27:12 +01:00
Tom Hughes
bdee581d44 Improve highlighting of changesets in the changeset list 2011-05-05 20:25:57 +01:00
Tom Hughes
e098d52424 Rearrange changeset list page to put the map beside the list 2011-05-05 20:25:53 +01:00
Tom Hughes
1635c16560 Tidy up code for adding a map to the changeset list page 2011-05-02 15:30:10 +01:00
Mikel Maron
48929e8781 Add a map to the changeset list page
Add a map to the changeset list page, with a bounding box for each
changeset and highighting when the mouse is placed over either a box
on the map or a row of the table.
2011-05-01 22:55:28 +01:00
Tom Hughes
ba639159dd Handle changesets with an empty string as the comment 2011-03-25 22:51:39 +00:00
Tom Hughes
2adcfc1a72 Don't allow paging of the changeset atom feed
Make any request for a changeset feed with a page argument redirect
to the version with no page argument and ensure that any RSS links on
the HTML version of the changeset list don't have a page argument.
2010-08-09 13:47:21 +01:00
Tom Hughes
cf682f49b3 Add a timeout to the change list pages 2010-05-21 20:21:41 +01:00
Tom Hughes
d963aa30b7 Add rel=nofollow to links in tags. Closes #2555. 2009-12-14 09:09:32 +00:00
Tom Hughes
d794f665a5 Preserve parameters in pagination links. 2009-11-19 00:20:19 +00:00
Tom Hughes
261a93fbbc Replace the existing pagination of changesets in the browser with a
simple next/previous pagination that avoids the need to count the total
number of matches.
2009-11-18 20:21:54 +00:00
Ævar Arnfjörð Bjarmason
da28349f51 So the way [17620] did it sucked but [17624] broke it unless you
didn't have any changes because .item_count is the number of edits,
not pages.

Using .page_count works though, Whee!
2009-09-14 23:36:21 +00:00
Ævar Arnfjörð Bjarmason
835e12925e auto_link() changeset comments in the global/user/bbox/etc history too
(as well as in changeset detail & atom feeds)
2009-09-14 23:26:36 +00:00
Tom Hughes
26bd59a1da Output tags to the feed as raw HTML so that links are not escaped (any
real HTML in the tag has already been escaped). Closes #2264.
2009-09-14 23:17:52 +00:00
Tom Hughes
9200520395 Escape tag values - there is no reason at all to render things which
might look like HTML tags in a tag value.
2009-09-14 23:17:02 +00:00
Tom Hughes
253e8a272d Improve handling of the case where there is only one page of changesets. 2009-09-14 23:04:06 +00:00
Ævar Arnfjörð Bjarmason
466f640138 While we don't have the sanitizing backend to safely solve ticket
#2264 I'm going to remove the auto_link feature of changeset tags. The
links are broken in all conforming Atom readers at the moment.
2009-09-14 21:08:17 +00:00
Ævar Arnfjörð Bjarmason
332f8d3a4f Now when all the entries fit on one page a trailing slash won't be
included after "Showing page %d (%d of %d)"
2009-09-14 19:42:32 +00:00