Commit graph

84 commits

Author SHA1 Message Date
Anton Khorev
aca9bd205e Add subscribe/unsubscribe buttons to note pages 2024-11-22 00:55:41 +03:00
Emin Kocan
738e66afa6 Add status filter to user's note page 2024-11-18 15:21:55 +01:00
Anton Khorev
e9148e56eb Use svg icons in pagination for note lists 2024-09-03 02:10:43 +03:00
Anton Khorev
6f074c9f20 Use Bootstrap pagination for note lists 2024-09-03 01:48:34 +03:00
Anton Khorev
2f5272639e Move note paging locale strings to notes scope 2024-09-03 01:38:17 +03:00
Anton Khorev
060494b09c Use button elements that allow word wrap for note controls 2024-06-03 13:40:11 +03:00
Anton Khorev
1b1d8326d8 Write closed note controls using submit_tag 2024-06-01 09:05:19 +03:00
Anton Khorev
2a657a969b Replace .btn-wrapper with Bootstrap gutters/gaps 2024-05-26 05:38:27 +03:00
Anton Khorev
cd30c56623 Remove custom css from note descriptions 2024-05-25 05:07:24 +03:00
Tom Hughes
161fc8ac47 Replace deprecated text-muted class with text-body-secondary 2024-05-22 11:58:32 +01:00
Hidde Wieringa
b2fcf003f8 Convert note markers to SVG 2024-05-15 00:28:00 +01:00
Anton Khorev
822466c6c6 Add warnings when creating notes anonymously 2024-05-14 19:42:59 +03:00
Anton Khorev
b5520a9b39 Use body color in notes table legend 2024-04-14 17:19:59 +03:00
Anton Khorev
b8f5a495f2 Simplify remaining link_to ... user_path in views 2024-03-21 18:07:56 +03:00
Anton Khorev
d1b58fb20e Show blocked api response when reopening notes 2024-01-17 02:15:14 +03:00
Anton Khorev
3ea2c30c58 Show blocked api response when commenting notes 2024-01-17 02:15:14 +03:00
Anton Khorev
3776adcfc0 Add login notice for note discussions 2023-12-31 05:13:30 +03:00
Andy Allan
100a7f8979 Use friendly_date for note disappear description
There's no need to reimplement this in its own helper.
2023-11-15 19:36:35 +00:00
Andy Allan
f3a4443120 Remove unusual margins and line-height from comments
This allows them to follow normal conventions used elsewhere, as
well as removing some custom css.
2023-09-13 13:18:30 +01:00
Anton Khorev
d69ae84963 Add color keys to note tables 2023-08-17 19:26:26 +03:00
Anton Khorev
a4b8a91821 Use Bootstrap highlight class in note tables 2023-08-10 21:16:26 +03:00
Andy Allan
c276625e7f Refactor to use submit_tag helper
This is more readable than interpolating into element attributes
2023-02-01 17:24:48 +00:00
Andy Allan
a88da1d71a Refactor translation strings for notes
These aren't used by any javascript code, so don't need to be in
the `javascripts` key.
2023-02-01 17:24:48 +00:00
Andy Allan
9bb8dd739a Use data attributes to pass alternative button labels
This allows the text to be defined in the html partials, instead
of looking up the i18n via javascript.
2023-02-01 17:24:47 +00:00
Andy Allan
9748ce301c Move browse#note to notes#show
This allows a more resourceful routing approach.
2023-02-01 17:13:41 +00:00
Andy Allan
b5046fdcd0 Move browse#new_note to notes#new
This allows a more resourceful routing approach.
2023-02-01 17:13:41 +00:00
Andy Allan
75749cc540 Convert remaining heading titles to use h1
This makes them consistent with all the other pages that use h1
in the `content_for :heading` sections
2021-11-11 15:12:23 +00:00
Harry Wood
de8ee536b1 Display no notes message when empty
Display a 'No notes' message when there are no notes to display, rather than an empty table with pagination features.
2021-04-09 19:21:09 +01:00
Andy Allan
41d6f19a6b Rename the notes#mine action to index 2020-07-08 18:43:30 +02:00
Andy Allan
055a976051 Remove custom table styling
This removes the custom table styling code, and move to using bootstrap table styling for almost all remaining tables.
2020-04-01 12:29:01 +02:00
Andy Allan
13f0591605 Wrap table header rows in thead 2019-12-11 17:22:23 +01:00
Andy Allan
220ad92766 Use friendly_date_ago for notes display
Refs #2255
2019-06-19 18:04:08 +02:00
Andy Allan
22c1be4db7 Set image dimensions in order to avoid a reflow after the page is drawn by the browser 2019-03-27 18:05:44 +01:00
Andy Allan
a5f4124681 Refactor notes#mine to simplify code 2019-03-27 18:04:44 +01:00
Tom Hughes
3af16f6337 erblint: fix remaining single quoted strings 2019-03-27 16:15:19 +00:00
Andy Allan
74b91c0e3e erblint: Add or remove curly braces around hash parameters as required 2019-03-27 10:30:48 +01:00
Andy Allan
b4dbf6233c Move the notes api methods into a controller in the api namespace 2019-02-28 17:12:28 +01:00
Andy Allan
686fee43bf Use full list of osm xml root attributes in builder templates 2019-01-09 14:15:39 +01:00
Andy Allan
252b9ef08a Pluralize changesets controller 2018-11-14 10:34:28 +01:00
Andy Allan
dfa2fd7d3d Rename note to notes in i18n lookups
Enables lazy translation lookups for most cases. Additionally, rename
keys for notes.description.* to notes.comment.* to match partial
name.
2018-04-25 14:56:20 +08:00
Andy Allan
9f84c6f46e Use user_path links. Fixes #1785 2018-03-21 11:33:45 +08:00
Tom Hughes
fe1e28b4f4 Fix more parameter sanitisation issues and add tests 2017-06-29 20:52:57 +01:00
Andy Allan
396f2e28dd Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509 2017-06-23 14:03:57 +01:00
Tom Hughes
425f3f309b Use created at for RSS format with note#show
This matches other formats and is also what the tests expect.
2017-02-20 08:50:56 +00:00
Tom Hughes
34c473f503 Use only_path instead of setting an explicit host 2016-11-24 20:33:36 +00:00
Andy Allan
1e3a35f971 Add missing xmlns:dc for notes rss 2016-11-24 17:47:16 +00:00
Andy Allan
968447595b Use dc:creator for note RSS feeds
The author tag is reserved for email addresses
2016-10-29 17:14:56 +02:00
Andy Allan
38e12759ea Rubocop autofixes. 2016-09-07 11:07:42 +01:00
Markus Heidelberg
166dc76ae9 Make notes GPX valid and add useful official elements
The "creator" attribute is required and "extensions" is the correct
name of this element.

Validated with SAXCount from the xerces-c package:

$ SAXCount -v=always -n -s -f notes.gpx

Original error messages:

    Error at file /home/markus/notes.gpx, line 2, char 171
      Message: no declaration found for element 'gpx'

    Error at file /home/markus/notes.gpx, line 2, char 171
      Message: attribute 'version' is not declared for element 'gpx'

After adding the "xmlns" attribute:

    Error at file /home/markus/notes.gpx, line 2, char 213
      Message: missing required attribute 'creator'

    Error at file /home/markus/notes.gpx, line 18, char 14
      Message: no declaration found for element 'extension'

    Error at file /home/markus/notes.gpx, line 26, char 7
      Message: element 'extension' is not allowed for content model '(ele?,time?,magvar?,geoidheight?,name?,cmt?,desc?,src?,link*,sym?,type?,fix?,sat?,hdop?,vdop?,pdop?,ageofdgpsdata?,dgpsid?,extensions?)'

The current errors now are caused by the missing XML schema for the
extensions.

Also add the time, name and link elements.
2015-08-10 19:11:18 +01:00
Tom Hughes
a34935df9b Fix a missing translation 2015-07-23 14:23:23 +01:00