Commit graph

67 commits

Author SHA1 Message Date
Tom Hughes
aa143f047b Rails no longer gives textareas a default size 2013-09-22 10:33:31 +01:00
Saman Bemel-Benrud
2827d8ad81 Succint button copy + force single line grouped buttons 2013-07-30 00:53:30 +01:00
Saman Bemel-Benrud
c3b8897c44 Improve layout and styling of forms 2013-07-08 09:03:17 +01:00
Thomas Levine
6ded8b55c8 Add standard-label class to all form labels 2013-07-08 09:03:17 +01:00
Thomas Levine
dc031d121c Rename buttons-joined to buttons 2013-07-08 09:03:17 +01:00
Saman Bemel-Benrud
d2ddf35ae2 Generalize support for groups of action buttons 2013-07-08 09:03:17 +01:00
Tom MacWright
a501ad8762 Rework send message form using new form styles 2013-07-08 09:03:16 +01:00
Tom Hughes
cff41d2171 Ajaxify message deletion 2013-02-03 12:52:51 +00:00
Tom Hughes
1f7dd79daf Fix lists in rich text to display properly
Add a "richtext" class to anything which contains text rendered
by our rich text library, and move styles which were only being
applied to diary entries to apply to all rich text.
2013-01-24 14:54:26 +00:00
Saman Bemel-Benrud
a36f3558dd Site cleanup
I set out to do a quick and dirty typography overhaul to make things
more consistent and a bit cleaner, but I kept running into things I
didn't like, so this lead me down something of a rabbit hole of design
tweaks to the OSM site.

Goals here are to have better content hierarchy, better vertical
rhythm, more consistent UI, cleaner markup with less tables, all while
keeping the basics pretty much intact. There are a lot of things I
didn't touch even though they need to be updated (lots of tables where
stuff shouldn't be tables, mostly).

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now
a lot easier to know what you're looking at. The header has a page
title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more
rhythm and breathing room throughout the site.

I know there are other problems here or things I've missed - would
love another set of eyes to look over this! I am still getting comfortable
working on the site - it's my first time ever digging into a ruby or rails
so I'm not familiar with the templating language yet.
2013-01-14 21:27:08 +00:00
Tom Hughes
ff5972d090 Fix cut and paste errors in inbox/outbox redesign 2012-10-02 19:51:30 +01:00
Tom MacWright
be8617dfdc Redesign inbox
Cuts down on buttons, grey, and bold clutter.
2012-10-02 19:34:49 +01:00
Tom Hughes
ada8b184ea Preserve background colour when marking messages read/unread 2012-08-09 00:26:38 +01:00
Tom Hughes
eaad3611b8 Add functional tests for messages
Also fixes various issues in the code discovered while writing
the tests, and adds some named routes for messages.
2012-03-22 23:14:29 +00:00
Tom Hughes
5270a07bc5 Handle change from @to_user to @this_user for new message action 2012-03-22 19:47:24 +00:00
Tom Hughes
a9824dbc2e Use one "no_such_user" view everywhere 2012-03-21 21:47:09 +00:00
Tom Hughes
561f2f694a Add preview functionality to rich text controls 2012-03-17 16:36:57 +00:00
Tom Hughes
aa4205482a Treat all newly entered blocks of text as Markdown 2012-03-17 16:36:55 +00:00
Tom Hughes
30f21edbc2 Fixed incorrect link generation in sent message list 2012-03-11 08:46:28 +00:00
Tom Hughes
58d889436f Fix various routing and route generation errors 2012-03-09 23:15:39 +00:00
Tom Hughes
b83af6ef2c Pluralize message counts properly 2012-01-14 12:19:40 +00:00
Tom Hughes
13289d4041 Switch from Prototype to jQuery 2011-11-26 00:22:31 +00:00
Tom Hughes
7d45c2fd3c Replace request.request_uri with request.fullpath 2011-11-14 09:42:42 +00:00
Tom Hughes
22594361d5 Mark some strings that shouldn't be escaped as raw 2011-11-14 09:42:41 +00:00
Tom Hughes
b25a468e3c Use <%= instead of <% for block helpers that use concat 2011-11-14 09:42:41 +00:00
Tom Hughes
d075fc4c1f Lots more work on making RTL layout work 2011-07-02 01:00:51 +01:00
Tom Hughes
9d35062ba3 Add a "friendly" date/time format and use it whenever we are printing
dates and times on the web site.

Also try and improve formatting of message pages a but, and include the
image of the recipient when viewing a sent message.
2010-02-28 16:57:22 +00:00
Tom Hughes
b90567e197 Tidy up error handling in the message controller, and make it redirect to
the login page if you are logged in as the wrong user. Closes #1569.
2010-02-28 15:13:06 +00:00
Tom Hughes
3851a672e2 Ajaxify the mark read/unread function for messages so it doesn't
reload the whole page each time.
2010-02-26 16:35:36 +00:00
Ævar Arnfjörð Bjarmason
2dab83d57b use {{count}} instead of {{sent_count}} so rails plural forms will kick in 2009-10-02 10:41:47 +00:00
Ævar Arnfjörð Bjarmason
2118dd06af Link to username in "Send message to" message 2009-09-14 19:32:29 +00:00
Tom Hughes
581c243e0e Allow messages to be deleted from the outbox as well as the inbox. 2009-07-23 17:41:50 +00:00
Tom Hughes
f3bf0c8b14 Add the ability for a recipient to (logically) delete a message from
their INBOX so they no longer see it.
2009-07-23 15:22:44 +00:00
Tom Hughes
0d97737a7d Prevent message date/time from wrapping. 2009-07-23 15:07:26 +00:00
Tom Hughes
502dc65e95 Remove surplus whitespace. 2009-07-23 15:05:44 +00:00
Ævar Arnfjörð Bjarmason
2153fb6efd Fixed a bug in how fields in /message/new were being pre-filled out.
When someone went to /message/new/:user the "Subject" are would be
pre-filled out with t('message.new.title'). The problem was that the
@title template variable was being used for two purposes, to set the
HTML <title> AND to pre-fill out the subject.

We don't always want these two to be the same, but sometimes we
do. E.g. when someone replies to a diary entry and visits
/message/new/:user?title=Foo we want Foo in the <title> and in the
pre-filled out Subject, and the same goes for replying to a message.

So I've split up the @title variable into @title and @subject.
2009-07-12 16:01:49 +00:00
Thomas Wood
98a86836d2 Commit avar's patch (+ fix for user not found) to change message sending URL to be by user name rather than id.
(Closes #1920)
2009-06-19 22:33:16 +00:00
Tom Hughes
2e2f212472 Rename views to rails 2 style names. 2009-06-09 20:50:14 +00:00
Ævar Arnfjörð Bjarmason
db51d7f3dd Added & cleaned up messages relating to a given user not existing
The following pages now have a <title> that can be set in localizations:

 * /user/USER_DOES_NOT_EXIST
 * /user/USER_DOES_NOT_EXIST/diary
 * /user/USER_DOES_NOT_EXIST/traces
 * /message/*/ID_DOES_NOT_EXIST

In addition I've cleaned up the i18n message keys of all the
''no_such_user.rhtml'' pages involved. They now all use
title/heading/body for the <title>, <h2> and <p> respectively. And the
message key {{user}} instead of {{name}}.
2009-06-06 13:15:53 +00:00
Andy Allan
272d73e9a7 i18n for messages 2009-05-31 15:37:18 +00:00
Shaun McDonald
2e41c35479 Adding the ability to see the min/max lat/lon for a changeset in the data browser. Adding file for the nice message that should show when a user is missing in the message controller. 2008-12-08 15:30:19 +00:00
Shaun McDonald
1a7ab3570c Deal with active record not found exceptions when creating message. Some tidying of html. For some reason in rails 2.1.2 having a comment at the end of a line, in the view, means that the closing tag needs to be on the next line. 2008-12-03 12:56:02 +00:00
Tom Hughes
e62eacd8d3 Remove bogus action attribute from the submit button - it should have
no effect as there is no such attribute defined, but Opera seems to
decide that it should post the form to that URL instead of the one
give on the form element.
2008-05-15 09:34:45 +00:00
Tom Hughes
895eb829c9 Backout message deletion functionality as it has unfortunate side effects
as it also removes the message from the sender's outbox.
2008-05-06 16:35:24 +00:00
Tom Hughes
a47fcb0857 Fix replying to diary comments, and tidy a few things up. 2008-05-05 23:01:05 +00:00
Steve Coast
ee1707a4a7 nicer reply messages, bug 529 2008-05-03 14:02:53 +00:00
Steve Coast
ee6165bf9b ability to delete messages 2008-05-03 13:25:34 +00:00
Tom Hughes
0d70728fe2 Escape user display names. 2008-03-04 16:51:13 +00:00
Steve Coast
cacf1879c3 user images 2008-02-23 15:18:59 +00:00
Tom Hughes
c3bd1f113b Tidy up message sensitisation a bit more, and add sensitisation of
information in the diary RSS feeds.
2008-01-16 10:02:42 +00:00