Commit graph

132 commits

Author SHA1 Message Date
Andy Allan
5bed217823 Use lazy translations where possible 2018-04-25 14:10:59 +08:00
Tom Hughes
be86e4824f Convert various URLs to https 2018-01-08 20:18:21 +00:00
Tom Hughes
1c77d2432e Avoid using rinku's auto_link helper
It's currently broken (https://github.com/vmg/rinku/issues/70) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Andy Allan
c819bec8b7 Use a current_user helper for accessing the logged in user in all views. 2017-07-27 10:07:51 +01:00
Tom Hughes
117f0e8226 Sanitize parameters for various paged views 2017-06-29 10:55:53 +01:00
Tom Hughes
80d27a7fae Sanitise parameters used in URL generation 2017-06-02 20:27:07 +01:00
Tom Hughes
1309661b15 Use image_url instead of image_path with the host option
Fixes #1379
2016-11-24 20:23:42 +00:00
Andy Allan
33a1fca883 Use the assets pipeline for images in the changeset feeds.
This brings it into line with the other feeds.
2016-11-24 17:07:59 +00:00
Andy Allan
38e12759ea Rubocop autofixes. 2016-09-07 11:07:42 +01:00
Simon Legner
5175ee68b0 Add title to changeset feeds
Fixes #1051
Closes #1180
2016-03-14 21:09:53 +00:00
Simon Legner
91bd0b4b12 Display number of comments in changeset list 2015-08-27 21:26:31 +02:00
Tom Hughes
8598db3233 Tidy up changeset comment code 2014-10-23 21:24:51 +01:00
Łukasz Gurdek
14ac1babc2 Changeset discussions
Add support for commenting on changesets with RSS feeds and email
notification of comments to other commenters and people that have
chosen to subscribe to a changeset.
2014-10-23 21:24:51 +01:00
Tom Hughes
5c53bb78ab Don't linkify comments in the changeset list
It's confusing to make links in comments active in the changeset list
as the rest of the comment is an active link to the changeset.

We do want to make them active in the changeset view however, so add
linkification to the comment there.

Fixes https://trac.openstreetmap.org/ticket/5061
2013-12-08 13:11:48 +00:00
Tom Hughes
16a72d93de Don't show "Load More" if we found less than 20 changesets 2013-12-02 19:39:56 +00:00
John Firebaugh
6b236ec95b Fix feed link for pushState loaded history page 2013-11-25 15:47:42 -08:00
Tom Hughes
51ade94113 Drop max_id from the changeset feed URL 2013-11-25 22:28:02 +00:00
Tom Hughes
43f52daeaa Remove unused partials 2013-11-25 00:51:53 +00:00
John Firebaugh
d0de36b607 Refine changeset browse behavior
The general history view shows changesets in the current view
and updates when you move the map. The view for an individual
user, nearby users, or friends zooms the map to the extent of
the results, and doesn't change when you move the map.
2013-11-19 12:10:14 -08:00
John Firebaugh
38564b4736 Include changeset ID in list 2013-11-12 15:44:17 -08:00
John Firebaugh
e670da54cb Rationalize browse translation keys 2013-11-12 12:51:33 -08:00
John Firebaugh
c4090bb150 Improve browse design 2013-11-12 09:03:23 -08:00
Aaron Lidman
1ae7872ed8 Update title on pushState, closes #33 2013-11-08 16:10:08 -08:00
Aaron Lidman
b2a82f501d Float the close icon, closes #40 2013-11-08 12:01:20 -08:00
Aaron Lidman
4b2bd4835d Fixed changeset time inconsistencies 2013-11-07 12:19:00 -08:00
Aaron Lidman
e7d200c4a6 Sidebar close reverts to 'view' state 2013-11-06 16:59:14 -08:00
Eden Halperin
baaacfc7c0 Browse page style tweaks 2013-11-06 15:45:57 -05:00
Aaron Lidman
30ab1e91da Remove all the headers 2013-11-05 19:32:33 -08:00
Aaron Lidman
d1cc387080 Improve changeset template 2013-11-05 18:28:11 -08:00
Aaron Lidman
dcf56d9376 Missed a couple close buttons 2013-11-05 15:15:49 -08:00
Aaron Lidman
09da09bb52 Improve changeset list 2013-11-05 13:42:32 -08:00
Aaron Lidman
5a00e23fa3 Fix common details 2013-11-05 11:57:26 -08:00
John Firebaugh
8530e3eedb AJAXy changeset history 2013-10-13 14:46:09 -07:00
John Firebaugh
a56d1036d5 pushState based navigation between map-based layouts 2013-10-13 14:46:08 -07:00
John Firebaugh
4557654ba6 Simplify layouting 2013-10-13 14:46:07 -07:00
John Firebaugh
4cc2b63d5c Factor javascript include tag to layout 2013-10-13 14:46:06 -07:00
John Firebaugh
ea6926d3de Work on changeset display 2013-10-13 14:46:05 -07:00
John Firebaugh
e8ac6bd5d9 Convert history page to sidebar layout 2013-10-13 14:45:58 -07:00
Saman Bemel-Benrud
82f8968169 Keep the map visible as the changeset page is scrolled 2013-06-10 22:34:23 +01:00
Saman Bemel-Benrud
a36f3558dd Site cleanup
I set out to do a quick and dirty typography overhaul to make things
more consistent and a bit cleaner, but I kept running into things I
didn't like, so this lead me down something of a rabbit hole of design
tweaks to the OSM site.

Goals here are to have better content hierarchy, better vertical
rhythm, more consistent UI, cleaner markup with less tables, all while
keeping the basics pretty much intact. There are a lot of things I
didn't touch even though they need to be updated (lots of tables where
stuff shouldn't be tables, mostly).

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now
a lot easier to know what you're looking at. The header has a page
title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more
rhythm and breathing room throughout the site.

I know there are other problems here or things I've missed - would
love another set of eyes to look over this! I am still getting comfortable
working on the site - it's my first time ever digging into a ruby or rails
so I'm not familiar with the templating language yet.
2013-01-14 21:27:08 +00:00
John Firebaugh
cabdb65191 Move remaining inline changeset JS to changeset.js 2012-10-05 15:20:57 +01:00
John Firebaugh
898bc32f48 Move changeset JS to page-specific script file 2012-10-05 15:20:26 +01:00
John Firebaugh
7ef803f86d Eliminate interpolation in changeset JS 2012-10-05 15:13:01 +01:00
John Firebaugh
5aa09fbfd0 Use a standard application.js bundle
Include map.js and menu.js in the bundle.
2012-08-27 20:31:17 +01:00
John Firebaugh
17b23b0756 Extract browse.js static asset 2012-08-27 20:23:24 +01:00
John Firebaugh
dcb25f0c07 Set OpenLayers lang unobtrusively
We output the locale code as the lang attribute, so
use that rather than interpolating into embedded JS.
2012-08-24 19:00:59 -07:00
Tom Hughes
3b43e4d53a Use SimplePanZoom control in changeset browser maps 2012-08-08 18:20:22 +01:00
Tom Hughes
abb13e4a91 Add paragraph tags around "no edits" message 2012-08-01 10:55:48 +01:00
Steve Singer
d2db785a2a Replace raw with a translation with the html suffix 2012-07-31 22:56:51 +01:00
Steve Singer
6403fead9c Don't show the changeset container or map if there are no changesets 2012-07-31 22:56:51 +01:00