Tom Hughes
bfffe7ed96
Prefer string interpolation to concatenation
2020-11-13 11:32:28 +00:00
Tom Hughes
93e49daee2
Merge remote-tracking branch 'upstream/pull/2918' into master
2020-10-28 11:29:57 +00:00
Andy Allan
da2277505f
Ensure that test utility methods are marked as private
...
This allows us to enable the check for test method names.
2020-10-28 11:49:01 +01:00
Andy Allan
c04d05686f
Resolve some extra-long lines
2020-10-28 11:07:34 +01:00
Tom Hughes
2dc50b4431
Fix new rubocop warnings
2020-10-09 08:26:38 +01:00
Tom Hughes
ddac660f3b
Merge remote-tracking branch 'upstream/pull/2839'
2020-09-30 11:54:30 +01:00
mmd-osm
37a7996d94
API User details: format tweaks
...
- _show_ to return single user only
- remove nesting for languages
2020-09-18 21:50:38 +02:00
mmd-osm
dff8effc13
Json user details: unit tests
2020-09-16 22:13:19 +02:00
mmd-osm
9f280be82b
Fix unit test, assume application/xml instead of text/xml
2020-09-16 21:01:54 +02:00
Tom Hughes
21adea321b
Convert password reset forms to use bootstrap
2020-09-04 00:36:43 +01:00
Tom Hughes
c11142d5c0
Convert logout form to use bootstrap
2020-09-03 23:52:59 +01:00
Tom Hughes
ea59d95f4a
Fix some new rubocop warnings
2020-08-06 22:27:30 +01:00
Tom Hughes
0e2a66e8de
Fix new rubocop warnings
2020-08-06 18:42:16 +01:00
Tom Hughes
c24c2e481c
Merge remote-tracking branch 'upstream/pull/2667'
2020-08-05 21:50:08 +01:00
Tom Hughes
2d3972249c
Fix some rubocop todos
2020-08-02 19:38:58 +01:00
Andy Allan
47d11763fb
Add some changsets that shouldn't be selected
2020-07-22 17:51:43 +02:00
Andy Allan
e7dc2f2e55
Refactor changeset index testing to assert against objects, not db queries
...
This avoids the situation where tests pass despite an empty db.
Refs #2614
2020-07-22 17:39:48 +02:00
Andy Allan
b23d6a5445
Refator way_full test to avoid relying on non-existant fixtures
...
Refs #2614
2020-07-22 16:33:33 +02:00
Andy Allan
41d6f19a6b
Rename the notes#mine action to index
2020-07-08 18:43:30 +02:00
Andy Allan
8d2271699b
Use bootstrap_form as the formbuilder for GPX upload form
...
This also uses the recommended bs-custom-file-input javascript plugin
for the file input control.
2020-07-01 17:23:02 +02:00
Andy Allan
600812f6ad
Rework user#set_status and #delete to avoid GET requests
...
This renames the delete action to destroy, and starts using resourceful
routing for user actions.
2020-06-10 11:49:18 +02:00
Andy Allan
8ebfdbc1ff
Move make_friend and remove_friend to friendships controller
2020-06-03 18:23:07 +02:00
Andy Allan
59c90aa023
Move friendship related tests to separate file
2020-06-03 17:51:11 +02:00
Andy Allan
3a16c465f7
Refactor user controller tests
...
Because we don't have direct access to the session and cookies, some
of the tests need more setup e.g. by moving through the signup process
to get the session tokens into the right place for the confirmation
steps to work.
2020-05-13 18:08:22 +02:00
Andy Allan
36a1f38109
Refactor api traces_controller tests
2020-05-13 18:08:07 +02:00
Tom Hughes
7ffa2e96be
Refactor users_controller_test and user_preferences_controller_test
2020-05-07 19:34:48 +01:00
Tom Hughes
2d37f1a03c
Refactor notes_controller_test
2020-05-06 18:39:48 +01:00
Tom Hughes
45e560bef6
Add test for browsing a note closed by a deleted user
2020-05-06 18:06:45 +01:00
Andy Allan
f84980f183
More controller test refactoring
2020-05-06 16:51:04 +02:00
Tom Hughes
9a87412d2a
Refactor permissions_controller_test
2020-05-05 19:40:52 +01:00
Tom Hughes
c576edecd4
Refactor versions_controller_test
2020-05-05 19:36:38 +01:00
Tom Hughes
93f1489048
Refactor tracepoints_controller_test
2020-05-05 19:28:42 +01:00
Tom Hughes
f898cecb5c
Refactor map_controller_test
2020-05-05 19:19:43 +01:00
Tom Hughes
7e1a4b6884
Refactor changeset comments API controller tests
2020-05-05 18:04:48 +01:00
Tom Hughes
749ca5d5a0
Refactor the AMF controller API tests
2020-05-05 17:45:46 +01:00
Andy Allan
2e3522a2f6
Refactor changesets_controller_test
...
Introduces some route names which need to be unique from the non-api versions
2020-04-29 17:42:08 +02:00
Andy Allan
e765a6691b
Refactor more controller tests
2020-04-29 17:28:42 +02:00
Tom Hughes
f7d95e2ef9
Refactor traces controller tests
2020-04-28 19:44:00 +01:00
Tom Hughes
f75eb6fe9e
Refactor more controller tests
2020-04-27 22:24:28 +01:00
Tom Hughes
8979c597e3
Refactor more controller tests
2020-04-26 22:56:18 +01:00
Tom Hughes
03cde71a5e
Refactor more controller tests
2020-04-26 20:33:06 +01:00
Andy Allan
506731031d
Refactor some more controller tests
2020-04-22 16:45:16 +02:00
Tom Hughes
c51786d10b
Merge remote-tracking branch 'upstream/pull/2596'
2020-04-22 13:44:17 +01:00
Tom Hughes
359d76c8f0
Redirect to the error page for non-existent issues
2020-04-22 12:37:56 +01:00
Andy Allan
1aa5a54419
Refactor site controller tests to inherit from ActionDispatch::IntegrationTest
...
This is the modern way of writing controller tests, since it uses the
rails middleware (among other things) and leads to more realistic tests.
Refs #2563
2020-04-22 11:09:13 +02:00
Tom Hughes
7a1615bc55
Fix rubocop-minitest warnings
2020-04-15 19:07:13 +01:00
Andy Allan
055a976051
Remove custom table styling
...
This removes the custom table styling code, and move to using bootstrap table styling for almost all remaining tables.
2020-04-01 12:29:01 +02:00
Andy Allan
1cb0767e3d
Copy trace fixture files, rather than symlinking
...
Since we are using tmpdirs in order to enable parallel testing, we
can go the full hog and drop the fakefs too and just copy all the
files directly into the tmpdir. If a test makes changes (e.g.
changing the icon file during an import) the copy in the tmpdir is
thrown away at the end of the test anyway.
2020-03-18 15:35:55 +01:00
Andy Allan
979a474c68
Use unique test directories for each trace test
...
This allows tests to be run in parallel, since it avoids deleting
some of the symlinks that other tests expect to be there.
2020-03-18 15:04:18 +01:00
Andy Allan
5fdada204c
Use bootstrap table striping to replace hand-cycled table stripes
...
This cuts down on the complexity of having to use the `cycle` function
and makes the templates easier to read. CSS-based striping has been
around for many years.
The CSS is in order to keep our custom colour for striped tables.
2020-03-18 12:14:24 +01:00
