cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2224 commits 4 branches 1 tag 499 MiB
Commit graph

678 commits

Author SHA1 Message Date
Shaun McDonald
fac8b5d28a Log the request on a few requests when there is a bad request, probably should do this in a few more places. This makes it easier to see why we are getting errors/bad requests. 2008-12-12 19:04:28 +00:00
Shaun McDonald
c76e60f052 Improving the not found handling of preferences. adding a user preference test. adding some utility methods to the test helper 2008-12-12 18:54:03 +00:00
Tom Hughes
9b1b6be371 Optimise lookup of traces with a given tag. 2008-12-12 15:17:14 +00:00
Shaun McDonald
541c24b23d capture the too many way nodes error, and give the user an error message 2008-12-12 11:24:40 +00:00
Shaun McDonald
b051dd11af Making amf controller act more like the xml apis 2008-12-11 17:22:15 +00:00
Shaun McDonald
814822120a Don't give an error when you access the login page when you are logged in. Instead take you to the page in the referer or the home page. 2008-12-11 15:05:53 +00:00
Shaun McDonald
8bf0a3197c some more progress towards making amf_controller do version checking of nodes before deleting them 2008-12-11 10:38:36 +00:00
Shaun McDonald
eafcf91ceb some further progress to amf controller checking the version numbers. 2008-12-10 18:07:30 +00:00
Matt Amos
aeaf2d2d20 Added missing version to the pure rails AMF controller. More stringent tests on whichways. 2008-12-10 14:31:07 +00:00
Matt Amos
3ed9ac21b5 Some fixes to the rails part of the AMF controller and associated test. 2008-12-10 13:23:21 +00:00
Shaun McDonald
b7335940e2 Some improvements for the XML parsing, as there are somethings that we don't need, like timestamp and visibility, thus hopefully bringing a speedup in the xml parsing. Some more AMF controller fixes, plenty more to go though. 2008-12-09 18:44:11 +00:00
Shaun McDonald
c0b4c1b905 Adding some amf create poi tests. Minor bugfix tweaks to the amf controller 2008-12-08 14:22:34 +00:00
Shaun McDonald
ec97c63e5c Fix for the refactoring commited yesterday, based on review by Dave Stubbs 2008-12-05 11:08:58 +00:00
Shaun McDonald
e9527b363d Refactoring the amf controller, and all models so that save_with_history! is now private. Everyone should use create_with_history, delete_with_history, and update_from instead. Also gets the amf controller to do version checks in the node/way/relation models. Needs checked. This breaks Potlatch until #1376 is fixed. 2008-12-04 17:30:17 +00:00
Shaun McDonald
d9c6758ee6 turning the session off for the changeset controller, to come in line with the other api controllers 2008-12-04 14:36:21 +00:00
Shaun McDonald
1a7ab3570c Deal with active record not found exceptions when creating message. Some tidying of html. For some reason in rails 2.1.2 having a comment at the end of a line, in the view, means that the closing tag needs to be on the next line. 2008-12-03 12:56:02 +00:00
Shaun McDonald
073c866032 adding link to download the full changeset xml 2008-12-02 18:44:50 +00:00
Shaun McDonald
2ed84e26cd Adding pagination to the changesets, thus allowing you to browe large changesets, without MySQL complaining about memory. Probably needs some fine tuning. You currently can only page one of nodes, ways, and relations, without manually setting the relations. Fixing deprection notice for the classic_pagination plugin. 2008-11-27 17:06:43 +00:00
Matt Amos
1ffb5c1502 Moved changeset consistency checks to library code. 2008-11-26 12:56:42 +00:00
Shaun McDonald
a4e5e8437f Renaming the include action to expand_bbox in the changeset controller. 2008-11-26 11:36:10 +00:00
Shaun McDonald
8348493ccb Some improvements to the error messages that are returned by the api. 2008-11-25 18:59:35 +00:00
Richard Fairhurst
ecefee485b various fixes/enhancements, including a couple to the 0.5 version 2008-11-25 00:15:30 +00:00
Shaun McDonald
0ff1214f86 Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions. 2008-11-24 18:55:24 +00:00
Matt Amos
783528830a Fixed bug in changeset idle timeout. Fixed another with a spurious require. 2008-11-21 12:53:09 +00:00
Shaun McDonald
e2c0e51e45 Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower. 2008-11-20 21:23:44 +00:00
Shaun McDonald
55d511bf21 Remember whether the user set the public checkbox on GPX upload as a user preference. Closes #827 2008-11-18 20:22:09 +00:00
Tom Hughes
990dcedc4c Require the user to be logged in for those methods which make no 
sense otherwise.
 2008-11-18 17:23:40 +00:00
Tom Hughes
f77ce935a4 Fix syntax of status only renders. Closes #1345. 2008-11-18 17:19:37 +00:00
Matt Amos
a90be5e69a Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests. 2008-11-17 19:00:01 +00:00
Matt Amos
495bd7f1f0 Made user input parsing more robust in changeset query method. Added tests. 2008-11-17 15:30:46 +00:00
Matt Amos
28839fd150 Fixed some bugs in changeset query code. Added more test cases. 2008-11-17 14:32:15 +00:00
Matt Amos
519d402cb2 Added tests for changeset close method. 2008-11-17 11:59:42 +00:00
Matt Amos
98b15bef45 Implemented changeset tags updating via the update method. 2008-11-17 11:45:50 +00:00
Richard Fairhurst
6690a9a09b changeset comments and a couple of other small fixes 2008-11-16 13:30:02 +00:00
Richard Fairhurst
0a57413d3e finished Rails-friendly amf_controller. Note that this requires Tom's patched composite_primary_keys to work unless you tell Potlatch to use SQL reads 2008-11-14 17:36:38 +00:00
Shaun McDonald
bdd5c317a7 Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated. 2008-11-13 17:20:40 +00:00
Shaun McDonald
797cbaab1e Covering the case of an entry not being found. More diary entry tests. 2008-11-12 18:48:58 +00:00
Frederik Ramm
ad9e48120a replaced "wtf does this do" comment by something explaining what it does. 2008-11-12 00:11:57 +00:00
Matt Amos
e79fd07638 Made relations ordered. Added some tests for this. Otherwise interface is unchanged. 2008-11-10 15:41:05 +00:00
Andy Allan
f2093eb4c4 boolean correctness 2008-11-10 11:47:20 +00:00
Richard Fairhurst
3065af398d 0.6-friendly Potlatch (work in progress). DO NOT SET POTLATCH_USE_SQL=false as it won't work 2008-11-09 23:50:03 +00:00
Dave Stubbs
2aa3daf0e0 amf get*_history tests and related fixes 2008-11-09 18:48:16 +00:00
Dave Stubbs
436470b057 a few more amf tests and associated bug fixes 2008-11-09 17:41:38 +00:00
Frederik Ramm
c02c516047 fix SCALE, make changeset GET use floats 2008-11-09 15:52:10 +00:00
Frederik Ramm
9263c5500c require auth for close 2008-11-09 13:44:08 +00:00
Dave Stubbs
eebadd141a 1st amf_controller tests, and some basic sanity check fixes 2008-11-08 19:41:29 +00:00
Shaun McDonald
bf29550db8 Resyncing from head 10895:11795 2008-11-08 11:52:58 +00:00
Dave Stubbs
67a50e848c more boolean correcting 2008-11-08 10:48:07 +00:00
Matt Amos
b875d14b7c Added a query method for querying bounding boxes, times and users of changesets. Needs (much) more testing. 2008-11-07 18:24:34 +00:00
Andy Allan
c253ce3399 some boolean correctness work 2008-11-07 13:51:09 +00:00