Matt Amos
9481a79e71
Added optimisation for way checking. Same method as for relations.
2009-05-11 14:34:04 +00:00
Matt Amos
b7f306a437
Fixed problem where tag lengths were generating a 422 error with no message. They now generate a 400 error with a meaningful message.
2009-05-10 00:33:55 +00:00
Tom Hughes
d6e605414d
Set a custom return path so that we can ignore bounces.
2009-05-09 12:17:10 +00:00
Thomas Wood
c273b4b1fa
Tests for PreconditionFailed error messages.
...
Change to relation.rb to bring element selection in-line with that of way, so to return nil to be caught later, rather than raise an error.
Change to way.rb to clarify which way on diff upload.
2009-05-06 21:08:50 +00:00
Thomas Wood
d7fd3fb6e5
One final (I've checked the rest now!) mis-referenced id, plus make the error msg simpler.
2009-05-06 19:55:25 +00:00
Matt Amos
30bbca0f3b
Potential fix for slow relation precondition checking based on Frederik's suggestion on the list to only check new members.
2009-05-06 10:35:39 +00:00
Shaun McDonald
d0e16cdb6c
be a bit more specific when a way is a member of a relation. Actually return an error message when a relation precondition fails. Remove a debug statement.
2009-05-05 17:07:06 +00:00
Thomas Wood
1d48f48827
Fix another mis-referenced error message id!
2009-05-02 18:28:39 +00:00
Thomas Wood
22292debda
Data browser changes, make links more user friendly, displaying name tag where possible.
...
Changes to models ok'd (and suggested as temporary solution) by TomH
References #1777
2009-05-02 00:26:37 +00:00
Tom Hughes
5b0e72ec71
Get rid of foreign_class specification which is no longer needed.
2009-05-01 23:20:53 +00:00
Tom Hughes
329b6faf91
Use association names with :joins instead of writing the SQL for the
...
join by hand.
2009-04-30 23:45:55 +00:00
Shaun McDonald
34381e56b7
give a id when a way is a member of a relation
2009-04-30 16:50:20 +00:00
Shaun McDonald
33d32bf737
We don't need an extra method for the amf controller for saving nodes, just catch the exception and do nothing with that exception.
2009-04-30 15:16:15 +00:00
Thomas Wood
2861236f60
Fix another error reporting bug similar to previous, again on printing RelationMember.id rather than RelationMember.relation.id
2009-04-30 07:10:57 +00:00
Thomas Wood
bb3108cb99
Fix grammar/referred relation id in precondition failed error.
...
From: "Precondition failed: The relation 5 is a used in relation 4,0."
To: "Precondition failed: The relation 5 is used in relation 4."
2009-04-30 06:52:14 +00:00
Richard Fairhurst
41f85fb77d
Potlatch 0.11a
2009-04-30 01:23:50 +00:00
Matt Amos
3e9b6845d3
Fixed 'raw' raises by converting them to the appropriate OSM::APIError type. Made the error messages for placeholder fixing more informative. Added tests for these.
2009-04-29 10:07:35 +00:00
Tom Hughes
6d1c010213
Use the alias for the conditions as well...
2009-04-28 16:25:37 +00:00
Tom Hughes
074e5b0a11
Use an alias for current_relation_members to avoid clashing with
...
any attempt to eager load it.
2009-04-28 16:15:02 +00:00
Tom Hughes
bf31791f65
Add a changeset cache to stop us looking up the same changeset over
...
and over again when processing a map call.
2009-04-28 13:40:30 +00:00
Tom Hughes
04d0f45845
Remove debugging statement.
2009-04-28 09:00:01 +00:00
Shaun McDonald
0b6d9ce877
Improve the node/way/relation already deleted error message, and get rid bug in way model with missing new in exception
2009-04-27 11:49:56 +00:00
Shaun McDonald
b7596f7fbc
Fix typo of missing .new for some of the errors. Tests are useful.
2009-04-26 20:56:58 +00:00
Tom Hughes
83aa2655f5
Null descriptions are not allowed.
2009-04-25 22:26:56 +00:00
Matt Amos
eed6fdf7db
Fixed bug in exception creation.
2009-04-25 15:20:48 +00:00
Matt Amos
82a54db3d9
Fixed dumb copy-and-paste mistake.
2009-04-24 18:47:41 +00:00
Matt Amos
6c66507427
Patching better 412 error messages from mis-commit on old api06 branch.
2009-04-24 10:08:15 +00:00
Tom Hughes
77a34278ca
Backout broken attempt at making case insensitive authentication work
...
on Postgres. As implemented this forces a table scan to authenticate
users which is ridiculous to save people pressing the shift key.
2009-04-23 23:46:45 +00:00
Shaun McDonald
f1a0331081
Hack a way to make the email and display name case insensitive for logging in, based on a suggestion by firefishy to use ILIKE. Changes requested from users on mailing list. Includes some tests to check the case insensitivity of the username, and and e-mail address on login.
2009-04-23 19:20:08 +00:00
Matt Amos
9ff7ea8d71
Added better error messages on 412 precondition failed.
2009-04-23 18:39:36 +00:00
Matt Amos
1654b3d407
Quick and dirty fix for relation tags issue.
2009-04-21 23:40:27 +00:00
Shaun McDonald
0ad724bd92
Hopefully fix the old_node_controller tests.
2009-04-21 17:07:14 +00:00
Tom Hughes
ff9f596cea
Arrays have a length method, not a count method.
2009-04-21 11:36:41 +00:00
Tom Hughes
e733264687
Add missing files from api06 merge.
2009-04-20 14:09:35 +00:00
Tom Hughes
fd6f00b069
Merge api06 branch to trunk.
2009-04-20 09:12:03 +00:00
Tom Hughes
bb7c4f93e2
Cope with MySQL and Postgres.
2009-04-16 20:40:32 +00:00
Shaun McDonald
08bd1688ee
Railsify the relation member model, type attribute, by putting it into class case, rather than lower case. Requires reload of postgres databases or manual change to the enum. Fixes the databrowser on postgres, however affects the rest of the codebase.
2009-04-15 14:49:21 +00:00
Shaun McDonald
5bc558e355
Should have a .new when raising error
2009-04-14 12:00:26 +00:00
Shaun McDonald
90ec90f13d
reverting last change, which included posgres config specific things
2009-04-13 00:10:37 +00:00
Shaun McDonald
2c52b06716
Remove duplication that is in the test helper. Adding tests for the passing of no content, and the wrong method used. Also ensuring that there has been a changeset added to the db when it is created.
2009-04-13 00:04:24 +00:00
Thomas Wood
6442208841
Add exceptions for remaing cases where XML::Parser.string is used, to catch for empty strings.
...
See also r14241
2009-04-09 22:37:43 +00:00
Thomas Wood
c64ebb9139
Add has_valid_bbox? method to Changeset model to tidy checking for bbox, and fix edge case where no bbox would cause changeset browsing to die.
2009-04-09 11:18:31 +00:00
Matt Amos
18633b7c9e
Fixed a problem where rails was setting the ID column to null, which violates the not-null constraint. Also fixed possible typo in AMF controller.
2009-03-29 02:14:40 +00:00
Matt Amos
afcb345014
Moved a bunch of time functions into UTC. Fixes bugs which we only see for 4 hours a year.
2009-03-29 01:31:04 +00:00
Matt Amos
8140c99313
Fix for correct boolean handling in query.
2009-03-29 00:56:08 +00:00
Matt Amos
be75a1504f
Fixed a couple of bugs with changeset bounding box calculation when modifying or deleting.
2009-03-27 12:22:23 +00:00
Thomas Wood
6167bb6502
Shut up libxml's "Must specify a string with one or more characters" error on relation and way models.
2009-03-23 21:52:32 +00:00
Tom Hughes
81835c55a0
Commit ACL related files from earlier merges as svn merge seems to
...
neglected to add them...
2009-03-08 16:13:00 +00:00
Tom Hughes
c8ee135104
Merge 12304:14009 from trunk.
2009-03-08 13:02:37 +00:00
Tom Hughes
07c1cd6b98
Update to use libxml 1.0.0 gem.
2009-03-08 11:34:46 +00:00
