Commit graph

387 commits

Author SHA1 Message Date
Tom Hughes
b6b2fe6b8d Revert to using released version of canonical-rails 2024-10-24 08:57:26 +01:00
Tom Hughes
b935cd6fef Merge remote-tracking branch 'upstream/pull/5246' 2024-10-16 19:05:18 +01:00
Andy Allan
96984421ad
Merge pull request #5216 from kcne/teaspoon-v2
Re-enable JavaScript unit tests using Teaspoon
2024-10-16 16:55:33 +01:00
Andy Allan
b0ffe17cec
Merge pull request #4988 from nenad-vujicic/issue_4912_pr_labeling
Added workflow for PR labeling using Danger
2024-10-16 14:29:59 +01:00
Tom Hughes
8c2d6cbed6 Keep zeitwerk at 2.6 for ruby 3.1 support 2024-10-15 18:38:21 +01:00
Emin Kocan
40c71f28be Enable eslint and fix eslint errors for osm_test.js 2024-10-12 21:02:10 +02:00
Emin Kocan
b17517e02c Disable eslint for js test files to test for github-ci 2024-10-12 20:50:56 +02:00
Emin Kocan
123c7d10a5 Selenium driver working on local 2024-10-12 20:50:38 +02:00
Andy Allan
9266180344 Use teaspoon to run javascript tests
Refs #2595
2024-10-12 20:47:26 +02:00
Nenad Vujicic
e307b9037a Added workflow for PR labeling using Danger
Workflow is called when PR is created or updated. It checks if PR is too big (>500 changed lines), changes one of translation files (YML, except en.yml) or contains merge-commits and generates appropriate labels.
2024-10-07 11:21:16 +02:00
Andy Allan
1633059dbb Switch to canonical-rails from master, with rails 7.2.1+ compatibility 2024-10-02 17:15:54 +01:00
Tom Hughes
be2678e0dd Update to rails 7.2.0 2024-09-17 20:39:31 +01:00
Tom Hughes
6789fc3081 Drop support for ruby 3.0
Also add Ubuntu 24.04 and drop 20.04 as 24.04 is needed for
ruby 3.1 without rvm so we should test it.
2024-09-17 20:39:22 +01:00
Tom Hughes
17bc0853a0 Drop support for OAuth 1 2024-09-01 03:43:02 +03:00
Tom Hughes
bb2eccf658 Add overcommit to manage git hooks 2024-08-21 08:20:10 +01:00
Andy Allan
2a2d1d50d3 Add debug gem
This is included in new rails 7+ apps, so let's include it too.

This also means it's available on ruby 3.0, and is automatically
updated on newer versions of ruby too.
2024-08-14 15:36:09 +01:00
Tom Hughes
fffaacb49e Keep to strong_migrations 1.8 for ruby 3.0 compatibility 2024-07-02 21:06:33 +01:00
Anton Khorev
c03649355a Join and normalize og:image url using Addressable
Avoids failing on urls that are not strictly rfc2396 URIs.
2024-06-15 15:06:07 +03:00
Tom Hughes
20bdbb05c3 Switch to using rails builtin content security policy support 2024-05-22 16:38:59 +01:00
Andy Allan
ffda8d7ac5
Merge pull request #4680 from tomhughes/validate-page-numbers
Add parameter validation to pagination
2024-05-15 17:43:04 +01:00
Tom Hughes
bfaa61c993 Lock multi_xml to 0.6 for ruby 3.0 compatibility 2024-05-14 19:24:23 +01:00
Andy Allan
97fa344af6 Pin browser to versions that support ruby 3.0 2024-05-08 10:40:48 +01:00
Tom Hughes
3c2780f2c3 Fix rubocop warning 2024-04-23 18:59:09 +01:00
Tom Hughes
847d43518b Stick to mini_racer 0.9.0 for now
https://github.com/rubyjs/mini_racer/issues/300
2024-04-23 17:17:02 +01:00
Tom Hughes
feff501b25 Add framework for parameter validation using rails_param gem 2024-04-11 10:08:20 +01:00
Gregory Igelmund
f0af7d3cff Gemfile: Add turbo-rails 2024-03-21 14:55:15 +01:00
Tom Hughes
bd36ef242e Update bundle 2024-03-05 19:15:43 +00:00
Tom Hughes
3360f91733 Require display names to have a minimum unicode width of 3 columns
Fixes #4538
2024-02-25 13:21:03 +00:00
Andy Allan
bd1f568c0a Add minitest-focus gem 2024-02-07 18:08:25 +00:00
Tom Hughes
1f0105c953 Use file_exists to provide File.exists? for ruby 3.2
This is needed for the oauth gem which uses it.
2023-12-11 17:17:28 +00:00
Tom Hughes
a328ec84a2 Use rtlcss instead of r2 for RTL support
This ensures that the RTL directives in bootstrap are processed
correctly as it is designed around RTLCSS for RTL support.

Fixes #4347
2023-11-16 22:53:09 +00:00
Andy Allan
aad93b9978 Switch back to bootstrap releases
Bootstrap-rubygem 5.3.2 onwards allows us to use dartsass-sprockets.

Refs #4262
2023-10-26 11:38:10 +01:00
Tom Hughes
dd905b5aa8 Merge remote-tracking branch 'upstream/pull/4262' 2023-10-24 17:37:48 +01:00
Andy Allan
14c20e9835 Upgrade to bootstrap 5.3 2023-10-24 17:37:04 +01:00
Tom Hughes
0de0317425 Update bundle 2023-10-24 17:09:39 +01:00
Tom Hughes
46cd08b1c8 Replace composite_primary_keys with rails builtin support 2023-10-18 18:26:14 +01:00
Tom Hughes
f37ea2fae3 Update to rails 7.1.1 2023-10-18 18:26:13 +01:00
Gregory Igelmund
aa573ce1bb
.github/workflows/lint.yml: Add task verifying annotations are up2date 2023-10-14 11:28:44 +08:00
Tom Hughes
c8fc2218e5 Merge remote-tracking branch 'upstream/pull/4226' 2023-10-03 19:39:41 +01:00
Milan Cvetkovic
1f62a2b342 Add a test for openid connect support 2023-10-03 18:55:10 +01:00
Milan Cvetkovic
8a22bfb222 Add unconfigured doorkeeper-openid_connect
After executing:
rails generate doorkeeper:openid_connect:install
rails generate doorkeeper:openid_connect:install

Split migration script to 2 to avoid deadlock.
2023-10-03 18:53:09 +01:00
Andy Allan
520cffabea Upgrade to bootstrap 5.2 2023-09-29 09:41:35 +01:00
Andy Allan
41f13ac73a Switch from sassc-rails to dartsass-sprockets
sassc-rails, and its underlying libsass, is deprecated. dartsass-sprockets
allows us to use the currently maintained dartsass implementation,
without having to change any of our toolchain.

The version of sass-embedded is pinned to avoid warnings in bootstrap. When
we upgrade bootstrap versions, we can upgrade sass-embedded to match.
2023-09-27 09:35:30 +01:00
Milan Cvetkovic
7428da74c2 Use omniauth-microsoft_graph instead of omniauth-windowslive
Omniauth-microsoft_graph correctly populates 'email' and 'name' fields used by OpenStreetMap.
It also  uses updated endpoints for Microsoft identity provider.

Use email address returned by microsoft_graph provider as a verified address.

Upgrading exisiting users from windowslive to microsoft_graph:
 - upon next login existing `windowslive` users will have to authorizei
   OpenStreetMap application to "Read Your Profile," required for proper reading
   of display name field.

The name of the identity provider in OSM is kept to 'windowslive':
 - the entries in users table with `provider == 'windowslive'`
   can be reused for microsoft_graph provider, since
   the uid field is preserved. Users will not need to repeat the sign up process.
 - OAuth2 callback is still `/auth/windowslive`, no updates to Microsoft Identity Provider portal
   App registration are necessary.
2023-08-17 13:01:15 +00:00
Tom Hughes
52296d1cad Add rubocop-factory_bot and fix warnings 2023-05-16 18:44:14 +01:00
Andy Allan
85dbe7c29a Add the i18n-tasks gem
This can be used for checking our translations, for example to see
if there are unused translations in en.yml
2023-03-08 15:34:54 +00:00
Tom Hughes
2e5e2bc263 Add rubocop-capybara 2023-03-07 17:09:29 +00:00
Tom Hughes
2ee8fcda40 Drop version constraint on mail and update bundle 2023-01-13 09:29:04 +00:00
Tom Hughes
02ed416e12 Update bundle 2022-12-13 20:26:25 +00:00
Tom Hughes
8cef62cd2c Merge remote-tracking branch 'upstream/pull/3301' 2022-11-22 18:47:24 +00:00