Commit graph

1156 commits

Author SHA1 Message Date
Matt Amos
4ab495f5db Added locking around update and delete methods on main API objects. This should remove the 500 errors which come from concurrent overlapping updates. Experimental - might be too slow for production. 2009-05-21 14:57:03 +00:00
Matt Amos
94c89838d4 Use utility method for error reporting. 2009-05-21 14:55:25 +00:00
Shaun McDonald
d4954bc7b1 Raising an exception in Ruby requires a .new. Add a timeout line to the capabilities call. 2009-05-21 14:05:09 +00:00
Tom Hughes
97769170fd Give the API error handler a generic rescue that returns 500 with
the exception details.
2009-05-21 10:02:26 +00:00
Richard Fairhurst
8100be1e8d Potlatch 1.0 2009-05-21 00:30:33 +00:00
Tom Hughes
b38684e59e Add a global timeout that is applied to most API requests. 2009-05-20 22:18:36 +00:00
Matt Amos
3d0ca940d2 Using an around_handler for catching and rendering errors in most of the API controller methods. This simplifies the code and makes errors and error messages a bit more consistent. Also added a utility method for checking the HTTP method. 2009-05-20 17:39:59 +00:00
Tom Hughes
058d942c7c Log arguments to AMF read methods. 2009-05-20 13:24:59 +00:00
Harry Wood
3415aa4689 label changesets as (big) based on their bbox area 2009-05-15 16:24:55 +00:00
Tom Hughes
fe13e13d16 Arrays of object IDs are a bad idea. 2009-05-15 09:18:10 +00:00
Tom Hughes
fa13a11a94 Optimise retrieval of full relations. 2009-05-15 09:10:50 +00:00
Matt Amos
d7badc8402 Fixed precondition failed message which was trying to dereference nil. 2009-05-14 11:19:28 +00:00
Richard Fairhurst
add2d223a6 Apply #1824. 2009-05-14 08:38:32 +00:00
Shaun McDonald
7331f82bce Remove a rescue, which is stopping a more detailed error message being returned to the user. 2009-05-13 23:42:18 +00:00
Richard Fairhurst
ced42cf101 always set new node id when updating/deleting (to be read in conjunction with zere's patch) 2009-05-13 19:23:59 +00:00
Shaun McDonald
807070f818 Actually mark a trace as being public based on the saved preference, rather than simply ignoring the saved preference. 2009-05-12 15:29:27 +00:00
Matt Amos
ed0a1658df Removed updatetimeout method, as it isn't needed any more. 2009-05-12 14:38:22 +00:00
Matt Amos
1ceb4ab9ba Fixed bug #1816 - the timeout updating logic should have been in a before_save handler, not in save_with_tags. 2009-05-12 13:54:37 +00:00
Tom Hughes
ed68d524de Use a local lookup table for country bounding boxes rather than relying
on geonames.org being able to do it in a reasonable time.
2009-05-11 16:50:09 +00:00
Matt Amos
43988beec3 A better optimisation, as suggested by TomH. 2009-05-11 15:16:36 +00:00
Matt Amos
9481a79e71 Added optimisation for way checking. Same method as for relations. 2009-05-11 14:34:04 +00:00
Tom Hughes
4d62aea5ec Destroy OL objects which use the dataLayer before we destroy the layer
or we will get errors which stop the rest of stopBrowse() executing.
2009-05-11 10:31:34 +00:00
Tom Hughes
3a8a2ebb1a Add an internal geocoder for lat/lon positions. 2009-05-10 11:57:10 +00:00
Matt Amos
b7f306a437 Fixed problem where tag lengths were generating a 422 error with no message. They now generate a 400 error with a meaningful message. 2009-05-10 00:33:55 +00:00
Tom Hughes
69c2400997 Add a warning about whitelisting webmaster@openstreetmap.org in antispam
systems.
2009-05-09 16:46:36 +00:00
Tom Hughes
d6e605414d Set a custom return path so that we can ignore bounces. 2009-05-09 12:17:10 +00:00
Tom Hughes
f7cbff9a5a Move geocoder constants to application configuration to avoid test warnings. 2009-05-08 18:21:39 +00:00
Shaun McDonald
a41f1b297b No need to define a constand for the appconfig var. Removes a warning when running under rails 2.2.2 2009-05-08 14:20:26 +00:00
Thomas Wood
cd4fb9d44c One last commit tonight :P 2009-05-07 23:02:46 +00:00
Thomas Wood
d6b36b5752 De-duplicate some of the changeset stuff out to a new partial view.
Add css hooks for upcoming fix for #1734
2009-05-07 22:48:14 +00:00
Thomas Wood
c273b4b1fa Tests for PreconditionFailed error messages.
Change to relation.rb to bring element selection in-line with that of way, so to return nil to be caught later, rather than raise an error.
Change to way.rb to clarify which way on diff upload.
2009-05-06 21:08:50 +00:00
Thomas Wood
d7fd3fb6e5 One final (I've checked the rest now!) mis-referenced id, plus make the error msg simpler. 2009-05-06 19:55:25 +00:00
Matt Amos
30bbca0f3b Potential fix for slow relation precondition checking based on Frederik's suggestion on the list to only check new members. 2009-05-06 10:35:39 +00:00
Shaun McDonald
d0e16cdb6c be a bit more specific when a way is a member of a relation. Actually return an error message when a relation precondition fails. Remove a debug statement. 2009-05-05 17:07:06 +00:00
Richard Fairhurst
8696d144ad Potlatch 0.11b 2009-05-04 23:37:06 +00:00
Thomas Wood
c18d684dda Sort the tags for the databrowser output. 2009-05-04 22:42:07 +00:00
Thomas Wood
1d48f48827 Fix another mis-referenced error message id! 2009-05-02 18:28:39 +00:00
Thomas Wood
22292debda Data browser changes, make links more user friendly, displaying name tag where possible.
Changes to models ok'd (and suggested as temporary solution) by TomH
References #1777
2009-05-02 00:26:37 +00:00
Tom Hughes
5b0e72ec71 Get rid of foreign_class specification which is no longer needed. 2009-05-01 23:20:53 +00:00
Tom Hughes
329b6faf91 Use association names with :joins instead of writing the SQL for the
join by hand.
2009-04-30 23:45:55 +00:00
Shaun McDonald
34381e56b7 give a id when a way is a member of a relation 2009-04-30 16:50:20 +00:00
Shaun McDonald
33d32bf737 We don't need an extra method for the amf controller for saving nodes, just catch the exception and do nothing with that exception. 2009-04-30 15:16:15 +00:00
Thomas Wood
2861236f60 Fix another error reporting bug similar to previous, again on printing RelationMember.id rather than RelationMember.relation.id 2009-04-30 07:10:57 +00:00
Thomas Wood
bb3108cb99 Fix grammar/referred relation id in precondition failed error.
From: "Precondition failed: The relation 5 is a used in relation 4,0."
To: "Precondition failed: The relation 5 is used in relation 4."
2009-04-30 06:52:14 +00:00
Thomas Wood
6a2fda5a99 Fix html: closing <a> tag. 2009-04-30 06:50:51 +00:00
Richard Fairhurst
41f85fb77d Potlatch 0.11a 2009-04-30 01:23:50 +00:00
Matt Amos
3e9b6845d3 Fixed 'raw' raises by converting them to the appropriate OSM::APIError type. Made the error messages for placeholder fixing more informative. Added tests for these. 2009-04-29 10:07:35 +00:00
Tom Hughes
9acc6d3288 Eager load node and way details when processing a map call. 2009-04-28 16:26:06 +00:00
Tom Hughes
6d1c010213 Use the alias for the conditions as well... 2009-04-28 16:25:37 +00:00
Tom Hughes
074e5b0a11 Use an alias for current_relation_members to avoid clashing with
any attempt to eager load it.
2009-04-28 16:15:02 +00:00