Commit graph

53 commits

Author SHA1 Message Date
Tom Hughes
8dae890a76 Fix rubocop warnings 2017-10-05 19:18:38 +01:00
Andy Allan
6f89da05d1 Use current_user to represent the currently logged in user.
This is already used by the oauth plugin, and is a general rails convention.
2017-07-12 16:10:50 +01:00
Tom Hughes
fe1e28b4f4 Fix more parameter sanitisation issues and add tests 2017-06-29 20:52:57 +01:00
Tom Hughes
3763cbc7d4 Disable forgery protection for notes API methods
Fixes #1571
2017-06-29 19:14:55 +01:00
Tom Hughes
4248e10946 Use distinct instead of uniq which is deprecated 2017-06-04 22:52:41 +01:00
Tom Hughes
7c9229fbfc Throw an exception if adding a note comment fails 2017-03-13 14:49:16 +00:00
Tom Hughes
e17b89e89f Fix rubocop warnings 2016-10-20 22:35:51 +01:00
Andy Allan
3f698e1d15 Fix bugs->notes in comment 2016-10-06 08:59:24 +01:00
Tom Hughes
5d3ecffa28 Fix new rubocop warnings 2016-02-05 13:35:26 +00:00
Tom Hughes
8fe1899596 Fix rubocop warnings 2016-01-19 09:51:24 +00:00
Tom Hughes
c9fdd5d3cb Don't send note comment notifications to deleted users 2015-10-30 19:20:36 +00:00
Tom Hughes
c9d35839be Fix new rubocopy warnings 2015-08-18 20:57:14 +01:00
Tom Hughes
5dc3e5b48a Don't show hidden notes to non-moderators in the user notes list
Fixes #921
2015-08-12 17:42:14 +01:00
Tom Hughes
93fb360a08 Add a few more tests 2015-03-07 00:50:35 +00:00
Tom Hughes
9fb8f5a84b Drop the old output_compression plugin
The production servers all have mod_deflate enabled anyway, which
almost certainly does a better job of compression than this.
2015-03-01 10:52:28 +00:00
Tom Hughes
dbe165bbb3 Fix some rubocop rails style issues 2015-02-26 00:12:54 +00:00
Tom Hughes
dc2a2c8ebd Standardise on double quoted strings 2015-02-20 19:47:26 +00:00
Tom Hughes
ef7f3d800c Fix most auto-correctable rubocop issues 2015-02-20 08:56:16 +00:00
Tom Hughes
34e3e51456 Cleanup trailing whitespace 2015-02-20 08:56:16 +00:00
Tom Hughes
360d68ea5c Replace deprecated deliver method with deliver_now 2015-01-11 12:53:06 +00:00
Tom Hughes
098c2675ba Add support for ACL blocks on note commenting 2014-06-03 20:59:25 +01:00
Toby Murray
c78853a97e Changing the note search limit from 9999 to 10000
The documentation says the limit is 10000 which seems like a
nicer round number anyway.
2014-01-19 13:40:11 +00:00
Tom Hughes
45618726ef Reenable the note search API
Add a postgress freetext index on the note comments, and enable
note searching using freetext matching.
2014-01-15 19:58:58 +00:00
Tom Hughes
1e2b99a75b Disable notes search until it can be made scalable 2014-01-09 08:41:59 +00:00
Tom Hughes
0f2958aed4 Report an error if a bogus limit value is passed to a notes API call 2013-12-05 17:57:12 +00:00
Tom Hughes
d09009b1fa Allow moderators to reopen hidden notes 2013-11-28 20:25:36 +00:00
Tom Hughes
6c51b3cc0a Replace deprecated finder methods 2013-09-21 11:35:46 +01:00
Tom Hughes
9ab8111022 Replace deprecated scoped method with all 2013-09-21 11:35:46 +01:00
Tom Hughes
f0feca800d Replace attr_accessible with strong parameters 2013-09-21 11:35:46 +01:00
Tom Hughes
f03c8637f7 Extract common code for parsing floats 2013-06-24 22:44:17 +01:00
Ian Dees
9d2fed811f Guard against non-numeric lat and lons in nodes and notes 2013-06-24 22:34:09 +01:00
Tom Hughes
21d2fa4f36 Don't send notifications when a note is deleted 2013-06-21 08:52:59 +01:00
Tom Hughes
cc8bfc07bb Force notes list to be realised in notes#mine
There is a rails bug which means that using count on a relation
that uses uniq and offset/limit and which hasn't been realised
yet will always return one, so force it to be realised.
2013-06-10 23:45:06 +01:00
Tom Hughes
d74d4f8d19 Add a reopen API call for notes 2013-06-10 18:52:50 +01:00
Tom Hughes
95c3a4439e Call set_locale for all notes actions 2013-04-24 10:51:37 +01:00
Tom Hughes
4b669ec1ae Return an updated copy of the note from the delete call 2013-04-08 22:00:26 +01:00
Tom Hughes
030bb31ec1 Allow a comment to be supplied when hiding a note 2013-04-08 21:29:41 +01:00
Tom Hughes
f4b599e8fd Restriction note deletion to moderators 2013-04-08 21:21:31 +01:00
Tom Hughes
97e0d5ad1f Add a new write_notes permission needed for OAuth access to notes 2013-03-28 18:50:18 +00:00
Tom Hughes
38255f9f8d Use OAuth for notes API calls and require authentication to close 2013-03-28 00:34:23 +00:00
Tom Hughes
eed9de5483 Reject attempts to create notes with no comment text 2013-02-05 21:54:03 +00:00
Tom Hughes
d1aa084d28 Reject note comments with no text 2013-02-05 18:46:41 +00:00
Tom Hughes
ae27f7adbe Make the API reject changes to closed notes 2013-02-05 18:08:42 +00:00
Tom Hughes
6279d83260 Pass parameters to APIAlreadyDeletedError correctly 2013-02-05 18:08:11 +00:00
Tom Hughes
8e5364b2f2 Only show each note once is the user notes view 2013-02-03 11:07:01 +00:00
Tom Hughes
9d3b419aad Improve styling of the per-user notes list view 2013-02-02 14:29:45 +00:00
Tom Hughes
ba5107ebb5 Remove the author_name field from notes 2012-12-03 14:50:54 +00:00
Kai Krueger
0a3aba7f89 Remove nearby_place from the note model
Instead of storing the auto-generated meta information nearby_place
in the database, just look up the information on the fly when needed
and cache it for performance.
2012-12-01 18:18:09 +00:00
Tom Hughes
e2f1d6017d Update list of filtered methods in notes controller 2012-10-16 12:15:37 +01:00
Tom Hughes
8b917ccd60 Allow an optional comment to be given when closing a note 2012-10-14 16:01:35 +01:00