Commit graph

50 commits

Author SHA1 Message Date
Tom Hughes
3af16f6337 erblint: fix remaining single quoted strings 2019-03-27 16:15:19 +00:00
Andy Allan
74b91c0e3e erblint: Add or remove curly braces around hash parameters as required 2019-03-27 10:30:48 +01:00
Andy Allan
3c410bcd7e Whitespace fixes for browse erb files 2019-03-26 20:23:35 +00:00
Andy Allan
1778fa3d9c Move the api methods from changesets_controller into the api namespaced controller 2019-02-24 12:18:31 +01:00
Andy Allan
8a2df0e0b5 More resourceful routing for nodes, ways, relations and changesets controllers 2019-01-16 13:10:11 +01:00
Andy Allan
252b9ef08a Pluralize changesets controller 2018-11-14 10:34:28 +01:00
Andy Allan
3ec67ea2d3 Rename user_controller to users_controller 2018-10-03 15:31:10 +02:00
Tom Hughes
5a2d2f97ce Update changeset browse view for renaming of changeset#list to changeset#index 2018-09-09 12:36:34 +01:00
Andy Allan
e1c62f1bf2 Remove if_user and similar methods
Rather than hiding features based on CSS, just avoid including them
in the output. Fixes #1862
2018-05-16 13:05:20 +08:00
Andy Allan
5bed217823 Use lazy translations where possible 2018-04-25 14:10:59 +08:00
Andy Allan
9f84c6f46e Use user_path links. Fixes #1785 2018-03-21 11:33:45 +08:00
mmd-osm
965123372d Added explanation about discussions on open changesets
Closes #1705
2017-12-18 21:19:35 +00:00
Andy Allan
c819bec8b7 Use a current_user helper for accessing the logged in user in all views. 2017-07-27 10:07:51 +01:00
Simon Legner
f3fa97fc63 Wrap user name in bdi to provide a separate RTL context
Fixes #1179
Closes #1183
2016-03-14 21:20:03 +00:00
Tom Hughes
18b8fc60bb Add rel=nofollow to links to tagless nodes in browse pages 2015-12-20 00:19:16 +00:00
Tom Hughes
316ebb7570 Don't pass ActiveRecord objects to find and exists? 2015-01-10 12:41:16 +00:00
Łukasz Gurdek
14ac1babc2 Changeset discussions
Add support for commenting on changesets with RSS feeds and email
notification of comments to other commenters and people that have
chosen to subscribe to a changeset.
2014-10-23 21:24:51 +01:00
Tom Hughes
5da273027f Isolate object names from the database with a <bdi> tag
Fixes #743
2014-05-18 17:24:38 +01:00
Tom Hughes
5c53bb78ab Don't linkify comments in the changeset list
It's confusing to make links in comments active in the changeset list
as the rest of the comment is an active link to the changeset.

We do want to make them active in the changeset view however, so add
linkification to the comment there.

Fixes https://trac.openstreetmap.org/ticket/5061
2013-12-08 13:11:48 +00:00
John Firebaugh
954261fb1c Restore prev/next changeset by user links 2013-11-22 12:17:27 -08:00
Aaron Lidman
f45437f836 Reorder changeset detail lists
Nodes, ways, relations -> Ways, relations, nodes
2013-11-18 16:24:25 -08:00
John Firebaugh
9dd230d0bc Refactor browse templates 2013-11-12 13:22:55 -08:00
John Firebaugh
e670da54cb Rationalize browse translation keys 2013-11-12 12:51:33 -08:00
John Firebaugh
c4090bb150 Improve browse design 2013-11-12 09:03:23 -08:00
Aaron Lidman
1ae7872ed8 Update title on pushState, closes #33 2013-11-08 16:10:08 -08:00
Aaron Lidman
b2a82f501d Float the close icon, closes #40 2013-11-08 12:01:20 -08:00
Aaron Lidman
4b2bd4835d Fixed changeset time inconsistencies 2013-11-07 12:19:00 -08:00
Eden Halperin
9c437557c9 Fix changeset byline style 2013-11-07 11:10:52 -05:00
John Firebaugh
d8cf49f0d7 Improve pagination in changeset details 2013-11-06 17:28:39 -08:00
Aaron Lidman
e7d200c4a6 Sidebar close reverts to 'view' state 2013-11-06 16:59:14 -08:00
Aaron Lidman
694fa065c0 Split come changset display logic into a helper 2013-11-06 13:59:42 -08:00
Eden Halperin
baaacfc7c0 Browse page style tweaks 2013-11-06 15:45:57 -05:00
John Firebaugh
39ffcbc6a2 Fix merge conflict 2013-11-06 11:10:02 -08:00
Eden Halperin
582ab35ecd groundwork for responsive menu 2013-11-06 10:31:49 -05:00
Aaron Lidman
d1cc387080 Improve changeset template 2013-11-05 18:28:11 -08:00
Aaron Lidman
ba9456066f Add close icons 2013-11-05 15:03:08 -08:00
Aaron Lidman
9f3dace353 Improve pagination 2013-11-05 12:25:54 -08:00
Aaron Lidman
51a21e6738 Consistent headers and footers in sidebar 2013-11-05 10:04:45 -08:00
Aaron Lidman
1cded7d151 Rejig changeset details in the style of danstowell 2013-11-04 15:24:50 -08:00
John Firebaugh
054f934f27 Eliminate separate browse.css asset 2013-10-13 14:46:07 -07:00
John Firebaugh
4557654ba6 Simplify layouting 2013-10-13 14:46:07 -07:00
John Firebaugh
4cc2b63d5c Factor javascript include tag to layout 2013-10-13 14:46:06 -07:00
John Firebaugh
b30983f02b Convert browse details to sidebar layout 2013-10-13 14:45:58 -07:00
Saman Bemel-Benrud
a36f3558dd Site cleanup
I set out to do a quick and dirty typography overhaul to make things
more consistent and a bit cleaner, but I kept running into things I
didn't like, so this lead me down something of a rabbit hole of design
tweaks to the OSM site.

Goals here are to have better content hierarchy, better vertical
rhythm, more consistent UI, cleaner markup with less tables, all while
keeping the basics pretty much intact. There are a lot of things I
didn't touch even though they need to be updated (lots of tables where
stuff shouldn't be tables, mostly).

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now
a lot easier to know what you're looking at. The header has a page
title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more
rhythm and breathing room throughout the site.

I know there are other problems here or things I've missed - would
love another set of eyes to look over this! I am still getting comfortable
working on the site - it's my first time ever digging into a ruby or rails
so I'm not familiar with the templating language yet.
2013-01-14 21:27:08 +00:00
Tom Hughes
bd12ec7a8b Present links at the bottom of data browser pages in a consistent way 2012-07-11 14:42:02 +01:00
Tom Hughes
b63ce5d460 Mark some locale lookups as raw 2011-11-14 09:42:52 +00:00
Tom Hughes
7f1ce59f32 Rename browser-icons to browse everywhere and only load CSS when needed 2010-05-16 12:32:51 +01:00
Tom Hughes
54bed8e9c0 Improve layout of data browser pages
Use float to position the navigation controls and map on the right
rather than a table so that we get more consistent positioning and
avoid forcing the map of the right hand side of the viewport.
2010-04-22 23:05:20 +01:00
Tom Hughes
d63f605893 Add some more detail to the changeset Atom feeds. 2009-07-05 23:46:28 +00:00
Tom Hughes
2e2f212472 Rename views to rails 2 style names. 2009-06-09 20:50:14 +00:00
Renamed from app/views/browse/changeset.rhtml (Browse further)