Commit graph

566 commits

Author SHA1 Message Date
Andy Allan
a08fe1c291 Use list-inline to achieve spacing between elements on a line
This is a better solution than spans and margins. Additionally, rework
to use mb-* instead of my-* (bootstrap advises against using margin-top)
and get rid of <br>s by using paragraphs instead.
2021-03-17 18:57:36 +00:00
Andy Allan
4dc584421a Refactor traces list display
Ideas taken from #3036
2021-03-17 18:04:00 +00:00
Andy Allan
38ad8fbc36 Use login_path instead of explicit controller and actions
This makes future refactoring easier.
2021-03-10 14:31:55 +00:00
Tom Hughes
1f136a84a6 Prevent CSRF bypass with login form 2021-02-10 20:39:23 +00:00
Tom Hughes
51af102c00 Prevent CSRF bypass with password reset form 2021-02-09 23:00:21 +00:00
mmd-osm
c49e400aa3 Prevent CSRF bypass unblocking users 2021-02-09 20:39:04 +00:00
Tom Hughes
7810734ac4 Prevent CSRF bypass updating account details
Fixes #3089
2021-02-08 12:24:43 +00:00
Tom Hughes
e430bc0f7f Fix URL generation for atom feed on history page
Fixes #3085
2021-02-07 16:24:14 +00:00
mmd-osm
4e6d729529 Remove /api/0.6/changes endpoint
Also removes sql functions which are only used by this endpoint
2021-02-03 14:06:34 +00:00
Andy Allan
a7d959e588 Refactor account form to use bootstrap
There's further refactoring that could be done, but this is sufficient for now.
2021-01-27 17:59:58 +00:00
Andy Allan
cc8bb7c6a5 Refactor user registration form to use bootstrap 2021-01-20 15:38:10 +00:00
Tom Hughes
812f5b44e8 Redirect after saving settings in case the username has changed
Fixes #3059
2021-01-19 18:57:34 +00:00
Tom Hughes
0654be27f9 Fix new rubocop warnings 2021-01-11 19:17:31 +00:00
Tom Hughes
0ff89c31e4 Remove both Potlatch versions
Fixes #2622
2021-01-05 21:18:45 +00:00
Tom Hughes
786b8cce65 Verify that public and trackable traces don't return identity details 2020-12-30 17:58:04 +00:00
Tom Hughes
bfffe7ed96 Prefer string interpolation to concatenation 2020-11-13 11:32:28 +00:00
Tom Hughes
93e49daee2 Merge remote-tracking branch 'upstream/pull/2918' into master 2020-10-28 11:29:57 +00:00
Andy Allan
da2277505f Ensure that test utility methods are marked as private
This allows us to enable the check for test method names.
2020-10-28 11:49:01 +01:00
Andy Allan
c04d05686f Resolve some extra-long lines 2020-10-28 11:07:34 +01:00
Tom Hughes
2dc50b4431 Fix new rubocop warnings 2020-10-09 08:26:38 +01:00
Tom Hughes
ddac660f3b Merge remote-tracking branch 'upstream/pull/2839' 2020-09-30 11:54:30 +01:00
mmd-osm
37a7996d94 API User details: format tweaks
- _show_ to return single user only
- remove nesting for languages
2020-09-18 21:50:38 +02:00
mmd-osm
dff8effc13 Json user details: unit tests 2020-09-16 22:13:19 +02:00
mmd-osm
9f280be82b Fix unit test, assume application/xml instead of text/xml 2020-09-16 21:01:54 +02:00
Tom Hughes
21adea321b Convert password reset forms to use bootstrap 2020-09-04 00:36:43 +01:00
Tom Hughes
c11142d5c0 Convert logout form to use bootstrap 2020-09-03 23:52:59 +01:00
Tom Hughes
ea59d95f4a Fix some new rubocop warnings 2020-08-06 22:27:30 +01:00
Tom Hughes
0e2a66e8de Fix new rubocop warnings 2020-08-06 18:42:16 +01:00
Tom Hughes
c24c2e481c Merge remote-tracking branch 'upstream/pull/2667' 2020-08-05 21:50:08 +01:00
Tom Hughes
2d3972249c Fix some rubocop todos 2020-08-02 19:38:58 +01:00
Andy Allan
47d11763fb Add some changsets that shouldn't be selected 2020-07-22 17:51:43 +02:00
Andy Allan
e7dc2f2e55 Refactor changeset index testing to assert against objects, not db queries
This avoids the situation where tests pass despite an empty db.

Refs #2614
2020-07-22 17:39:48 +02:00
Andy Allan
b23d6a5445 Refator way_full test to avoid relying on non-existant fixtures
Refs #2614
2020-07-22 16:33:33 +02:00
Andy Allan
41d6f19a6b Rename the notes#mine action to index 2020-07-08 18:43:30 +02:00
Andy Allan
8d2271699b Use bootstrap_form as the formbuilder for GPX upload form
This also uses the recommended bs-custom-file-input javascript plugin
for the file input control.
2020-07-01 17:23:02 +02:00
Andy Allan
600812f6ad Rework user#set_status and #delete to avoid GET requests
This renames the delete action to destroy, and starts using resourceful
routing for user actions.
2020-06-10 11:49:18 +02:00
Andy Allan
8ebfdbc1ff Move make_friend and remove_friend to friendships controller 2020-06-03 18:23:07 +02:00
Andy Allan
59c90aa023 Move friendship related tests to separate file 2020-06-03 17:51:11 +02:00
Andy Allan
3a16c465f7 Refactor user controller tests
Because we don't have direct access to the session and cookies, some
of the tests need more setup e.g. by moving through the signup process
to get the session tokens into the right place for the confirmation
steps to work.
2020-05-13 18:08:22 +02:00
Andy Allan
36a1f38109 Refactor api traces_controller tests 2020-05-13 18:08:07 +02:00
Tom Hughes
7ffa2e96be Refactor users_controller_test and user_preferences_controller_test 2020-05-07 19:34:48 +01:00
Tom Hughes
2d37f1a03c Refactor notes_controller_test 2020-05-06 18:39:48 +01:00
Tom Hughes
45e560bef6 Add test for browsing a note closed by a deleted user 2020-05-06 18:06:45 +01:00
Andy Allan
f84980f183 More controller test refactoring 2020-05-06 16:51:04 +02:00
Tom Hughes
9a87412d2a Refactor permissions_controller_test 2020-05-05 19:40:52 +01:00
Tom Hughes
c576edecd4 Refactor versions_controller_test 2020-05-05 19:36:38 +01:00
Tom Hughes
93f1489048 Refactor tracepoints_controller_test 2020-05-05 19:28:42 +01:00
Tom Hughes
f898cecb5c Refactor map_controller_test 2020-05-05 19:19:43 +01:00
Tom Hughes
7e1a4b6884 Refactor changeset comments API controller tests 2020-05-05 18:04:48 +01:00
Tom Hughes
749ca5d5a0 Refactor the AMF controller API tests 2020-05-05 17:45:46 +01:00