Commit graph

1011 commits

Author SHA1 Message Date
Andy Allan
d595577a49 Convert the duplicate_tags node controller test to use factories. 2017-04-24 20:41:43 +02:00
Andy Allan
b375050e6c Use node and relation_member factories for testing containing_relations and containing_relation_members 2017-04-05 11:33:33 +01:00
Andy Allan
df721bc653 Convert more node fixtures to factories 2017-03-31 10:51:18 +01:00
Andy Allan
5ab082a047 Add the closed trait to changeset factories. 2017-03-31 10:47:41 +01:00
Andy Allan
1b7ab315bb Add factories for relations, relation_members, ways and way_nodes 2017-03-31 10:40:49 +01:00
Tom Hughes
66d74a8c2c Merge remote-tracking branch 'openstreetmap/pull/1507' 2017-03-30 15:18:14 +01:00
Andy Allan
6afd13602c Fix tests that referred to node lat and lons 2017-03-30 15:13:22 +01:00
Andy Allan
4fb775d6d5 Format latitudes and longitudes as %7f in XML output
This matches the double formatting in XML from cgimap. Fixes #341.
2017-03-30 14:30:54 +01:00
Andy Allan
06814eb715 Use node factories for browse_controller tests. 2017-03-30 13:57:30 +01:00
Andy Allan
66ae9a48a6 For deleted nodes created via factories, make sure the most recent old_node is also deleted 2017-03-30 13:57:07 +01:00
Andy Allan
17e9bcd2d4 Use factories for nodes in browse_helper tests. 2017-03-30 13:19:24 +01:00
Andy Allan
5a0ba2e812 Add a with_history trait for node factories, to automatically create corresponding old_nodes 2017-03-30 09:31:22 +01:00
Tom Hughes
8a565061e3 Add explicit tests for lat/lon methods on node models 2017-03-22 20:43:39 +00:00
Tom Hughes
9ae3df1a78 Use changeset factory for association in node factory 2017-03-22 20:31:25 +00:00
Tom Hughes
b78bb9f631 Merge remote-tracking branch 'openstreetmap/pull/1496' 2017-03-22 19:19:59 +00:00
Andy Allan
4ed1607784 Use node and old_node factories for redaction model tests. 2017-03-22 18:19:16 +00:00
Andy Allan
1a3130ec61 Create a node factory, and use it for most node model tests 2017-03-22 17:50:10 +00:00
Andy Allan
2d3ca85751 Use old_node factory for OldNode model tests.
The valid/invalid tests were simplified, since there is little to be
gained from inserting (invalid) nodes into the database and comparing
the node with another copy of itself.
2017-03-22 17:10:48 +00:00
Andy Allan
88ca1f9ed8 Rework the changeset helper tests to use factories. 2017-03-22 11:42:29 +00:00
Andy Allan
24cd3af31e Use changeset factory for factory associations
One test needed updating since it assumed the comments were being
created on a particular changeset.
2017-03-22 11:09:52 +00:00
Andy Allan
56752ac02a Create a changeset factory, and use it for model tests. 2017-03-22 10:47:24 +00:00
Andy Allan
48be941840 Remove the api_fixtures call from changeset model tests, since they do not need the fixtures. 2017-03-22 10:40:13 +00:00
Tom Hughes
834a821d3c Merge remote-tracking branch 'openstreetmap/pull/1492' 2017-03-16 19:02:35 +00:00
Andy Allan
6331e34638 Remove the link between the redaction owner and the user doing the redaction in tests. 2017-03-16 10:21:25 +00:00
Andy Allan
d2998065dc Use redactions factory for old_way controller tests 2017-03-15 18:04:58 +00:00
Andy Allan
2cdc2e1cd8 Use redactions factory for old_node controller tests. 2017-03-15 17:50:57 +00:00
Tom Hughes
671467a6dd Merge remote-tracking branch 'openstreetmap/pull/1491' 2017-03-15 17:37:13 +00:00
Andy Allan
99d2bbccbb Use redaction factory for old_relation controller tests. 2017-03-15 17:13:47 +00:00
Andy Allan
5422c56301 Fix typos in assertion messages. 2017-03-15 17:06:29 +00:00
Andy Allan
a0899d1b0b Use redactions factory in redaction controller test. 2017-03-15 17:01:41 +00:00
Andy Allan
006627789f Create a redactions factory and use for model tests. 2017-03-15 16:24:39 +00:00
Andy Allan
5370f9c6a7 Refactor the oauth integration test to avoid using user fixtures. 2017-03-15 16:13:04 +00:00
Andy Allan
a6a1a6baa5 Use user factory for user_terms_seen integration test. 2017-03-15 15:53:47 +00:00
Andy Allan
1096bccf98 Use user factories for some changeset_controller tests.
Others are tightly interwoven with the fixtures and will be tackled seperately.
2017-03-15 15:41:42 +00:00
Tom Hughes
8ccd7364cd Merge remote-tracking branch 'openstreetmap/pull/1488' 2017-03-15 14:22:59 +00:00
Andy Allan
8d2d6e1a52 Use a pending user for testing password resets. 2017-03-15 14:22:04 +00:00
Andy Allan
3d8dc64b9c Use users factory for user_controller tests. 2017-03-15 11:56:36 +00:00
Tom Hughes
7c9229fbfc Throw an exception if adding a note comment fails 2017-03-13 14:49:16 +00:00
Andy Allan
17ff182c96 Build pending users via factory 2017-03-13 10:20:06 +00:00
Simon Poole
9606e440bc Return maximum size of bounding box for note retrieval 2017-03-13 08:53:49 +01:00
Tom Hughes
ae4c00da8c Merge remote-tracking branch 'openstreetmap/pull/1484' 2017-03-10 15:58:57 +00:00
Tom Hughes
47a5d2f37d Add some whitespace 2017-03-10 15:34:34 +00:00
Andy Allan
113506bf51 Use user factories for user_login integration tests.
The display_name logins were reworked to use downcase since the
factories supply users with an already-title-cased display_name.

The tests were also renamed to align better with the purpose of the
test rather than the name of the fixture used.
2017-03-10 14:53:36 +00:00
Andy Allan
b690feba15 Use user factories for page_locale integration tests. 2017-03-10 14:53:19 +00:00
Andy Allan
dfbb952707 Use user factories for user_block integration tests. 2017-03-10 14:48:29 +00:00
Andy Allan
4165bc0362 Use user factories for user_roles integration tests. 2017-03-10 11:02:40 +00:00
Andy Allan
1a1d924ae0 Use user factory for user_creation test. 2017-03-10 10:57:46 +00:00
Andy Allan
5de04a8cc2 Use user factory for application_helper tests. 2017-03-10 10:53:00 +00:00
Andy Allan
5ae96d6cb7 Use user factory for note_helper tests. 2017-03-10 10:33:59 +00:00
Tom Hughes
685df702ef Merge remote-tracking branch 'openstreetmap/pull/1483' 2017-03-09 18:35:57 +00:00