Tom Hughes
0654be27f9
Fix new rubocop warnings
2021-01-11 19:17:31 +00:00
Tom Hughes
0ff89c31e4
Remove both Potlatch versions
...
Fixes #2622
2021-01-05 21:18:45 +00:00
Tom Hughes
786b8cce65
Verify that public and trackable traces don't return identity details
2020-12-30 17:58:04 +00:00
Tom Hughes
bfffe7ed96
Prefer string interpolation to concatenation
2020-11-13 11:32:28 +00:00
Tom Hughes
93e49daee2
Merge remote-tracking branch 'upstream/pull/2918' into master
2020-10-28 11:29:57 +00:00
Andy Allan
da2277505f
Ensure that test utility methods are marked as private
...
This allows us to enable the check for test method names.
2020-10-28 11:49:01 +01:00
Andy Allan
c04d05686f
Resolve some extra-long lines
2020-10-28 11:07:34 +01:00
Tom Hughes
2dc50b4431
Fix new rubocop warnings
2020-10-09 08:26:38 +01:00
mmd-osm
37a7996d94
API User details: format tweaks
...
- _show_ to return single user only
- remove nesting for languages
2020-09-18 21:50:38 +02:00
mmd-osm
dff8effc13
Json user details: unit tests
2020-09-16 22:13:19 +02:00
mmd-osm
9f280be82b
Fix unit test, assume application/xml instead of text/xml
2020-09-16 21:01:54 +02:00
Tom Hughes
ea59d95f4a
Fix some new rubocop warnings
2020-08-06 22:27:30 +01:00
Tom Hughes
0e2a66e8de
Fix new rubocop warnings
2020-08-06 18:42:16 +01:00
Tom Hughes
2d3972249c
Fix some rubocop todos
2020-08-02 19:38:58 +01:00
Andy Allan
b23d6a5445
Refator way_full test to avoid relying on non-existant fixtures
...
Refs #2614
2020-07-22 16:33:33 +02:00
Andy Allan
36a1f38109
Refactor api traces_controller tests
2020-05-13 18:08:07 +02:00
Tom Hughes
7ffa2e96be
Refactor users_controller_test and user_preferences_controller_test
2020-05-07 19:34:48 +01:00
Tom Hughes
2d37f1a03c
Refactor notes_controller_test
2020-05-06 18:39:48 +01:00
Andy Allan
f84980f183
More controller test refactoring
2020-05-06 16:51:04 +02:00
Tom Hughes
9a87412d2a
Refactor permissions_controller_test
2020-05-05 19:40:52 +01:00
Tom Hughes
c576edecd4
Refactor versions_controller_test
2020-05-05 19:36:38 +01:00
Tom Hughes
93f1489048
Refactor tracepoints_controller_test
2020-05-05 19:28:42 +01:00
Tom Hughes
f898cecb5c
Refactor map_controller_test
2020-05-05 19:19:43 +01:00
Tom Hughes
7e1a4b6884
Refactor changeset comments API controller tests
2020-05-05 18:04:48 +01:00
Tom Hughes
749ca5d5a0
Refactor the AMF controller API tests
2020-05-05 17:45:46 +01:00
Andy Allan
2e3522a2f6
Refactor changesets_controller_test
...
Introduces some route names which need to be unique from the non-api versions
2020-04-29 17:42:08 +02:00
Andy Allan
e765a6691b
Refactor more controller tests
2020-04-29 17:28:42 +02:00
Tom Hughes
7a1615bc55
Fix rubocop-minitest warnings
2020-04-15 19:07:13 +01:00
Andy Allan
1cb0767e3d
Copy trace fixture files, rather than symlinking
...
Since we are using tmpdirs in order to enable parallel testing, we
can go the full hog and drop the fakefs too and just copy all the
files directly into the tmpdir. If a test makes changes (e.g.
changing the icon file during an import) the copy in the tmpdir is
thrown away at the end of the test anyway.
2020-03-18 15:35:55 +01:00
Andy Allan
979a474c68
Use unique test directories for each trace test
...
This allows tests to be run in parallel, since it avoids deleting
some of the symlinks that other tests expect to be there.
2020-03-18 15:04:18 +01:00
Andy Allan
73c95847a6
Merge pull request #2485 from mmd-osm/patch/json2
...
JSON output nodes, ways, relations, map
2020-02-26 15:55:48 +01:00
mmd-osm
3159c3c3f7
JSON: return HTTP 406 for unsupported formats
2020-01-22 22:33:30 +01:00
mmd-osm
b556b054d1
JSON: added clarification for non-supported Accept header formats
2020-01-22 17:38:28 +01:00
mmd-osm
03ca0b2c69
Added Accept header unit tests
2020-01-12 17:46:11 +01:00
mmd-osm
91b31f03de
Added unit tests
2020-01-08 19:57:21 +01:00
Tom Hughes
473da378b7
Remove fallback to hostip.info
...
We haven't used hostip.info in production for years, except
for when we did so by accident, leading to a two hour partial
outage when it went down.
2020-01-06 19:14:12 +00:00
mmd-osm
b54333fa6d
Unify lat/lon formatting for json output
2020-01-02 14:52:53 +01:00
mmd-osm
75a49786f8
API JSON output
2019-12-30 16:37:52 +01:00
Andy Allan
7595e5a4dd
Use squiggly heredocs instead of rails strip_heredoc
...
Squiggly heredocs were introduced in ruby 2.3 and I prefer the ability
to indent the closing heredoc marker.
2019-12-11 10:54:19 +01:00
Tom Hughes
57f5b7840e
Fix rubocop warnings
2019-12-04 19:31:53 +00:00
Andy Allan
f1c6a87aa1
Merge pull request #2427 from mmd-osm/patch/remove_expand_bbox
...
Remove expand_bbox endpoint
2019-12-04 12:48:34 +01:00
Tom Hughes
c468af5fbd
Errors have text/plain as the content type
2019-11-24 11:05:02 +00:00
Tom Hughes
1f4d48eaf3
Fix some deprecation warnings
2019-11-24 11:05:02 +00:00
Tom Hughes
22cd2314e5
Update to rails 6.0.1
2019-11-24 11:05:02 +00:00
Tom Hughes
6ec02bcdb2
Merge remote-tracking branch 'upstream/pull/2440'
2019-11-20 19:01:13 +00:00
Andy Allan
25ebf87e5a
Rename UserPreference controller methods to follow rails conventions more closely
2019-11-20 16:09:48 +01:00
Andy Allan
bc850d1d37
Move Relation.to_xml and to_xml_node out of the model and into tests
2019-11-20 15:45:28 +01:00
Andy Allan
2b1bac1279
Move Way.to_xml and to_xml_node out of the model and into tests
...
This code is only used in the tests. Refs #2433
2019-11-20 15:31:47 +01:00
Andy Allan
4e7c0c3008
Move Node.to_xml and to_xml_node out of model and into tests
...
This code is only used in the tests for creating 'fixture' payloads,
so it shouldn't be kept in the models.
2019-11-13 17:01:40 +01:00
Andy Allan
ae5c364e97
Move the format tests to test the output from the controller
2019-11-13 15:21:41 +01:00