Commit graph

50 commits

Author SHA1 Message Date
Tom Hughes
1c77d2432e Avoid using rinku's auto_link helper
It's currently broken (https://github.com/vmg/rinku/issues/70) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Tom Hughes
e16311125e Use Hash#dig to simplify code 2017-10-05 20:22:24 +01:00
Tom Hughes
8dae890a76 Fix rubocop warnings 2017-10-05 19:18:38 +01:00
Tom Hughes
fe1e28b4f4 Fix more parameter sanitisation issues and add tests 2017-06-29 20:52:57 +01:00
Tom Hughes
03408b6294 Update get/post etc to remove use of deprecated syntax 2017-06-27 08:26:44 +01:00
Andy Allan
060230fb94 Ensure closed changesets appear in the feed, and update some misleading comments. 2017-06-01 15:43:51 +01:00
Andy Allan
162949817d Rubocop fixes. 2017-06-01 10:58:34 +01:00
Andy Allan
4cd2d22788 Update rubocop class length limit. 2017-05-31 16:24:46 +01:00
Andy Allan
fffc572767 Convert more changeset controller tests to use factories. 2017-05-31 12:29:42 +01:00
Andy Allan
6b6d2447e3 Refactor more changeset_controller tests to use factories. 2017-05-24 17:31:56 +01:00
Tom Hughes
3d7fd13357 Adjust rubocop threshold 2017-03-15 17:57:46 +00:00
Andy Allan
8b9ad9bf4b Use user factory for user_roles_helper test 2017-03-09 17:12:11 +00:00
Tom Hughes
91e33f50bc Fix rubocop warning 2017-02-22 17:55:47 +00:00
Tom Hughes
970e1a99d7 Merge remote-tracking branch 'openstreetmap/pull/1367' 2016-12-18 16:29:33 +00:00
Tom Hughes
fc0aebc1a8 Merge remote-tracking branch 'openstreetmap/pull/1352' 2016-10-30 16:59:20 +00:00
Andy Allan
acb7f44069 Replace fixtures with a factory for old_node_tags
Also includes a slight simplification of the old_node_tags tests.
2016-10-30 15:36:33 +01:00
Andy Allan
596494a590 Replace changeset_tags fixtures with a factory. 2016-10-30 12:45:02 +01:00
Andy Allan
4eeea7e705 Remove the changesets_subscribers fixture.
Since there is no ChangesetsSubscribers model, we can't use a factory.
Instead we create the associations explicitly when needed.
2016-10-30 12:23:23 +01:00
Tom Hughes
e17b89e89f Fix rubocop warnings 2016-10-20 22:35:51 +01:00
Tom Hughes
291f43c7e2 Fix rubocop warning 2016-10-12 19:28:10 +01:00
Tom Hughes
5f4dcd34ff Fix some rubocop warnings 2016-09-15 22:41:07 +01:00
Andy Allan
5ec11d3571 Update offense counts in rubocop_todo.yml 2016-09-07 11:08:20 +01:00
Andy Allan
e6f06f0515 Add outer variable shadowing to rubocop_todo.yml 2016-09-07 11:06:27 +01:00
Tom Hughes
47e6637f18 Fix rubocop warnings 2016-08-16 19:27:14 +01:00
Tom Hughes
dd8ebf9b09 Fix rubocop warnings 2016-07-13 09:50:23 +01:00
Tom Hughes
246d8a4452 Test titles in changeset feed 2016-03-14 21:18:26 +00:00
Simon Legner
6f144e8b7d Show ref of object when no name is present 2016-03-09 18:47:54 +00:00
Tom Hughes
18b8fc60bb Add rel=nofollow to links to tagless nodes in browse pages 2015-12-20 00:19:16 +00:00
Holger Jeromin
37a4fc6dd1 Add srcset to img tags inside picture elements
Some browsers (in particular Safari on iOS) don't support picture
yet but do support srcset on the img tag.
2015-09-15 08:48:50 +01:00
Tom Hughes
d377e8b4f2 Use picture elements to render some more graphics as SVG 2015-09-13 22:42:12 +01:00
Tom Hughes
c9d35839be Fix new rubocopy warnings 2015-08-18 20:57:14 +01:00
Tom Hughes
957d75295b Fix warnings from rubocop update 2015-06-08 15:59:17 +01:00
Tom Hughes
2af0840ff3 Fix style issues found by new rubocop version 2015-04-14 09:38:24 +01:00
Tom Hughes
f8de0c1811 Ever more tests... 2015-03-08 16:47:35 +00:00
Tom Hughes
7fef0353f2 More test work 2015-03-08 00:48:13 +00:00
Tom Hughes
77e8a16a15 Avoid relying on the order in which emails are sent 2015-03-05 00:16:26 +00:00
Tom Hughes
21d60e359a Tests! 2015-03-04 21:49:43 +00:00
Tom Hughes
dfc85f089a Test changeset and note comment notification emails 2015-03-02 00:43:07 +00:00
Tom Hughes
d4d1527a92 Fix rubocop warnings 2015-02-27 07:08:55 +00:00
Tom Hughes
dbe165bbb3 Fix some rubocop rails style issues 2015-02-26 00:12:54 +00:00
Tom Hughes
750484d1b5 Add rails cops to rubocop todo 2015-02-25 00:32:12 +00:00
Tom Hughes
a6b84a0294 Fix more rubocop style issues 2015-02-24 23:12:02 +00:00
Tom Hughes
8e404f3a46 Fix some more rubocop style issues 2015-02-20 20:39:52 +00:00
Tom Hughes
4f4180e4bd Standardise on "hash rocket" style for hashes 2015-02-20 19:53:13 +00:00
Tom Hughes
dc2a2c8ebd Standardise on double quoted strings 2015-02-20 19:47:26 +00:00
Tom Hughes
5cbd4038ed Fix rubocop style issues 2015-02-20 08:56:16 +00:00
Tom Hughes
baf10cd392 Fix rubocop lint issues 2015-02-20 08:56:16 +00:00
Tom Hughes
ef7f3d800c Fix most auto-correctable rubocop issues 2015-02-20 08:56:16 +00:00
Tom Hughes
34e3e51456 Cleanup trailing whitespace 2015-02-20 08:56:16 +00:00
Tom Hughes
e1f79d84ad Add rubocop config with impressively large todo list 2015-02-20 08:56:15 +00:00