Tom Hughes
1f2ac59d1d
Fix new rubocop warnings
2018-03-26 19:00:03 +01:00
Tom Hughes
673b58f96f
Merge remote-tracking branch 'upstream/pull/1704'
2018-02-04 15:09:40 +00:00
Tom Hughes
a83030dab7
Fix new rubocop warnings
2018-01-22 18:55:45 +00:00
mmd-osm
b2a3955d93
Allow (un)subscribing discussions also when changeset still open
...
Fixes #1627
2017-12-16 13:32:04 +01:00
Tom Hughes
2c52c91b39
Make changeset#query preload users, tags and comments
2017-12-04 07:54:19 +00:00
Tom Hughes
b6b9d543ac
Fix rubocop warnings
2017-10-29 19:43:02 +00:00
Andy Allan
d581f17665
Avoid using or comparing explicit model ids
...
The code is easier to read using higher-level concepts.
2017-10-22 21:58:09 +01:00
Tom Hughes
8dae890a76
Fix rubocop warnings
2017-10-05 19:18:38 +01:00
Andy Allan
6f89da05d1
Use current_user to represent the currently logged in user.
...
This is already used by the oauth plugin, and is a general rails convention.
2017-07-12 16:10:50 +01:00
Tom Hughes
ea9a4c2aa2
Convert XML document to a string when returning it
...
Otherwise the Rak::ETag module will throw an exception when it
tries to test if the response is empty.
2017-06-13 12:55:13 +01:00
Tom Hughes
03a9df9288
Replace render :nothing with head
2017-06-04 20:24:53 +01:00
Tom Hughes
80d27a7fae
Sanitise parameters used in URL generation
2017-06-02 20:27:07 +01:00
Tom Hughes
ff97501ed0
Remove all use of the :text option to render
...
It doesn't actually do what it says, as it sets the content type
to text/html not text/plain so is just confusing and as a result
has been deprecated in newer rails versions.
2017-06-02 19:12:05 +01:00
Andy Allan
060230fb94
Ensure closed changesets appear in the feed, and update some misleading comments.
2017-06-01 15:43:51 +01:00
Andy Allan
f464e2a6e9
Suppress XML parsing errors.
...
This technique was already used in app/models/changeset.rb
This suppresses the error messages when parsing invalid XML, but
the exceptions are still raised, as tested in test_from_xml_double_lat
in test/models/node_test.rb
2016-10-26 10:35:03 +01:00
Tom Hughes
e17b89e89f
Fix rubocop warnings
2016-10-20 22:35:51 +01:00
Tom Hughes
5d3ecffa28
Fix new rubocop warnings
2016-02-05 13:35:26 +00:00
Tom Hughes
8fe1899596
Fix rubocop warnings
2016-01-19 09:51:24 +00:00
Tom Hughes
081ac24295
Fix rubocop warnings
2015-11-19 21:41:33 +00:00
Tom Hughes
a082baebd7
Don't send changeset comment notifications to deleted users
2015-10-30 19:01:09 +00:00
Simon Legner
91bd0b4b12
Display number of comments in changeset list
2015-08-27 21:26:31 +02:00
Tom Hughes
c9d35839be
Fix new rubocopy warnings
2015-08-18 20:57:14 +01:00
Tom Hughes
6910434fe0
Apply a timeout to most changeset API calls
2015-08-14 19:55:11 +01:00
Tom Hughes
957d75295b
Fix warnings from rubocop update
2015-06-08 15:59:17 +01:00
Tom Hughes
ce3eabc203
Remove unreachable code
2015-03-09 00:17:08 +00:00
Tom Hughes
f8de0c1811
Ever more tests...
2015-03-08 16:47:35 +00:00
Tom Hughes
7fef0353f2
More test work
2015-03-08 00:48:13 +00:00
Tom Hughes
9fb8f5a84b
Drop the old output_compression plugin
...
The production servers all have mod_deflate enabled anyway, which
almost certainly does a better job of compression than this.
2015-03-01 10:52:28 +00:00
Tom Hughes
dbe165bbb3
Fix some rubocop rails style issues
2015-02-26 00:12:54 +00:00
Tom Hughes
dc2a2c8ebd
Standardise on double quoted strings
2015-02-20 19:47:26 +00:00
Tom Hughes
5cbd4038ed
Fix rubocop style issues
2015-02-20 08:56:16 +00:00
Tom Hughes
ef7f3d800c
Fix most auto-correctable rubocop issues
2015-02-20 08:56:16 +00:00
Tom Hughes
360d68ea5c
Replace deprecated deliver method with deliver_now
2015-01-11 12:53:06 +00:00
Tom Hughes
316ebb7570
Don't pass ActiveRecord objects to find and exists?
2015-01-10 12:41:16 +00:00
Tom Hughes
260a690b3d
Add comments_feed action to various filters
...
Fixes #825
2014-11-05 20:34:45 +00:00
Tom Hughes
8598db3233
Tidy up changeset comment code
2014-10-23 21:24:51 +01:00
Łukasz Gurdek
14ac1babc2
Changeset discussions
...
Add support for commenting on changesets with RSS feeds and email
notification of comments to other commenters and people that have
chosen to subscribe to a changeset.
2014-10-23 21:24:51 +01:00
Tom Hughes
56d39b06f2
Rename User#public to User#identifiable
2014-07-04 19:24:25 +01:00
Simon Legner
1d1f194d59
Extend API to allow changesets to be queried by ids
...
Make changesets queryable by specifying a list of ids, for example:
/api/0.6/changesets?changesets=1,2,3
This condition may be combined with others in the normal way.
2013-12-05 18:06:35 +00:00
John Firebaugh
d95361bcb9
Support legacy bbox param on /history as well
...
Fixes #586
2013-12-02 11:38:54 -08:00
Aaron Lidman
ccf7981c48
Sort changesets by id rather than created_at, closes #87
2013-11-25 12:27:52 -08:00
Tom Hughes
686aae7732
Block max_id for changeset feeds instead of page which is no longer used
2013-11-24 17:02:38 +00:00
Tom Hughes
532d108536
Make sure all pages using the map layout call require_oauth
2013-11-24 15:29:38 +00:00
John Firebaugh
d0de36b607
Refine changeset browse behavior
...
The general history view shows changesets in the current view
and updates when you move the map. The view for an individual
user, nearby users, or friends zooms the map to the extent of
the results, and doesn't change when you move the map.
2013-11-19 12:10:14 -08:00
John Firebaugh
e91956d0f7
Fix test failures
2013-11-19 10:30:18 -08:00
John Firebaugh
8530e3eedb
AJAXy changeset history
2013-10-13 14:46:09 -07:00
John Firebaugh
a56d1036d5
pushState based navigation between map-based layouts
2013-10-13 14:46:08 -07:00
John Firebaugh
4557654ba6
Simplify layouting
2013-10-13 14:46:07 -07:00
John Firebaugh
e8ac6bd5d9
Convert history page to sidebar layout
2013-10-13 14:45:58 -07:00
Tom Hughes
9ab8111022
Replace deprecated scoped
method with all
2013-09-21 11:35:46 +01:00