Commit graph

503 commits

Author SHA1 Message Date
Anton Khorev
18f3adbf5d Remove unused return value of addCreatedNoteMarker()
This function adds a marker to notes layer. This controller doesn't need to do anything with markers of existing notes.
2024-12-31 23:46:29 +03:00
Anton Khorev
ae5b7812cc Rename updateMarker() to addCreatedNoteMarker()
This function doesn't update any existing marker.
2024-12-31 23:46:29 +03:00
Anton Khorev
9d8ca8be11 Pass location instead of marker to createNote() 2024-12-31 23:42:40 +03:00
Anton Khorev
954eafd424 Move create note callback to button click handler 2024-12-31 23:37:34 +03:00
Anton Khorev
f169299b53 Don't pass url to createNote() 2024-12-31 23:25:11 +03:00
Anton Khorev
63a4f12550 Pass text instead of form to createNote() 2024-12-31 23:22:59 +03:00
Anton Khorev
fa0c12cdcd Disable new note submit button in click handler 2024-12-31 23:02:47 +03:00
Anton Khorev
c4709e2a05 Rename newNote to newNoteMarker 2024-12-31 22:37:41 +03:00
Anton Khorev
25e4a80760 Get note text only from textarea within left sidebar 2024-12-19 05:22:54 +03:00
Tom Hughes
8a020b3ec7 Don't send comment text when reopening a note
Fixes #5359.
2024-11-29 17:41:00 +00:00
Anton Khorev
aca9bd205e Add subscribe/unsubscribe buttons to note pages 2024-11-22 00:55:41 +03:00
Andy Allan
7f611b295f
Merge pull request #5151 from AntonKhorev/no-history-and-export-buttons
Move History and Export buttons to secondary nav
2024-11-13 19:15:59 +00:00
Anton Khorev
f6141277d5 Remove unused timer from new note js controller 2024-11-13 15:54:20 +03:00
Anton Khorev
771b75ed71 Replace query marker fade animation with css 2024-11-08 10:50:47 +03:00
Anton Khorev
34e0620463 Remove callback from initialize() in note js controller 2024-10-25 18:48:36 +03:00
Jakob Miksch
4f79ae4612
Typos in docs 2024-10-20 11:12:49 +02:00
Anton Khorev
7fb432dc32 Close small mode menu on some interactions 2024-09-03 02:59:18 +03:00
Anton Khorev
1e9603c7b1 Remove endpoint/input values on disable 2024-08-21 11:43:26 +03:00
Anton Khorev
a088b136fb Read lat/lon attributes when generating context menu directions urls 2024-08-20 14:55:29 +03:00
Anton Khorev
4f3576e91b Save lat/lon to input data attributes 2024-08-20 14:55:29 +03:00
Anton Khorev
b4925d7b0d Limit coordinate precision in drag listener 2024-08-20 14:55:29 +03:00
Anton Khorev
5a1e3e5c67 Replace geocode request boolean property with request object 2024-08-19 20:30:51 +03:00
Anton Khorev
a8838b3727 Remove endpoint markers in disable method 2024-08-19 20:30:51 +03:00
Anton Khorev
64da05f8ff Install endpoint listeners using enable/disable methods 2024-08-19 20:30:51 +03:00
Anton Khorev
93a9f31bf0 Show/hide "Where is this?" when setting search value from directions 2024-08-19 20:05:48 +03:00
Tom Hughes
41b81bd393 Merge remote-tracking branch 'upstream/pull/5083' 2024-08-18 12:16:22 +01:00
Anton Khorev
80c43f51c2 Copy "From" endpoint value to search input when closing directions 2024-08-16 18:48:05 +03:00
Anton Khorev
89a35fe11f Make getGeocode a private function 2024-08-16 08:57:39 +03:00
Anton Khorev
51cbbe6d5a Move empty value check out of endpoint.getGeocode 2024-08-16 08:54:23 +03:00
Anton Khorev
e624871eb4 Remove endpoint.hasGeocode state and related getRoute code
hasGeocode didn't actually indicated if an endpoint has a value acquired from a geocoder. It was set to true when at least one call to a geocoder finished successfully, including getting an empty result. getRoute doesn't need to know what calls were made, it only needs coordinates. It also doesn't get to decide when to fetch coordinates, this is done in drag/change callbacks.
2024-08-16 08:53:34 +03:00
Anton Khorev
ec6789920c Rename geocodeCallback to changeCallback, call it from latlon setValue
endpoint.setValue always calls changeCallback on its successful completion, with geocoding or without. This allows to decide when to call getRoute entirely from callbacks and event listeners.
2024-08-15 12:00:31 +03:00
Anton Khorev
f1ca64ff84 Make setLatLng a private function 2024-08-14 05:11:56 +03:00
Anton Khorev
f65593651f Don't set input value from endpoint.setLatLng()
This input value computed from coordinates is not always used. endpoint.getGeocode() overwrites it immediately.
2024-08-14 05:11:56 +03:00
Anton Khorev
e0df084e57 Don't call endpoint.setLatLng() from outside of endpoint module 2024-08-14 05:11:56 +03:00
Anton Khorev
415f497d89 Move endpoints code to its own module 2024-08-10 06:19:32 +03:00
Anton Khorev
567a9e5b23 Rename route request variable
It's not boolean, the comment was outdated.
2024-08-10 06:01:35 +03:00
Anton Khorev
d065f88b1a Remove references to global variables from endpoint drag listener
This causes visible input value updates even when the route is not recalculated. The upside is that it lets endpoints not know about the route and its update state.
2024-08-10 05:53:59 +03:00
Anton Khorev
0e3f0fbfd4 Set search input value to 'lat, lon' params if query param is missing 2024-07-17 16:43:52 +03:00
Tom Hughes
26f6fdf82c Merge remote-tracking branch 'upstream/pull/4929' 2024-07-14 15:56:20 +01:00
Anton Khorev
0d2010cd2f Remove "whereami" search parameter, use "lat" and "lon" instead 2024-07-06 16:56:49 +03:00
Anton Khorev
51d2a846ec Rename map layer javascript files 2024-06-28 03:12:15 +03:00
Anton Khorev
b5070d97a9 Introduce geocode event callback for route endpoints
Removes remaining getRoute() call from endpoint objects.
2024-06-15 22:26:23 +03:00
Anton Khorev
d3ab0c9a8a Introduce drag event callback for route endpoints
Avoids calling getRoute() from within endpoint objects.
2024-06-15 21:51:48 +03:00
Tom Hughes
84aa7f455a Merge remote-tracking branch 'upstream/pull/4897' 2024-06-14 18:02:50 +01:00
Anton Khorev
6c3c4f2751 Use .is-invalid to highlight routing inputs with failed geocode lookups 2024-06-14 19:42:45 +03:00
Anton Khorev
5944feb008 Remove global "awaiting geocode" routing state 2024-06-14 19:14:49 +03:00
Anton Khorev
dc134f3897 Show u-turn icons for GraphHopper u-turn instructions 2024-06-12 17:34:41 +03:00
Anton Khorev
2cd1b2e64a Show fork icons for GraphHopper keep right/left instructions 2024-06-12 17:31:02 +03:00
Anton Khorev
16d355f2b7 Redraw routing sprites 2024-06-08 19:44:24 +03:00
Anton Khorev
12281b1cc1 Fix setting "From" in directions form based on search query 2024-06-04 15:49:56 +03:00