cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
13380 commits 4 branches 1 tag 499 MiB
Commit graph

93 commits

Author SHA1 Message Date
Andy Allan
0195dd60a4 Simplify date display by using friendly_date helpers 2023-11-15 19:46:10 +00:00
Andy Allan
d58cae6ff6 Avoid using the zero key for pluralisation in English 
This makes it impossible to translate to other languages that use the
`zero:` key, e.g. for other numbers that end in zero.

An alternative approach would be possible in future, when ruby-i18n
and rails and translatewiki all have full support for `0:` and `1:` keys.

Fixes #3997
 2023-07-05 14:47:39 +01:00
Andy Allan
dff0c82f17 Avoid using raw html in translations for the issues index 2023-03-29 18:52:45 +01:00
Andy Allan
934d81aa55 Bootstrap 5: Replace all form-group classes with mb-3 2022-07-20 14:42:57 +01:00
Andy Allan
02a6ec60ec Bootstrap 5: Update manual select boxes to use form-select class 2022-07-20 14:41:55 +01:00
Andy Allan
2080696fe6 Bootstrap 5: Remove use of form-row class 
This has been replaced by simple `row` class in v5. We can also use the
gx-N classes here, which tighten up the horizontal gutter sizes for
space-constrained forms.
 2022-07-20 14:41:41 +01:00
Anton Khorev
95fa01c8f8 Margins for 'comment from' / 'reported by' lines on issues page 2022-06-10 17:22:15 +03:00
Anton Khorev
7d47845264 Wrap issue comment rich text in div 2022-06-09 19:20:36 +01:00
Anton Khorev
9936b00d82 Wrap issue report rich text in div 2022-06-09 19:20:02 +01:00
Andy Allan
68d6b7279e Use a secondary-actions nav for issue actions 
This fits with actions on other pages, avoids using pipe characters,
and resolves an issue with empty paragraphs.
 2022-05-11 16:09:46 +01:00
Harry Wood
3ca8b63643 Put issue comments through kramdown formatter 
On issue comments (which only admins can create or see), put the `body` text through kramdown formatting.
 2022-05-06 13:36:59 +01:00
Harry Wood
9401e451d1 Format report text with kramdown 
Pass the text of reports ('details' field) through the RichText formatter to give us kramdown formatting support.
 2022-04-29 01:31:39 +01:00
Andy Allan
75749cc540 Convert remaining heading titles to use h1 
This makes them consistent with all the other pages that use h1
in the `content_for :heading` sections
 2021-11-11 15:12:23 +00:00
Andy Allan
9c9bf153cd Simplify user_image and user_thumbnail css 
Now that all uses of the images and thumbnails have been migrated
to flex grids, we can remove the margin and padding from the original
css classes and revert to using them.
 2021-11-10 15:30:42 +00:00
Andy Allan
aa77ff5aec Use flex grid for issue reports and comments 2021-11-10 15:06:54 +00:00
Tom Hughes
e842c7be97 Add missing autocomplete attributes 2021-07-27 19:36:47 +01:00
Tom Hughes
2c5e981684 Fix erblint warnings 2021-06-05 07:40:55 +01:00
Andy Allan
e4277a4b09 Convert issue comments to use bootstrap 
The reassign checkbox could be simplified in future by changing the expected parameter in the controller
 2021-01-27 17:50:07 +00:00
Andy Allan
c8e1b3c662 Prefer string interpolation to concatenation in erb files 2020-11-11 14:44:42 +00:00
Andy Allan
a2c1fe7930 Avoid showing table header when there are no results 2020-08-19 16:58:43 +02:00
Andy Allan
56ed381a7d Rework issue search form to use Bootstrap form layout 2020-08-19 16:58:43 +02:00
Tom Hughes
c24c2e481c Merge remote-tracking branch 'upstream/pull/2667' 2020-08-05 21:50:08 +01:00
Andy Allan
d89a30421c Use bootstrap backgrounds and text utilities for read issue reports 2020-07-15 12:12:35 +02:00
Andy Allan
1977e66ace Use bootstrap text-muted in place of custom deemphasze class 
This avoids changing anything related to forms, since they will be
switched over to bootstrap separately.
 2020-07-08 18:30:15 +02:00
Andy Allan
627f2493fa Refactor away from global form control styling 
This enables forms to be converted one-by-one to bootstrap. Without this
refactoring, these global styles interfere with form control styling from
bootstrap.

The rearrangement of the search and directions styling is to solve CSS selector specitivity issues.
 2020-07-01 17:23:02 +02:00
Andy Allan
055a976051 Remove custom table styling 
This removes the custom table styling code, and move to using bootstrap table styling for almost all remaining tables.
 2020-04-01 12:29:01 +02:00
Andy Allan
65c3c2a915 Remove list style reset, and add overrides where necessary 
This allows the bootstrap list typography to work without being overridden. It also means
that lists look like normal lists by default, instead of needing to be recreated from
scratch each time. Only the cases where padding and discs are unwanted need to have
custom CSS.
 2020-01-15 17:16:11 +01:00
Andy Allan
cd801b2c12 Rework issues display page to be responsive 
This change uses the bootstrap grid to make the issues page responsive,
and avoids having lots of custom widths of divs specified via CSS.

It also changes the display of the reports and comments to be more
like diary entry comments, by having all metadata on one line and shown
before the comment / report text.
 2020-01-15 12:20:27 +01:00
Andy Allan
50d469a74a Use distance_in_words_ago scope for issues display 
Refs #2255
 2019-06-19 18:04:08 +02:00
Andy Allan
085412f624 Use i18n for submit button for issue comments 
Normally when an en-GB.yml translation is missing, rails falls back to en.yml. But when
using the submit helpers, if the en-GB translation is missing, rails knows how to create
a fallback like 'Create {model_name}' without touching the en.yml file. This string might
then be different from what the test expects, e.g. 'Add Comment'.

So it's important to set the language headers, to avoid phantomjs from picking up your desktop
preferences in this specific case.
 2019-06-12 19:24:06 +02:00
Tom Hughes
7ce40eeb38 erblint: use consistent spacing in HTML tags 2019-03-28 00:30:48 +00:00
Tom Hughes
3af16f6337 erblint: fix remaining single quoted strings 2019-03-27 16:15:19 +00:00
Andy Allan
040c0184a4 erblint: use hash rocket syntax 2019-03-27 10:03:56 +01:00
Andy Allan
84bdc5d048 Whitespace fixes for issues erb files 2019-03-26 20:23:35 +00:00
Andy Allan
4dd4831c0a Just pass the user object, rather than the display_name, to the user_path helper 2018-09-10 10:54:29 +08:00
Tom Hughes
2aca6920dc Use lazy lookups for translations in issues 2018-06-10 16:59:58 +01:00
Tom Hughes
e8942437c0 Use select_tag for issue filter fields instead of abusing select 2018-06-10 15:32:27 +01:00
Andy Allan
c71fd544e0 Avoid sending a commit value from from the search button 2018-03-28 11:05:46 +08:00
Andy Allan
918a382cad Use options_for_select to set the selected items in the search form 2018-03-28 11:05:46 +08:00
Andy Allan
c1bb412033 Fix class name 2018-03-14 15:18:47 +08:00
Andy Allan
870a497f94 Remove unnecessary div 2018-03-14 15:16:51 +08:00
Andy Allan
04901868fa Apply list styling to list of related reports 2018-03-14 15:14:35 +08:00
Andy Allan
e41751fb32 Use th instead of td and b 2018-03-14 14:56:06 +08:00
Andy Allan
9e46754c88 User user_path to generate links to users 2018-03-14 14:21:43 +08:00
Andy Allan
05b871db99 Avoid wrapping in the reports count column 2018-03-14 13:06:32 +08:00
Andy Allan
aaaeb211de Combine last_updated_by and last_updated_at columns on issues index 
Also change to use time as a distance, and link to the user.
 2018-03-14 12:51:22 +08:00
Andy Allan
e44f856b53 Combine category and reporting user 2018-03-14 12:51:22 +08:00
Andy Allan
05ae0755a4 Rearrange issues table and combine some columns. 2018-02-28 14:56:47 +08:00
Andy Allan
80a241f798 Allow reporting of anonymous notes 2018-02-28 14:26:40 +08:00
Andy Allan
3bd06529c7 Refactor reportable_url to just return the url 
Allows removal of the largely duplicate instance_url helper (which
returned the same urls, but with a hard-coded title).
 2018-02-28 13:30:17 +08:00