Commit graph

216 commits

Author SHA1 Message Date
Andy Allan
f0bacf837d Update more relation_controller tests to use factories. 2017-05-17 11:59:22 +01:00
Andy Allan
63a2f1f1b4 Refactor some relation_controller tests to use factories. 2017-05-17 11:29:11 +01:00
Andy Allan
c7d612df2d Refactor the relation_for_nwr tests to use factories
This is a bit verbose, since the original tests assumed various other
entities were silently not selected. This also improves the tests
since it considers the case of how to handle a relation with the
target member appearing more than once.
2017-05-17 11:11:04 +01:00
Andy Allan
c6d1bd63da More amf_controller tests converted to use factories. 2017-05-10 18:17:30 +01:00
Andy Allan
13fa0e0435 Refactor more amf_controller tests to use factories. 2017-05-10 18:17:30 +01:00
Andy Allan
f6323031cc Refactor putway method tests to use factories
This involved decoding a lot of magic numbers, to figure out which
were node_ids and which were other things (versions, coordinates etc)
2017-05-10 18:17:30 +01:00
Andy Allan
881015036c Refactor some more amf_controller tests to use factories.
The timestamp truncation thing was a pain to figure out.
2017-05-10 18:17:30 +01:00
Andy Allan
3f3ffdfea1 Refactor old_relation_controller tests to use factories. 2017-05-10 14:11:53 +01:00
Andy Allan
3fa3658efa Update old_ways_controller tests to use factories. 2017-05-10 13:38:10 +01:00
Andy Allan
bdf817103a Convert remaining old_node_controller tests to use factories. 2017-05-10 11:51:43 +01:00
Andy Allan
b2a998cf08 Refactor remaining api_controller tests to use factories. 2017-05-10 11:51:43 +01:00
Tom Hughes
3a16b68368 Use POST when editing GPX trace details
Fixes #1533
2017-05-01 16:56:02 +01:00
Andy Allan
de1bc30b83 Refactor remaining way_controller tests to use factories. 2017-04-26 09:10:45 +02:00
Andy Allan
2122ec263b Refactor more way_controller tests to use factories. 2017-04-26 08:50:39 +02:00
Andy Allan
d48603d9e0 Add a way_with_nodes factory, and use it in the way_controller tests. 2017-04-26 08:34:01 +02:00
Andy Allan
8da385e0db Refactor deletion tests in way_controller_test to use factories. 2017-04-26 08:33:29 +02:00
Andy Allan
99817bd62a Refactor some way_controller tests to use factories. 2017-04-25 18:42:59 +02:00
Andy Allan
75c5d6619a Refactor some amf_controller tests to use factories. 2017-04-25 17:47:58 +02:00
Andy Allan
e0f7bb1b07 Convert the node_controller update tests to use factories. 2017-04-24 20:42:08 +02:00
Andy Allan
d595577a49 Convert the duplicate_tags node controller test to use factories. 2017-04-24 20:41:43 +02:00
Andy Allan
df721bc653 Convert more node fixtures to factories 2017-03-31 10:51:18 +01:00
Tom Hughes
66d74a8c2c Merge remote-tracking branch 'openstreetmap/pull/1507' 2017-03-30 15:18:14 +01:00
Andy Allan
6afd13602c Fix tests that referred to node lat and lons 2017-03-30 15:13:22 +01:00
Andy Allan
06814eb715 Use node factories for browse_controller tests. 2017-03-30 13:57:30 +01:00
Andy Allan
24cd3af31e Use changeset factory for factory associations
One test needed updating since it assumed the comments were being
created on a particular changeset.
2017-03-22 11:09:52 +00:00
Tom Hughes
834a821d3c Merge remote-tracking branch 'openstreetmap/pull/1492' 2017-03-16 19:02:35 +00:00
Andy Allan
6331e34638 Remove the link between the redaction owner and the user doing the redaction in tests. 2017-03-16 10:21:25 +00:00
Andy Allan
d2998065dc Use redactions factory for old_way controller tests 2017-03-15 18:04:58 +00:00
Andy Allan
2cdc2e1cd8 Use redactions factory for old_node controller tests. 2017-03-15 17:50:57 +00:00
Tom Hughes
671467a6dd Merge remote-tracking branch 'openstreetmap/pull/1491' 2017-03-15 17:37:13 +00:00
Andy Allan
99d2bbccbb Use redaction factory for old_relation controller tests. 2017-03-15 17:13:47 +00:00
Andy Allan
5422c56301 Fix typos in assertion messages. 2017-03-15 17:06:29 +00:00
Andy Allan
a0899d1b0b Use redactions factory in redaction controller test. 2017-03-15 17:01:41 +00:00
Andy Allan
1096bccf98 Use user factories for some changeset_controller tests.
Others are tightly interwoven with the fixtures and will be tackled seperately.
2017-03-15 15:41:42 +00:00
Tom Hughes
8ccd7364cd Merge remote-tracking branch 'openstreetmap/pull/1488' 2017-03-15 14:22:59 +00:00
Andy Allan
8d2d6e1a52 Use a pending user for testing password resets. 2017-03-15 14:22:04 +00:00
Andy Allan
3d8dc64b9c Use users factory for user_controller tests. 2017-03-15 11:56:36 +00:00
Tom Hughes
7c9229fbfc Throw an exception if adding a note comment fails 2017-03-13 14:49:16 +00:00
Andy Allan
17ff182c96 Build pending users via factory 2017-03-13 10:20:06 +00:00
Simon Poole
9606e440bc Return maximum size of bounding box for note retrieval 2017-03-13 08:53:49 +01:00
Tom Hughes
685df702ef Merge remote-tracking branch 'openstreetmap/pull/1483' 2017-03-09 18:35:57 +00:00
Tom Hughes
da57077c0b Improve trace#api_data tests
The api_data action doesn't actually take the username as an
arguement and should be modelled on api_read rather than the
actions that handle web views.
2017-03-09 18:28:46 +00:00
Andy Allan
56e979c353 Remove redundant tests for deleted traces, and rearrange comments and factory calls for consistency. 2017-03-09 17:21:46 +00:00
Andy Allan
eac26c9a2c Create a super_user factory. 2017-03-09 16:21:51 +00:00
Andy Allan
18c25b620b Create a fresh user when requesting non-existent traces. 2017-03-09 14:50:02 +00:00
Andy Allan
2b06961ce3 Use user factory for trace_controller tests 2017-03-09 10:13:18 +00:00
Tom Hughes
d86380e7b5 Fix accidental change in comments 2017-03-06 18:01:26 +00:00
Andy Allan
d007956865 Use user factory for swf_controller tests. 2017-03-06 17:28:06 +00:00
Andy Allan
1d9e12b330 Use user factory for message_controller tests. 2017-03-06 17:25:55 +00:00
Andy Allan
f1397f4700 Use user factory for user_roles_controller tests. 2017-03-06 16:55:05 +00:00