Commit graph

989 commits

Author SHA1 Message Date
Andy Allan
2e8c0d471f Ensure invisible_way is actually deleted 2017-05-17 16:05:23 +01:00
Andy Allan
f0bacf837d Update more relation_controller tests to use factories. 2017-05-17 11:59:22 +01:00
Andy Allan
63a2f1f1b4 Refactor some relation_controller tests to use factories. 2017-05-17 11:29:11 +01:00
Andy Allan
c7d612df2d Refactor the relation_for_nwr tests to use factories
This is a bit verbose, since the original tests assumed various other
entities were silently not selected. This also improves the tests
since it considers the case of how to handle a relation with the
target member appearing more than once.
2017-05-17 11:11:04 +01:00
Andy Allan
084ae0f191 Refactor get_nodes_undelete test to use factories instead of fixtures. 2017-05-17 10:30:28 +01:00
Andy Allan
e69e8c9018 Refactor remaining way model tests to use factories.
Note that test_max_nodes_per_way_limit still has issues - see #1516
2017-05-17 09:56:44 +01:00
Andy Allan
c6d1bd63da More amf_controller tests converted to use factories. 2017-05-10 18:17:30 +01:00
Andy Allan
13fa0e0435 Refactor more amf_controller tests to use factories. 2017-05-10 18:17:30 +01:00
Andy Allan
f6323031cc Refactor putway method tests to use factories
This involved decoding a lot of magic numbers, to figure out which
were node_ids and which were other things (versions, coordinates etc)
2017-05-10 18:17:30 +01:00
Andy Allan
881015036c Refactor some more amf_controller tests to use factories.
The timestamp truncation thing was a pain to figure out.
2017-05-10 18:17:30 +01:00
Andy Allan
3f3ffdfea1 Refactor old_relation_controller tests to use factories. 2017-05-10 14:11:53 +01:00
Andy Allan
3fa3658efa Update old_ways_controller tests to use factories. 2017-05-10 13:38:10 +01:00
Andy Allan
bdf817103a Convert remaining old_node_controller tests to use factories. 2017-05-10 11:51:43 +01:00
Andy Allan
1df5bd247f Ensure the old nodes are created with the same changeset
Not often important, but the most recent old_node should definitely
have the same changeset as the node itself.
2017-05-10 11:51:43 +01:00
Andy Allan
b2a998cf08 Refactor remaining api_controller tests to use factories. 2017-05-10 11:51:43 +01:00
Tom Hughes
3a16b68368 Use POST when editing GPX trace details
Fixes #1533
2017-05-01 16:56:02 +01:00
Andy Allan
de1bc30b83 Refactor remaining way_controller tests to use factories. 2017-04-26 09:10:45 +02:00
Andy Allan
2122ec263b Refactor more way_controller tests to use factories. 2017-04-26 08:50:39 +02:00
Andy Allan
d48603d9e0 Add a way_with_nodes factory, and use it in the way_controller tests. 2017-04-26 08:34:01 +02:00
Andy Allan
8da385e0db Refactor deletion tests in way_controller_test to use factories. 2017-04-26 08:33:29 +02:00
Andy Allan
99817bd62a Refactor some way_controller tests to use factories. 2017-04-25 18:42:59 +02:00
Andy Allan
75c5d6619a Refactor some amf_controller tests to use factories. 2017-04-25 17:47:58 +02:00
Andy Allan
7f957bac76 Use factories for all factory associations. 2017-04-25 16:52:29 +02:00
Andy Allan
805abe96d0 Create an old_way_node factory, and start using it for tests. 2017-04-25 16:29:13 +02:00
Andy Allan
05a42281ab Create an old_way factory, and start using it for tests. 2017-04-25 16:29:13 +02:00
Andy Allan
b46028b4f7 Create an old_relation_member factory, and start using it for tests. 2017-04-25 16:29:13 +02:00
Andy Allan
27c3edae25 Create an old_relation factory, and start using it for tests. 2017-04-25 15:19:25 +02:00
Andy Allan
e0f7bb1b07 Convert the node_controller update tests to use factories. 2017-04-24 20:42:08 +02:00
Andy Allan
d595577a49 Convert the duplicate_tags node controller test to use factories. 2017-04-24 20:41:43 +02:00
Andy Allan
b375050e6c Use node and relation_member factories for testing containing_relations and containing_relation_members 2017-04-05 11:33:33 +01:00
Andy Allan
df721bc653 Convert more node fixtures to factories 2017-03-31 10:51:18 +01:00
Andy Allan
5ab082a047 Add the closed trait to changeset factories. 2017-03-31 10:47:41 +01:00
Andy Allan
1b7ab315bb Add factories for relations, relation_members, ways and way_nodes 2017-03-31 10:40:49 +01:00
Tom Hughes
66d74a8c2c Merge remote-tracking branch 'openstreetmap/pull/1507' 2017-03-30 15:18:14 +01:00
Andy Allan
6afd13602c Fix tests that referred to node lat and lons 2017-03-30 15:13:22 +01:00
Andy Allan
4fb775d6d5 Format latitudes and longitudes as %7f in XML output
This matches the double formatting in XML from cgimap. Fixes #341.
2017-03-30 14:30:54 +01:00
Andy Allan
06814eb715 Use node factories for browse_controller tests. 2017-03-30 13:57:30 +01:00
Andy Allan
66ae9a48a6 For deleted nodes created via factories, make sure the most recent old_node is also deleted 2017-03-30 13:57:07 +01:00
Andy Allan
17e9bcd2d4 Use factories for nodes in browse_helper tests. 2017-03-30 13:19:24 +01:00
Andy Allan
5a0ba2e812 Add a with_history trait for node factories, to automatically create corresponding old_nodes 2017-03-30 09:31:22 +01:00
Tom Hughes
8a565061e3 Add explicit tests for lat/lon methods on node models 2017-03-22 20:43:39 +00:00
Tom Hughes
9ae3df1a78 Use changeset factory for association in node factory 2017-03-22 20:31:25 +00:00
Tom Hughes
b78bb9f631 Merge remote-tracking branch 'openstreetmap/pull/1496' 2017-03-22 19:19:59 +00:00
Andy Allan
4ed1607784 Use node and old_node factories for redaction model tests. 2017-03-22 18:19:16 +00:00
Andy Allan
1a3130ec61 Create a node factory, and use it for most node model tests 2017-03-22 17:50:10 +00:00
Andy Allan
2d3ca85751 Use old_node factory for OldNode model tests.
The valid/invalid tests were simplified, since there is little to be
gained from inserting (invalid) nodes into the database and comparing
the node with another copy of itself.
2017-03-22 17:10:48 +00:00
Andy Allan
88ca1f9ed8 Rework the changeset helper tests to use factories. 2017-03-22 11:42:29 +00:00
Andy Allan
24cd3af31e Use changeset factory for factory associations
One test needed updating since it assumed the comments were being
created on a particular changeset.
2017-03-22 11:09:52 +00:00
Andy Allan
56752ac02a Create a changeset factory, and use it for model tests. 2017-03-22 10:47:24 +00:00
Andy Allan
48be941840 Remove the api_fixtures call from changeset model tests, since they do not need the fixtures. 2017-03-22 10:40:13 +00:00