Andy Allan
415ac577f3
Remove some old debugging comments
2022-12-21 12:05:15 +00:00
mmd-osm
ec121dde4f
Add more testcases to changesets_controller
...
Extracted from pull request #1995
2022-11-30 22:32:20 +01:00
Tom Hughes
49cde0e901
Fix new rubocop warnings
2022-11-01 18:42:24 +00:00
Tom Hughes
3d0b94abda
Merge remote-tracking branch 'upstream/pull/3768'
2022-10-25 19:28:10 +01:00
Tom Hughes
460ed0c844
Fix new rubocop warnings
2022-10-25 19:19:57 +01:00
Anton Khorev
225b260640
Pass min/max lat/lon to notes index rss builder
2022-10-25 13:52:28 +03:00
Anton Khorev
0c8b9eabf3
Pass min/max lat/lon to notes rss feed builder
2022-10-25 13:35:18 +03:00
Tom Hughes
140b296f59
Test that tags are included correctly in the changeset feed
2022-10-18 18:42:02 +01:00
Robbendebiene
b5e695b6f3
Remove default xml format from notes routing test
2022-09-26 09:13:40 +02:00
Anton Khorev
01d48694b4
Don't show 'Download XML' link for deleted elements
2022-09-22 14:51:31 +03:00
Tom Hughes
e9887f88ed
Test fetching the iD frame when not logged in
2022-07-26 17:38:56 +01:00
Anton Khorev
d353186b19
Uncomment asserts for namespaced elements in note rss test
2022-07-22 18:02:00 +03:00
Andy Allan
934d81aa55
Bootstrap 5: Replace all form-group classes with mb-3
2022-07-20 14:42:57 +01:00
Andy Allan
2080696fe6
Bootstrap 5: Remove use of form-row class
...
This has been replaced by simple `row` class in v5. We can also use the
gx-N classes here, which tighten up the horizontal gutter sizes for
space-constrained forms.
2022-07-20 14:41:41 +01:00
Tom Hughes
9adad9f90d
Fix new rubocop warnings
2022-06-14 19:04:39 +01:00
Martin Raifer
c55d346d5f
Update to iD v2.21.0
...
major changes in this release:
* dropped support for Internet Explorer 11
* switched authentication to OAuth 2
for further changes please refer to https://github.com/openstreetmap/iD/blob/release/CHANGELOG.md#2210
2022-06-03 15:32:27 +02:00
Harry Wood
fcbccb6a44
Report verification render not redirect
...
Fix an issue with the report verification, causing it to lose the text of a report if the user fails to fill in a category.
By using a `render` instead of a `redirect_to`, the rails standard verification behaviour works better. It means we also get a nice red "can't be blank" message highlighting the specific missing field.
2022-05-04 19:42:36 +01:00
Tom Hughes
9c0582f88f
Merge remote-tracking branch 'upstream/pull/3523'
2022-04-12 17:12:16 +01:00
Andy Allan
387668a4c6
Merge pull request #3495 from mmd-osm/patch/json_cs
...
JSON output added to changeset(s) endpoints
2022-04-06 18:04:17 +01:00
Andy Allan
561ee71129
Rubocop autofix: ambiguous operator precedence
...
This simply adds braces to clarify which mathematical operator comes
first.
2022-04-06 14:55:29 +01:00
Tom Hughes
03cad948e3
Fix new rubocop warnings
2022-03-15 19:24:09 +00:00
mmd-osm
4ec85171fd
JSON output added to changeset(s) endpoints
2022-03-14 15:52:49 +01:00
Andy Allan
d6f8302eae
Merge pull request #3491 from tomhughes/legacy-trace
...
Remove support for legacy trace files
2022-03-09 17:10:40 +00:00
Andy Allan
13aead5601
Merge pull request #3492 from harry-wood/oauth-doc
...
OAuth updates to CONFIGURE doc + cosmetic tweak
2022-03-09 17:04:37 +00:00
Tom Hughes
44ac569d28
Merge remote-tracking branch 'upstream/pull/3493'
2022-03-08 20:30:19 +00:00
mmd-osm
c9e836a6cb
JSON output added to permissions endpoint
2022-03-08 20:21:35 +01:00
Tom Hughes
5d67fa3908
Fix some Naming/AccessorMethodName rubocop warnings
2022-03-08 19:10:05 +00:00
Harry Wood
02338a80e1
Make oauth register app link into button
...
Cosmetic tweak. On the OAuth 1 setting tab, make "Register your app" into a button not a link
Also put the applications in a <ul>
2022-03-08 15:18:53 +00:00
Harry Wood
2ce44a2a85
Fix minor HTML tag mismatches
...
Fix some HTML tag mismatches and other glitches. These are minor, and don't appear to cause browsers any problems, but for the sake of correctness:
* A closing td which should be a closing div.
* A closing h3 for a corresponding h6
* Two tables with `<thead>` tag and missing `<tr>` around the `<th>` headings.
test change for thead fix
2022-03-05 02:44:59 +00:00
Tom Hughes
cbcc7dc49f
Fix some rubocop Naming/PredicateName warnings
2022-03-03 22:47:55 +00:00
Tom Hughes
92b122759f
Remove support for legacy trace files
2022-03-03 19:47:40 +00:00
Tom Hughes
b5f06e06c1
Fix rubocop Rails/TimeZone warnings
2022-03-01 22:55:10 +00:00
Andy Allan
2fabc46421
Merge pull request #3440 from mmd-osm/relationmemberlimit
...
Introduce relation member limit
2022-02-16 14:58:30 +00:00
Tom Hughes
53aa7259bb
Merge remote-tracking branch 'upstream/pull/3345'
2022-02-13 18:39:21 +00:00
Tom Hughes
446837c351
Merge remote-tracking branch 'upstream/pull/3419'
2022-02-03 18:37:12 +00:00
mmd-osm
2efd73c672
Introduce relation member limit
...
Adds a new parameter `max_number_of_relation_members` in settings.yml
2022-02-02 13:15:40 +01:00
Tom Hughes
81c58571c5
Fix route for "go public" button on the account edit page
2022-01-28 12:39:39 +00:00
Andy Allan
1a11c4dc19
Use a state machine for user status
...
The user status is a bit complex, since there are various states and
not all transitions between them make sense.
Using AASM means that we can name and restrict the transitions, which
hopefully makes them easier to reason about.
2022-01-12 18:16:14 +00:00
Andy Allan
4436099e31
Remove params from user deletion test
...
They have no effect, and are likely a copy-paste error from when
the test was first written in 39a54f8c14
2022-01-12 16:45:58 +00:00
Tom Hughes
6403515897
Replace to_s on TimeWithZone objects with to_formatted_s
2022-01-10 18:59:22 +00:00
Tom Hughes
4549de5f32
Test redirect from settings page to OmniAuth
2021-12-29 18:29:38 +00:00
Andy Allan
a863be8831
Rename User#delete to User#destroy
...
"delete" is generally used for immediate SQL deletion without running
any callbacks or other ruby code, whereas "destroy" will trigger callbacks.
Although we don't currently use any callbacks, let's rename this method to
align better with the convention.
2021-12-22 11:32:33 +00:00
Tom Hughes
0410596908
Switch traces to use ActiveStorage
2021-12-16 18:45:31 +00:00
Andy Allan
a8e8ba1a64
Refactor the account edit/update pages out into a separate accounts controller
2021-12-08 15:17:50 +00:00
Andy Allan
cb68450ac7
Simplify margins when showing diary entries
2021-11-24 12:24:16 +00:00
Tom Hughes
abbd5a30d4
Validate any origin passed the auth failure callback
...
Fixes #3375
2021-11-23 17:33:19 +00:00
Tom Hughes
e21b9b2bf1
Merge remote-tracking branch 'upstream/pull/3365'
2021-11-11 15:33:08 +00:00
Andy Allan
75749cc540
Convert remaining heading titles to use h1
...
This makes them consistent with all the other pages that use h1
in the `content_for :heading` sections
2021-11-11 15:12:23 +00:00
Andy Allan
3719e8defb
Remove the userinformation ids from headings
...
The style rule was removed in 3f8cf32272
and they were otherwise only used in the tests.
2021-11-11 14:53:36 +00:00
Andy Allan
826a864e6c
Remove the contact-activity class
...
The margin-top is better replaced with a bottom margin on the
preceding element, and the width is unnecessary in the grid layout.
2021-11-03 18:35:42 +00:00