Tom Hughes
03cad948e3
Fix new rubocop warnings
2022-03-15 19:24:09 +00:00
Andy Allan
d6f8302eae
Merge pull request #3491 from tomhughes/legacy-trace
...
Remove support for legacy trace files
2022-03-09 17:10:40 +00:00
Andy Allan
13aead5601
Merge pull request #3492 from harry-wood/oauth-doc
...
OAuth updates to CONFIGURE doc + cosmetic tweak
2022-03-09 17:04:37 +00:00
Tom Hughes
44ac569d28
Merge remote-tracking branch 'upstream/pull/3493'
2022-03-08 20:30:19 +00:00
mmd-osm
c9e836a6cb
JSON output added to permissions endpoint
2022-03-08 20:21:35 +01:00
Tom Hughes
5d67fa3908
Fix some Naming/AccessorMethodName rubocop warnings
2022-03-08 19:10:05 +00:00
Harry Wood
02338a80e1
Make oauth register app link into button
...
Cosmetic tweak. On the OAuth 1 setting tab, make "Register your app" into a button not a link
Also put the applications in a <ul>
2022-03-08 15:18:53 +00:00
Harry Wood
2ce44a2a85
Fix minor HTML tag mismatches
...
Fix some HTML tag mismatches and other glitches. These are minor, and don't appear to cause browsers any problems, but for the sake of correctness:
* A closing td which should be a closing div.
* A closing h3 for a corresponding h6
* Two tables with `<thead>` tag and missing `<tr>` around the `<th>` headings.
test change for thead fix
2022-03-05 02:44:59 +00:00
Tom Hughes
cbcc7dc49f
Fix some rubocop Naming/PredicateName warnings
2022-03-03 22:47:55 +00:00
Tom Hughes
92b122759f
Remove support for legacy trace files
2022-03-03 19:47:40 +00:00
Tom Hughes
b5f06e06c1
Fix rubocop Rails/TimeZone warnings
2022-03-01 22:55:10 +00:00
Andy Allan
2fabc46421
Merge pull request #3440 from mmd-osm/relationmemberlimit
...
Introduce relation member limit
2022-02-16 14:58:30 +00:00
Tom Hughes
53aa7259bb
Merge remote-tracking branch 'upstream/pull/3345'
2022-02-13 18:39:21 +00:00
Tom Hughes
446837c351
Merge remote-tracking branch 'upstream/pull/3419'
2022-02-03 18:37:12 +00:00
mmd-osm
2efd73c672
Introduce relation member limit
...
Adds a new parameter `max_number_of_relation_members` in settings.yml
2022-02-02 13:15:40 +01:00
Tom Hughes
81c58571c5
Fix route for "go public" button on the account edit page
2022-01-28 12:39:39 +00:00
Andy Allan
1a11c4dc19
Use a state machine for user status
...
The user status is a bit complex, since there are various states and
not all transitions between them make sense.
Using AASM means that we can name and restrict the transitions, which
hopefully makes them easier to reason about.
2022-01-12 18:16:14 +00:00
Andy Allan
4436099e31
Remove params from user deletion test
...
They have no effect, and are likely a copy-paste error from when
the test was first written in 39a54f8c14
2022-01-12 16:45:58 +00:00
Tom Hughes
6403515897
Replace to_s on TimeWithZone objects with to_formatted_s
2022-01-10 18:59:22 +00:00
Tom Hughes
4549de5f32
Test redirect from settings page to OmniAuth
2021-12-29 18:29:38 +00:00
Andy Allan
a863be8831
Rename User#delete to User#destroy
...
"delete" is generally used for immediate SQL deletion without running
any callbacks or other ruby code, whereas "destroy" will trigger callbacks.
Although we don't currently use any callbacks, let's rename this method to
align better with the convention.
2021-12-22 11:32:33 +00:00
Tom Hughes
0410596908
Switch traces to use ActiveStorage
2021-12-16 18:45:31 +00:00
Andy Allan
a8e8ba1a64
Refactor the account edit/update pages out into a separate accounts controller
2021-12-08 15:17:50 +00:00
Andy Allan
cb68450ac7
Simplify margins when showing diary entries
2021-11-24 12:24:16 +00:00
Tom Hughes
abbd5a30d4
Validate any origin passed the auth failure callback
...
Fixes #3375
2021-11-23 17:33:19 +00:00
Tom Hughes
e21b9b2bf1
Merge remote-tracking branch 'upstream/pull/3365'
2021-11-11 15:33:08 +00:00
Andy Allan
75749cc540
Convert remaining heading titles to use h1
...
This makes them consistent with all the other pages that use h1
in the `content_for :heading` sections
2021-11-11 15:12:23 +00:00
Andy Allan
3719e8defb
Remove the userinformation ids from headings
...
The style rule was removed in 3f8cf32272
and they were otherwise only used in the tests.
2021-11-11 14:53:36 +00:00
Andy Allan
826a864e6c
Remove the contact-activity class
...
The margin-top is better replaced with a bottom margin on the
preceding element, and the width is unnecessary in the grid layout.
2021-11-03 18:35:42 +00:00
Tom Hughes
5966acc207
Merge remote-tracking branch 'upstream/pull/3300'
2021-10-07 17:45:07 +01:00
Andy Allan
9ab15f38ea
Move the tracepoint coordinate format test to the controller test
...
This allows us to remove the model method
2021-09-29 15:25:28 +01:00
Tom Hughes
e91c02f2ce
Merge remote-tracking branch 'upstream/pull/3297'
2021-09-15 18:44:23 +01:00
Andy Allan
d07ce46929
Move the xml format test for old nodes to the controller test
...
This allows us to remove the model method
2021-09-15 17:05:34 +01:00
Andy Allan
76f1d7bc78
Use a builder to render changeset downloads
2021-09-15 16:33:04 +01:00
Andy Allan
fa7d64b788
Fix test
2021-09-15 14:36:08 +01:00
Tom Hughes
350ac303f1
Check that user email address are only returned with read_email
2021-08-26 17:22:25 +01:00
Tom Hughes
5723ba0624
Check that use of privileged scopes is restricted to administrators
2021-08-26 17:22:25 +01:00
Tom Hughes
6c6e8883f7
Introduce privileged scopes that only an administrator can enable
2021-08-26 17:22:24 +01:00
Tom Hughes
4389eff647
Improve testing of user details API responses
2021-08-24 18:41:07 +01:00
Andy Allan
cb7b79a58f
Split the non-public information off of the profile page
...
This opens up many possibilities for more interesting things to be
shown on the dashboard, as well as making it easier to find if
you have lots of content in your profile.
2021-08-18 13:32:36 +01:00
Andy Allan
36f6d8d85d
Fix redirect to terms path when not logged in
...
This was missed during #3147 since it wasn't covered by a test.
2021-07-28 16:36:13 +01:00
Tom Hughes
abd98757b6
Improve capitalisation of page titles
2021-07-22 19:00:08 +01:00
Tom Hughes
f1935b1c57
Merge remote-tracking branch 'upstream/pull/3257'
2021-07-21 19:24:31 +01:00
Josh Soref
8e951a8340
spelling: unknown
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-07-21 10:45:38 -04:00
Josh Soref
fc0aee74af
spelling: success
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-07-21 10:45:38 -04:00
Josh Soref
7ff3d82c03
spelling: shouldn't
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-07-21 10:45:38 -04:00
Josh Soref
eee739356f
spelling: modify
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-07-21 10:45:38 -04:00
Josh Soref
ff8e1b074a
spelling: forbidden
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-07-21 10:45:38 -04:00
Andy Allan
37b03e47c6
Fix various code comments
...
These were found as part of #3233
2021-07-21 11:24:23 +01:00
Andy Allan
caf2e2a242
Move profile-related settings to their own form
...
Refs #3167
2021-07-14 17:45:19 +01:00