Andy Allan
00bd64c7fb
Rename message_controller to messages_controller
2018-05-09 16:38:37 +08:00
Andy Allan
011cfa794a
Use named paths for messages
2018-05-09 11:24:11 +08:00
Andy Allan
9408ed6946
Pluralise user_preferences_controller
...
This is the rails convention for controllers and can make route
generation easier.
http://guides.rubyonrails.org/action_controller_overview.html#controller-naming-convention
2018-04-18 11:26:00 +08:00
biswesh456
674589ce2c
Change test case
2018-03-03 20:20:52 +05:30
biswesh456
646dcb62fc
Allow admins and moderators to delete traces
...
Fixes #1625
2018-02-24 20:36:12 +05:30
Andy Allan
549acfa918
Merge pull request #1732 from tomhughes/npemap
...
Remove npemap as a source for UK postcodes
2018-02-23 10:23:22 +08:00
mmd-osm
910a7fe9fc
Small comment fix
2018-02-14 17:23:30 +00:00
mmd-osm
cea403dce0
Remove BBOX expansion performance optimization
...
Closes #1749
Fixes #1742
2018-02-14 17:23:06 +00:00
Tom Hughes
96cc9abd23
Use https when redirecting to the render server
2018-02-09 22:31:45 +00:00
Tom Hughes
5925039729
Remove npemap as a source for UK postcodes
2018-02-04 15:14:41 +00:00
Tom Hughes
673b58f96f
Merge remote-tracking branch 'upstream/pull/1704'
2018-02-04 15:09:40 +00:00
Tom Hughes
a83030dab7
Fix new rubocop warnings
2018-01-22 18:55:45 +00:00
Tom Hughes
c658e84535
Fix tests that only worked if object 400 didn't exist
2017-12-19 17:43:53 +00:00
mmd-osm
e21c967fdd
Revoking administrator role on current user should fail
...
Fixes #1697
Closes #1701
2017-12-19 17:31:34 +00:00
mmd-osm
2c7f2b117b
Remove extra blank line
2017-12-16 14:06:21 +01:00
mmd-osm
7a396e9dc9
Fix for failing test cases
2017-12-16 13:51:02 +01:00
Tom Hughes
b77406ff38
Use decoded strings when parsing XML responses from geocoders
...
Fixes #1690
2017-11-29 23:07:19 +00:00
Tom Hughes
2ef803b9df
Update rack-test and patch test issues
2017-11-29 20:35:17 +00:00
Andy Allan
1b181d4c1d
Put specific page titles at the start
...
The makes the shortened titles commonly shown on browser tabs more
useful.
2017-11-22 14:57:26 +00:00
Tom Hughes
1c77d2432e
Avoid using rinku's auto_link helper
...
It's currently broken (https://github.com/vmg/rinku/issues/70 ) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Tom Hughes
f02c753cc4
Use send_data for GPX traces intead of monkey patching send_file
2017-10-09 20:38:08 +01:00
Tom Hughes
8dae890a76
Fix rubocop warnings
2017-10-05 19:18:38 +01:00
Tom Hughes
6209a9be78
Drop geocoder.us from search engines
...
Fixes #1633
2017-09-25 22:52:03 +01:00
Tom Hughes
f1faffd4d1
Merge remote-tracking branch 'upstream/pull/1614'
2017-08-30 21:09:32 +01:00
Andy Allan
c647aa3d4d
Refactor the from_xml methods to act on existing trace objects.
...
Setting the new tags with the = operator takes care of removing the
old ones, and is the same approach as taken by the tagstring= method.
Fixes #1600
2017-08-18 10:09:50 +01:00
Andy Allan
e9324ad681
Add failing test demonstrating tag duplication when updating traces via the API.
2017-08-17 19:03:50 +01:00
Tom Hughes
a70898be6d
Make sure we show errors correctly when resetting a password
2017-08-11 17:45:57 +01:00
Tom Hughes
85b0098b1c
Make sure the account form is POSTed
...
Fixes #1601
2017-08-02 15:32:13 +01:00
Tom Hughes
f258af223b
Fix user settings form
...
Fixes #1601
2017-08-01 19:25:07 +01:00
Andy Allan
6fe5d42100
Standardise on basic_authorization without the parentheses
2017-07-12 14:36:17 +01:00
Tom Hughes
28bfaa9fb6
Replace timecop with the rails builtin travel_to method
2017-07-10 21:19:22 +01:00
Andy Allan
cbf71f04c2
Hide contributor terms details, unless the user hasn't agreed
...
It's no longer important to show when users agreed to the contributor terms.
For users that haven't agreed, we still show their status on their profile.
Logic was also re-written to avoid lots of `if not` things, and tests added.
2017-07-05 12:39:52 +01:00
Tom Hughes
fe1e28b4f4
Fix more parameter sanitisation issues and add tests
2017-06-29 20:52:57 +01:00
Tom Hughes
3893fd72a9
Fix some tests for changes in rails 5
2017-06-27 08:26:44 +01:00
Tom Hughes
03408b6294
Update get/post etc to remove use of deprecated syntax
2017-06-27 08:26:44 +01:00
Andy Allan
396f2e28dd
Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509
2017-06-23 14:03:57 +01:00
Tom Hughes
2357118c46
Avoid using format as a URL parameter name
...
This prevents rails confusing it with the builtin format
parameter derived from the URL extension.
2017-06-03 12:08:35 +01:00
Tom Hughes
ff97501ed0
Remove all use of the :text option to render
...
It doesn't actually do what it says, as it sets the content type
to text/html not text/plain so is just confusing and as a result
has been deprecated in newer rails versions.
2017-06-02 19:12:05 +01:00
Tom Hughes
5b33f3f8e3
Fix rubocop warnings
2017-06-02 00:08:30 +01:00
Andy Allan
060230fb94
Ensure closed changesets appear in the feed, and update some misleading comments.
2017-06-01 15:43:51 +01:00
Andy Allan
86822ea225
Remove remaining references to fixtures.
2017-06-01 11:00:50 +01:00
Andy Allan
5d0ea28796
Remove the api_fixtures helper
...
This is no longer required, as the tests no longer use fixtures.
2017-06-01 10:59:48 +01:00
Andy Allan
162949817d
Rubocop fixes.
2017-06-01 10:58:34 +01:00
Andy Allan
3438c15c8f
create nodes from factories for the api changes test.
2017-06-01 10:52:05 +01:00
Andy Allan
00546639df
Update amf_controller tests to use a factory-generated user for credentials.
2017-05-31 18:51:08 +01:00
Andy Allan
5246ebefa9
Update the user list pagination test to avoid counting users from fixtures.
2017-05-31 18:43:28 +01:00
Andy Allan
cea6f9c4cf
Refactor the user list test to use factory-built users and explicit assertions.
2017-05-31 18:40:20 +01:00
Andy Allan
0a1834af63
Use factories to generate the relations
2017-05-31 18:21:24 +01:00
Andy Allan
4ee270df6f
Refactor the assert_changeset helper to take an array of changesets, instead of ids.
2017-05-31 18:08:20 +01:00
Andy Allan
241c724adb
Only use changesets from factories for the test_query changeset controller tests.
2017-05-31 18:02:56 +01:00
