Andy Allan
83425edd8d
Move api error handling and timeouts to parent class
...
Fixes #4861
Since the around_action is defined before authorize_resource is called,
the handler needs to pass on the CanCan::AccessDenied exception.
I've added the timeouts where I think they were missing (e.g. UserPreferencesController)
but I've kept the exception for changeset#upload and traces#create
2024-10-02 16:37:32 +01:00
Andy Allan
c1cccd40fc
Move check_api_readable to api_controller
...
It's easier to skip the check in the two places that we need to, and
include it by default everywhere else.
2024-05-29 14:54:16 +01:00
Andy Allan
91fc588556
Add api_status checks for user preferences API
2024-05-29 14:51:20 +01:00
Tom Hughes
64af2816a3
Treat the body as UTF-8 for user_preferences#update
2024-05-16 17:51:33 +01:00
Andy Allan
37b03e47c6
Fix various code comments
...
These were found as part of #3233
2021-07-21 11:24:23 +01:00
Andy Allan
6bb18436a3
Add tests for routing and to ensure output format
...
This avoids the tests passing if the json output is an array of kv pairs,
instead of the desired hash of attributes.
2021-04-14 16:11:57 +01:00
Michal Migurski
a67ff9c038
Added JSON support to user preferences
2021-04-06 21:27:54 -07:00
Tom Hughes
b5c778b662
Fix new rubocop warnings
2020-03-31 19:08:10 +01:00
Andy Allan
8ad88b9ddc
Move user preference XML generation to a view
2019-11-20 16:39:23 +01:00
Andy Allan
25ebf87e5a
Rename UserPreference controller methods to follow rails conventions more closely
2019-11-20 16:09:48 +01:00
Andy Allan
3bb07e29ec
Refactor api controllers to inherit from a common ApiController
2019-03-20 14:16:15 +01:00
Andy Allan
9186a6155c
Move the user preferences controller into the api namespace
2019-02-24 12:47:26 +01:00