No hash on browse pages, closes #35

This commit is contained in:
Aaron Lidman 2013-11-14 17:41:12 -08:00
parent e9c6e57bcc
commit fec9dc84c0
8 changed files with 56 additions and 19 deletions

View file

@ -203,6 +203,11 @@ $(document).ready(function () {
map.invalidateSize({pan: false}) map.invalidateSize({pan: false})
.panBy([-300, 0], {animate: false}); .panBy([-300, 0], {animate: false});
OSM.loadSidebarContent(path); OSM.loadSidebarContent(path);
page.load();
};
page.load = function() {
return map.getState();
}; };
page.popstate = function(path) { page.popstate = function(path) {
@ -256,6 +261,8 @@ $(document).ready(function () {
"/browse/:type/:id(/history)": OSM.Browse(map) "/browse/:type/:id(/history)": OSM.Browse(map)
}); });
OSM.route.load();
$(document).on("click", "a", function(e) { $(document).on("click", "a", function(e) {
if (e.isDefaultPrevented() || e.isPropagationStopped()) return; if (e.isDefaultPrevented() || e.isPropagationStopped()) return;
if (this.host === window.location.host && OSM.route(this.pathname + this.search + this.hash)) e.preventDefault(); if (this.host === window.location.host && OSM.route(this.pathname + this.search + this.hash)) e.preventDefault();

View file

@ -64,6 +64,7 @@ OSM.Export = function(map) {
$("#sidebar_content .close").on("click", page.minimizeSidebar); $("#sidebar_content .close").on("click", page.minimizeSidebar);
update(); update();
return map.getState();
}; };
page.unload = function() { page.unload = function() {

View file

@ -149,6 +149,8 @@ OSM.NewNote = function(map) {
e.preventDefault(); e.preventDefault();
createNote(newNote, e.target.form, '/api/0.6/notes.json'); createNote(newNote, e.target.form, '/api/0.6/notes.json');
}); });
return map.getState();
}; };
page.unload = function () { page.unload = function () {

View file

@ -72,6 +72,9 @@ OSM.Note = function (map) {
if (!noteState) map.addLayer(noteLayer); if (!noteState) map.addLayer(noteLayer);
if (window.location.hash == "") { if (window.location.hash == "") {
var coords = data.coordinates.split(','); var coords = data.coordinates.split(',');
OSM.route.moveListenerOff();
map.once('moveend', OSM.route.moveListenerOn);
map.getZoom() > 15 ? map.panTo(coords) : map.setView(coords, 16); map.getZoom() > 15 ? map.panTo(coords) : map.setView(coords, 16);
} }

View file

@ -70,6 +70,8 @@ OSM.Search = function(map) {
} }
}); });
}); });
return map.getState();
}; };
page.unload = function() { page.unload = function() {

View file

@ -220,6 +220,9 @@ L.OSM.Map = L.Map.extend({
var bounds = map._objectLayer.getBounds(); var bounds = map._objectLayer.getBounds();
if (bounds.isValid()) { if (bounds.isValid()) {
OSM.route.moveListenerOff();
map.once('moveend', OSM.route.moveListenerOn);
map.fitBounds(bounds); map.fitBounds(bounds);
} }
} }
@ -230,6 +233,14 @@ L.OSM.Map = L.Map.extend({
this._object = null; this._object = null;
if (this._objectLoader) this._objectLoader.abort(); if (this._objectLoader) this._objectLoader.abort();
if (this._objectLayer) this.removeLayer(this._objectLayer); if (this._objectLayer) this.removeLayer(this._objectLayer);
},
getState: function() {
return {
center: this.getCenter().wrap(),
zoom: this.getZoom(),
layers: this.getLayersCode()
}
} }
}); });

View file

@ -147,7 +147,7 @@ OSM = {
zoom = args.getZoom(); zoom = args.getZoom();
layers = args.getLayersCode(); layers = args.getLayersCode();
} else { } else {
center = L.latLng(args.lat, args.lon); center = args.center || L.latLng(args.lat, args.lon);
zoom = args.zoom; zoom = args.zoom;
layers = args.layers || ''; layers = args.layers || '';
} }

View file

@ -28,7 +28,7 @@ OSM.Router = function(map, rts) {
}); });
} }
(controller[action] || $.noop).apply(controller, params); return (controller[action] || $.noop).apply(controller, params);
}; };
return route; return route;
@ -48,19 +48,9 @@ OSM.Router = function(map, rts) {
currentRoute = routes.recognize(currentPath), currentRoute = routes.recognize(currentPath),
currentHash = location.hash || OSM.formatHash(map); currentHash = location.hash || OSM.formatHash(map);
currentRoute.run('load', currentPath);
var router, stateChange; var router, stateChange;
if (window.history && window.history.pushState) { if (window.history && window.history.pushState) {
stateChange = function(state, hash) {
window.history.replaceState(state, document.title, hash);
};
// Set a non-null initial state, so that the e.originalEvent.state
// check below works correctly when going back to the initial page.
stateChange(OSM.parseHash(currentHash), currentPath + currentHash);
$(window).on('popstate', function(e) { $(window).on('popstate', function(e) {
if (!e.originalEvent.state) return; // Is it a real popstate event or just a hash change? if (!e.originalEvent.state) return; // Is it a real popstate event or just a hash change?
var path = window.location.pathname + window.location.search; var path = window.location.pathname + window.location.search;
@ -86,22 +76,30 @@ OSM.Router = function(map, rts) {
currentRoute = route; currentRoute = route;
currentRoute.run('pushstate', currentPath); currentRoute.run('pushstate', currentPath);
return true; return true;
}
} else {
stateChange = function(state, hash) {
window.location.replace(hash);
}; };
router.stateChange = function(state) {
if (state.center) {
window.history.replaceState(state, document.title, OSM.formatHash(state));
} else {
window.history.replaceState(state, document.title, window.location);
}
};
} else {
router = function (url) { router = function (url) {
window.location.assign(url); window.location.assign(url);
} };
router.stateChange = function(state) {
if (state.center) window.location.replace(OSM.formatHash(state));
};
} }
router.updateHash = function() { router.updateHash = function() {
var hash = OSM.formatHash(map); var hash = OSM.formatHash(map);
if (hash === currentHash) return; if (hash === currentHash) return;
currentHash = hash; currentHash = hash;
stateChange(OSM.parseHash(hash), hash); router.stateChange(OSM.parseHash(hash));
}; };
router.hashUpdated = function() { router.hashUpdated = function() {
@ -112,7 +110,20 @@ OSM.Router = function(map, rts) {
if (!state) return; if (!state) return;
map.setView(state.center, state.zoom); map.setView(state.center, state.zoom);
map.updateLayers(state.layers); map.updateLayers(state.layers);
stateChange(state, hash); router.stateChange(state, hash);
};
router.moveListenerOn = function() {
map.on('moveend', router.updateHash);
};
router.moveListenerOff = function() {
map.off('moveend', router.updateHash);
};
router.load = function() {
var loadState = currentRoute.run('load', currentPath);
router.stateChange(loadState || {});
}; };
map.on('moveend baselayerchange overlaylayerchange', router.updateHash); map.on('moveend baselayerchange overlaylayerchange', router.updateHash);