Merge remote-tracking branch 'openstreetmap/pull/1352'

.rubocop_todo.yml

@@ -64,7 +64,7 @@ Metrics/BlockNesting:
 # Offense count: 62
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 1658
+  Max: 1659
 
 # Offense count: 69
 Metrics/CyclomaticComplexity:

test/controllers/changeset_controller_test.rb

@@ -1648,6 +1648,7 @@ EOF
 
     ## Now try with the public user
     changeset = changesets(:public_user_first_change)
+    create(:changeset_tag, :changeset => changeset)
     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"
     new_tag["k"] = "tagtesting"

test/factories/changeset_tags.rb

@@ -0,0 +1,9 @@
+FactoryGirl.define do
+  factory :changeset_tag do
+    sequence(:k) { |n| "Key #{n}" }
+    sequence(:v) { |n| "Value #{n}" }
+
+    # Fixme requires changeset factory
+    changeset_id 1
+  end
+end

test/fixtures/changeset_tags.yml

@@ -1,9 +0,0 @@
-changeset_1_tag_1: 
-  changeset_id: 1
-  k: created_by
-  v: test suite yml
-  
-changeset_2_tag_1: 
-  changeset_id: 2
-  k: created_by
-  v: test suite yml 2

test/models/changeset_tag_test.rb

@@ -3,10 +3,6 @@ require "test_helper"
 class ChangesetTagTest < ActiveSupport::TestCase
   api_fixtures
 
-  def test_changeset_tag_count
-    assert_equal 2, ChangesetTag.count
-  end
-
   def test_length_key_valid
     key = "k"
     (0..255).each do |i|
@@ -58,10 +54,11 @@ class ChangesetTagTest < ActiveSupport::TestCase
   end
 
   def test_uniqueness
+    existing = create(:changeset_tag)
     tag = ChangesetTag.new
-    tag.changeset_id = changeset_tags(:changeset_1_tag_1).changeset_id
+    tag.changeset_id = existing.changeset_id
-    tag.k = changeset_tags(:changeset_1_tag_1).k
+    tag.k = existing.k
-    tag.v = changeset_tags(:changeset_1_tag_1).v
+    tag.v = existing.v
     assert tag.new_record?
     assert !tag.valid?
     assert_raise(ActiveRecord::RecordInvalid) { tag.save! }

test/test_helper.rb

@@ -14,7 +14,7 @@ module ActiveSupport
     def self.api_fixtures
       # print "setting up the api_fixtures"
       fixtures :users, :user_roles
-      fixtures :changesets, :changeset_tags
+      fixtures :changesets
 
       fixtures :current_nodes, :nodes
       set_fixture_class :current_nodes => Node