cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove email confirmation field in signup form

Browse source
This commit is contained in:
Milan Cvetkovic 2023-12-12 09:47:54 +00:00 • committed by Tom Hughes
parent 1276fb944a
commit f8a606869e
7 changed files with 14 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

1
test/controllers/users_controller_test.rb
View file

@ -82,7 +82,6 @@ class UsersControllerTest < ActionDispatch::IntegrationTest
assert_select "div#content", :count => 1 do
assert_select "form[action='/user/new'][method='post']", :count => 1 do
assert_select "input[id='user_email']", :count => 1
assert_select "input[id='user_email_confirmation']", :count => 1
assert_select "input[id='user_display_name']", :count => 1
assert_select "input[id='user_pass_crypt'][type='password']", :count => 1
assert_select "input[id='user_pass_crypt_confirmation'][type='password']", :count => 1

23
test/integration/user_creation_test.rb
View file

@ -32,7 +32,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => dup_email,
:email_confirmation => dup_email,
:display_name => display_name,
:pass_crypt => "testtest",
:pass_crypt_confirmation => "testtest",
@ -54,7 +53,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => email,
:email_confirmation => email,
:display_name => dup_display_name,
:pass_crypt => "testtest",
:pass_crypt_confirmation => "testtest" } }
@ -74,7 +72,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => email,
:email_confirmation => email,
:display_name => display_name,
:pass_crypt => "testtest",
:pass_crypt_confirmation => "blahblah" } }
@ -95,7 +92,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:pass_crypt => "testtest",
:pass_crypt_confirmation => "testtest",
@ -151,7 +147,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:pass_crypt => password,
:pass_crypt_confirmation => password,
@ -204,7 +199,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "openid",
:auth_uid => "http://localhost:1123/new.tester",
@ -238,7 +232,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "openid",
:auth_uid => "http://localhost:1123/new.tester",
@ -274,7 +267,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "openid",
:auth_uid => "http://localhost:1123/new.tester",
@ -333,7 +325,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "google",
:pass_crypt => password,
@ -366,7 +357,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "google",
:pass_crypt => "",
@ -403,7 +393,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "google",
:pass_crypt => "testtest",
@ -461,7 +450,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "facebook",
:pass_crypt => password,
@ -494,7 +482,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "facebook",
:pass_crypt => "",
@ -529,7 +516,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "facebook",
:pass_crypt => "testtest",
@ -587,7 +573,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "microsoft",
:pass_crypt => password,
@ -620,7 +605,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "microsoft",
:pass_crypt => "",
@ -655,7 +639,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "microsoft",
:pass_crypt => "testtest",
@ -713,7 +696,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "github",
:pass_crypt => password,
@ -746,7 +728,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "github",
:pass_crypt => "",
@ -781,7 +762,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "github",
:pass_crypt => "testtest",
@ -839,7 +819,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "wikipedia",
:pass_crypt => password,
@ -872,7 +851,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "wikipedia",
:pass_crypt => "",
@ -907,7 +885,6 @@ class UserCreationTest < ActionDispatch::IntegrationTest
perform_enqueued_jobs do
post "/user/new",
:params => { :user => { :email => new_email,
:email_confirmation => new_email,
:display_name => display_name,
:auth_provider => "wikipedia",
:pass_crypt => "testtest",

1
test/system/confirmation_resend_test.rb
View file

@ -7,7 +7,6 @@ class ConfirmationResendSystemTest < ApplicationSystemTestCase
within ".new_user" do
fill_in "Email", :with => @user.email
fill_in "Email Confirmation", :with => @user.email
fill_in "Display Name", :with => @user.display_name
fill_in "Password", :with => "testtest"
fill_in "Confirm Password", :with => "testtest"