cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix new rubocop warnings

Browse source
This commit is contained in:
Tom Hughes 2018-06-18 09:00:49 +01:00
parent 2f6a583510
commit f7a35c5895
18 changed files with 45 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/controllers/amf_controller_test.rb
View file

@ -215,8 +215,8 @@ class AmfControllerTest < ActionController::TestCase
ways = map[2].collect { |x| x[0] }
assert ways.include?(way.id),
"map should include used way"
assert !ways.include?(deleted_way.id),
"map should not include deleted way"
assert_not ways.include?(deleted_way.id),
"map should not include deleted way"
end
##
@ -278,8 +278,8 @@ class AmfControllerTest < ActionController::TestCase
assert_equal Array, map[2].class, "third map element should be an array"
# TODO: looks like amf_controller changed since this test was written
# so someone who knows what they're doing should check this!
assert !map[2].include?(way.id),
"map should not include visible way"
assert_not map[2].include?(way.id),
"map should not include visible way"
assert map[2].include?(deleted_way.id),
"map should include deleted way"
end

10
test/controllers/changeset_controller_test.rb
View file

@ -244,8 +244,8 @@ class ChangesetControllerTest < ActionController::TestCase
# test that it really is closed now
cs = Changeset.find(cs_id)
assert(!cs.is_open?,
"changeset should be closed now (#{cs.closed_at} > #{Time.now.getutc}.")
assert_not(cs.is_open?,
"changeset should be closed now (#{cs.closed_at} > #{Time.now.getutc}.")
end
##
@ -1875,9 +1875,9 @@ CHANGESET
assert_equal Changeset::MAX_ELEMENTS + 1, changeset.num_changes
# check that the changeset is now closed as well
assert(!changeset.is_open?,
"changeset should have been auto-closed by exceeding " \
"element limit.")
assert_not(changeset.is_open?,
"changeset should have been auto-closed by exceeding " \
"element limit.")
end
##