cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use buttons for dropdown toggles

Browse source 
These elements don't link to another page, and so there's no need
to use a link that leads to nowhere.
This commit is contained in:
Andy Allan 2022-12-22 09:56:56 +00:00
parent fb9219a52f
commit f78c032b07
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/views/layouts/_header.html.erb
View file

@ -18,7 +18,7 @@
:class => "btn btn-outline-primary geolink editlink", :class => "btn btn-outline-primary geolink editlink",
:id => "editanchor", :id => "editanchor",
:data => { :editor => preferred_editor } %> :data => { :editor => preferred_editor } %>
<a class='btn btn-outline-primary dropdown-toggle dropdown-toggle-split' data-bs-toggle='dropdown' href='#'></a> <button class='btn btn-outline-primary dropdown-toggle dropdown-toggle-split' type='button' data-bs-toggle='dropdown'></button>
<ul class='dropdown-menu'> <ul class='dropdown-menu'>
<% Editors::RECOMMENDED_EDITORS.each do |editor| %> <% Editors::RECOMMENDED_EDITORS.each do |editor| %>
<li> <li>
@ -63,7 +63,7 @@
<%= link_to t("layouts.about"), about_path, :class => "nav-link" %> <%= link_to t("layouts.about"), about_path, :class => "nav-link" %>
</li> </li>
<li id="compact-secondary-nav" class="dropdown nav-item"> <li id="compact-secondary-nav" class="dropdown nav-item">
<a class="dropdown-toggle nav-link" data-bs-toggle="dropdown" href="#"><%= t "layouts.more" %></a> <button class="dropdown-toggle nav-link btn" type="button" data-bs-toggle="dropdown"><%= t "layouts.more" %></button>
<ul class="dropdown-menu"> <ul class="dropdown-menu">
<% if Settings.status != "database_offline" && can?(:index, Issue) %> <% if Settings.status != "database_offline" && can?(:index, Issue) %>
<li class="<%= current_page_class(issues_path) %>"> <li class="<%= current_page_class(issues_path) %>">
@ -84,7 +84,7 @@
</ul> </ul>
<% if current_user && current_user.id %> <% if current_user && current_user.id %>
<div class='d-inline-flex dropdown user-menu logged-in clearfix'> <div class='d-inline-flex dropdown user-menu logged-in clearfix'>
<a class='dropdown-toggle btn btn-outline-secondary px-2 py-1 flex-grow-1' data-bs-toggle='dropdown' href="#"> <button class='dropdown-toggle btn btn-outline-secondary px-2 py-1 flex-grow-1' type='button' data-bs-toggle='dropdown'>
<%= user_thumbnail_tiny(current_user, :width => 25, :height => 25, :class => "user_thumbnail_tiny rounded-1") %> <%= user_thumbnail_tiny(current_user, :width => 25, :height => 25, :class => "user_thumbnail_tiny rounded-1") %>
<%= render :partial => "layouts/inbox" %> <%= render :partial => "layouts/inbox" %>
<span class="user-button"> <span class="user-button">
@ -92,7 +92,7 @@
<%= current_user.display_name %> <%= current_user.display_name %>
</span> </span>
</span> </span>
</a> </button>
<div class='dropdown-menu dropdown-menu-end'> <div class='dropdown-menu dropdown-menu-end'>
<%= link_to t("users.show.my_dashboard"), dashboard_path, :class => "dropdown-item" %> <%= link_to t("users.show.my_dashboard"), dashboard_path, :class => "dropdown-item" %>
<%= link_to inbox_messages_path, :class => "dropdown-item" do %> <%= link_to inbox_messages_path, :class => "dropdown-item" do %>