cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix typo: change 'noreferer' to 'noreferrer'

Browse source 
as the correct rel attribute in external links.
This commit is contained in:
Andreas Geyer-Schulz 2020-01-25 20:10:23 +01:00
parent ac3df158f7
commit f6f23ed0ee
No known key found for this signature in database
GPG key ID: 1BB55B0F19A3045A
3 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
config/initializers/sanitize.rb
View file

@ -1,5 +1,5 @@
Sanitize::Config::OSM = Sanitize::Config::RELAXED.dup Sanitize::Config::OSM = Sanitize::Config::RELAXED.dup
Sanitize::Config::OSM[:elements] -= %w[div style] Sanitize::Config::OSM[:elements] -= %w[div style]
Sanitize::Config::OSM[:add_attributes] = { "a" => { "rel" => "nofollow noopener noreferer" } } Sanitize::Config::OSM[:add_attributes] = { "a" => { "rel" => "nofollow noopener noreferrer" } }
Sanitize::Config::OSM[:remove_contents] = %w[script style] Sanitize::Config::OSM[:remove_contents] = %w[script style]

4
lib/rich_text.rb
View file

@ -61,9 +61,9 @@ module RichText
def linkify(text, mode = :urls) def linkify(text, mode = :urls)
if text.html_safe? if text.html_safe?
Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferer")).html_safe Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer")).html_safe
else else
Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferer")) Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer"))
end end
end end
end end

16
test/lib/rich_text_test.rb
View file

@ -8,14 +8,14 @@ class RichTextTest < ActiveSupport::TestCase
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='http://example.com/']", 1 assert_select "a[href='http://example.com/']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("html", "foo <a href='http://example.com/'>bar</a> baz") r = RichText.new("html", "foo <a href='http://example.com/'>bar</a> baz")
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='http://example.com/']", 1 assert_select "a[href='http://example.com/']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("html", "foo example@example.com bar") r = RichText.new("html", "foo example@example.com bar")
@ -27,7 +27,7 @@ class RichTextTest < ActiveSupport::TestCase
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='mailto:example@example.com']", 1 assert_select "a[href='mailto:example@example.com']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("html", "foo <div>bar</div> baz") r = RichText.new("html", "foo <div>bar</div> baz")
@ -64,28 +64,28 @@ class RichTextTest < ActiveSupport::TestCase
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='http://example.com/']", 1 assert_select "a[href='http://example.com/']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("markdown", "foo [bar](http://example.com/) baz") r = RichText.new("markdown", "foo [bar](http://example.com/) baz")
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='http://example.com/']", 1 assert_select "a[href='http://example.com/']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("markdown", "foo example@example.com bar") r = RichText.new("markdown", "foo example@example.com bar")
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='mailto:example@example.com']", 1 assert_select "a[href='mailto:example@example.com']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("markdown", "foo [bar](mailto:example@example.com) bar") r = RichText.new("markdown", "foo [bar](mailto:example@example.com) bar")
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='mailto:example@example.com']", 1 assert_select "a[href='mailto:example@example.com']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("markdown", "foo ![bar](http://example.com/example.png) bar") r = RichText.new("markdown", "foo ![bar](http://example.com/example.png) bar")
@ -162,7 +162,7 @@ class RichTextTest < ActiveSupport::TestCase
assert_html r do assert_html r do
assert_select "a", 1 assert_select "a", 1
assert_select "a[href='http://example.com/']", 1 assert_select "a[href='http://example.com/']", 1
assert_select "a[rel='nofollow noopener noreferer']", 1 assert_select "a[rel='nofollow noopener noreferrer']", 1
end end
r = RichText.new("text", "foo example@example.com bar") r = RichText.new("text", "foo example@example.com bar")