cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unusual margins and line-height from comments

Browse source 
This allows them to follow normal conventions used elsewhere, as
well as removing some custom css.
This commit is contained in:
Andy Allan 2023-09-13 13:18:30 +01:00
parent 5d4c96878a
commit f3a4443120
3 changed files with 9 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/assets/stylesheets/common.scss
View file

@ -804,15 +804,6 @@ tr.turn:hover {
}
}
.note-comments li, .changeset-comments li {
margin: $lineheight/2 0;
p {
margin: 10px 6px 0 6px;
line-height: 1.5;
}
}
.subscribe-buttons input {
font-size: 90%;
line-height: 15px;

8
app/views/browse/changeset.html.erb
View file

@ -46,7 +46,9 @@
— <span class="action-button" data-comment-id="<%= comment.id %>" data-method="POST" data-url="<%= changeset_comment_hide_url(comment.id) %>"><%= t("javascripts.changesets.show.hide_comment") %></span>
<% end %>
</small>
<%= comment.body.to_html %>
<div class="mx-2">
<%= comment.body.to_html %>
</div>
</li>
<% elsif current_user and current_user.moderator? %>
<li id="c<%= comment.id %>">
@ -57,7 +59,9 @@
:user => link_to(comment.author.display_name, user_path(comment.author))) %>
— <span class="action-button text-muted" data-comment-id="<%= comment.id %>" data-method="POST" data-url="<%= changeset_comment_unhide_url(comment.id) %>"><%= t("javascripts.changesets.show.unhide_comment") %></span>
</small>
<%= comment.body.to_html %>
<div class="mx-2">
<%= comment.body.to_html %>
</div>
</li>
<% end %>
<% end %>

4
app/views/notes/show.html.erb
View file

@ -34,7 +34,9 @@
<% @note_comments.drop(1).each do |comment| %>
<li id="c<%= comment.id %>">
<small class='text-muted'><%= note_event(comment.event, comment.created_at, comment.author) %></small>
<%= comment.body.to_html %>
<div class="mx-2">
<%= comment.body.to_html %>
</div>
</li>
<% end %>
</ul>