Standardise on avoiding except lists for check_api_readable
Although this is technically duplicative, it's much easier to read and therefore to maintain, particularly if you put the _readable one first.
This commit is contained in:
parent
995bfa91ff
commit
f2aaec4735
6 changed files with 6 additions and 6 deletions
|
@ -1,7 +1,7 @@
|
|||
module Api
|
||||
class ChangesetCommentsController < ApiController
|
||||
before_action :check_api_readable
|
||||
before_action :check_api_writable
|
||||
before_action :check_api_readable, :except => [:create]
|
||||
before_action :authorize
|
||||
|
||||
authorize_resource
|
||||
|
|
|
@ -2,8 +2,8 @@
|
|||
|
||||
module Api
|
||||
class ChangesetsController < ApiController
|
||||
before_action :check_api_readable
|
||||
before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
|
||||
before_action :check_api_readable, :except => [:index, :create, :update, :upload, :download, :subscribe, :unsubscribe]
|
||||
before_action :setup_user_auth, :only => [:show]
|
||||
before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
|
||||
|
||||
|
|
|
@ -2,8 +2,8 @@
|
|||
|
||||
module Api
|
||||
class NodesController < ApiController
|
||||
before_action :check_api_readable
|
||||
before_action :check_api_writable, :only => [:create, :update, :delete]
|
||||
before_action :check_api_readable, :except => [:create, :update, :delete]
|
||||
before_action :authorize, :only => [:create, :update, :delete]
|
||||
|
||||
authorize_resource
|
||||
|
|
|
@ -1,7 +1,7 @@
|
|||
module Api
|
||||
class RelationsController < ApiController
|
||||
before_action :check_api_readable
|
||||
before_action :check_api_writable, :only => [:create, :update, :delete]
|
||||
before_action :check_api_readable, :except => [:create, :update, :delete]
|
||||
before_action :authorize, :only => [:create, :update, :delete]
|
||||
|
||||
authorize_resource
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
module Api
|
||||
class TracesController < ApiController
|
||||
before_action :check_api_readable, :only => [:show, :data]
|
||||
before_action :check_api_readable
|
||||
before_action :check_api_writable, :only => [:create, :update, :destroy]
|
||||
before_action :set_locale
|
||||
before_action :authorize
|
||||
|
|
|
@ -1,7 +1,7 @@
|
|||
module Api
|
||||
class WaysController < ApiController
|
||||
before_action :check_api_readable
|
||||
before_action :check_api_writable, :only => [:create, :update, :delete]
|
||||
before_action :check_api_readable, :except => [:create, :update, :delete]
|
||||
before_action :authorize, :only => [:create, :update, :delete]
|
||||
|
||||
authorize_resource
|
||||
|
|
Loading…
Add table
Reference in a new issue