cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove user_roles integration test since it is not meaningful

Browse source 
This test has not been meaningful for a long while, since both check_success and check_fail contain exactly the same code.

Additionally, the test doesn't cover any integrations (beyond logging in), and so it is only covering the same ground as the controller test.
This commit is contained in:
Andy Allan 2018-11-28 17:21:12 +01:00
parent aaf5600342
commit ed8e15c8f0
1 changed files with 0 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

58
test/integration/user_roles_test.rb
View file

@ -1,58 +0,0 @@
require "test_helper"
class UserRolesTest < ActionDispatch::IntegrationTest
def setup
stub_hostip_requests
end
test "grant" do
check_fail(:grant, :user, :moderator)
check_fail(:grant, :moderator_user, :moderator)
check_success(:grant, :administrator_user, :moderator)
end
test "revoke" do
check_fail(:revoke, :user, :moderator)
check_fail(:revoke, :moderator_user, :moderator)
# this other user doesn't have moderator role, so this fails
check_fail(:revoke, :administrator_user, :moderator)
end
private
def check_fail(action, user, role)
get "/login"
assert_response :redirect
assert_redirected_to "controller" => "users", "action" => "login", "cookie_test" => "true"
follow_redirect!
assert_response :success
post "/login", :params => { "username" => create(user).email, "password" => "test", :referer => "/" }
assert_response :redirect
follow_redirect!
assert_response :success
target_user = create(:user)
post "/user/#{ERB::Util.u(target_user.display_name)}/role/#{role}/#{action}"
assert_redirected_to user_path(target_user)
reset!
end
def check_success(action, user, role)
get "/login"
assert_response :redirect
assert_redirected_to "controller" => "users", "action" => "login", "cookie_test" => "true"
follow_redirect!
assert_response :success
post "/login", :params => { "username" => create(user).email, "password" => "test", :referer => "/" }
assert_response :redirect
follow_redirect!
assert_response :success
target_user = create(:user)
post "/user/#{ERB::Util.u(target_user.display_name)}/role/#{role}/#{action}"
assert_redirected_to user_path(target_user)
reset!
end
end