Use double quotes consistently in javascript code

This commit is contained in:
Tom Hughes 2019-04-06 15:59:34 +01:00
parent 87127d41e9
commit eb7678145a
29 changed files with 650 additions and 649 deletions

View file

@ -7,243 +7,243 @@ L.OSM.share = function (options) {
});
control.onAdd = function (map) {
var $container = $('<div>')
.attr('class', 'control-share');
var $container = $("<div>")
.attr("class", "control-share");
var button = $('<a>')
.attr('class', 'control-button')
.attr('href', '#')
.attr('title', I18n.t('javascripts.share.title'))
.html('<span class="icon share"></span>')
.on('click', toggle)
var button = $("<a>")
.attr("class", "control-button")
.attr("href", "#")
.attr("title", I18n.t("javascripts.share.title"))
.html("<span class=\"icon share\"></span>")
.on("click", toggle)
.appendTo($container);
var $ui = $('<div>')
.attr('class', 'share-ui');
var $ui = $("<div>")
.attr("class", "share-ui");
$('<div>')
.attr('class', 'sidebar_heading')
$("<div>")
.attr("class", "sidebar_heading")
.appendTo($ui)
.append(
$('<span>')
.text(I18n.t('javascripts.close'))
.attr('class', 'icon close')
.bind('click', toggle))
$("<span>")
.text(I18n.t("javascripts.close"))
.attr("class", "icon close")
.bind("click", toggle))
.append(
$('<h4>')
.text(I18n.t('javascripts.share.title')));
$("<h4>")
.text(I18n.t("javascripts.share.title")));
// Link / Embed
var $linkSection = $('<div>')
.attr('class', 'section share-link')
var $linkSection = $("<div>")
.attr("class", "section share-link")
.appendTo($ui);
$('<h4>')
.text(I18n.t('javascripts.share.link'))
$("<h4>")
.text(I18n.t("javascripts.share.link"))
.appendTo($linkSection);
var $form = $('<form>')
.attr('class', 'standard-form')
var $form = $("<form>")
.attr("class", "standard-form")
.appendTo($linkSection);
$('<div>')
.attr('class', 'form-row')
$("<div>")
.attr("class", "form-row")
.appendTo($form)
.append(
$('<label>')
.attr('for', 'link_marker')
$("<label>")
.attr("for", "link_marker")
.append(
$('<input>')
.attr('id', 'link_marker')
.attr('type', 'checkbox')
.bind('change', toggleMarker))
.append(I18n.t('javascripts.share.include_marker')));
$("<input>")
.attr("id", "link_marker")
.attr("type", "checkbox")
.bind("change", toggleMarker))
.append(I18n.t("javascripts.share.include_marker")));
$('<div>')
.attr('class', 'share-tabs')
$("<div>")
.attr("class", "share-tabs")
.appendTo($form)
.append($('<a>')
.attr('class', 'active')
.attr('for', 'long_input')
.attr('id', 'long_link')
.text(I18n.t('javascripts.share.long_link')))
.append($('<a>')
.attr('for', 'short_input')
.attr('id', 'short_link')
.text(I18n.t('javascripts.share.short_link')))
.append($('<a>')
.attr('for', 'embed_html')
.attr('href', '#')
.text(I18n.t('javascripts.share.embed')))
.on('click', 'a', function(e) {
.append($("<a>")
.attr("class", "active")
.attr("for", "long_input")
.attr("id", "long_link")
.text(I18n.t("javascripts.share.long_link")))
.append($("<a>")
.attr("for", "short_input")
.attr("id", "short_link")
.text(I18n.t("javascripts.share.short_link")))
.append($("<a>")
.attr("for", "embed_html")
.attr("href", "#")
.text(I18n.t("javascripts.share.embed")))
.on("click", "a", function(e) {
e.preventDefault();
var id = '#' + $(this).attr('for');
$linkSection.find('.share-tabs a')
.removeClass('active');
$(this).addClass('active');
$linkSection.find('.share-tab')
var id = "#" + $(this).attr("for");
$linkSection.find(".share-tabs a")
.removeClass("active");
$(this).addClass("active");
$linkSection.find(".share-tab")
.hide();
$linkSection.find('.share-tab:has(' + id + ')')
$linkSection.find(".share-tab:has(" + id + ")")
.show()
.find('input, textarea')
.find("input, textarea")
.select();
});
$('<div>')
.attr('class', 'form-row share-tab')
.css('display', 'block')
$("<div>")
.attr("class", "form-row share-tab")
.css("display", "block")
.appendTo($form)
.append($('<input>')
.attr('id', 'long_input')
.attr('type', 'text')
.on('click', select));
.append($("<input>")
.attr("id", "long_input")
.attr("type", "text")
.on("click", select));
$('<div>')
.attr('class', 'form-row share-tab')
$("<div>")
.attr("class", "form-row share-tab")
.appendTo($form)
.append($('<input>')
.attr('id', 'short_input')
.attr('type', 'text')
.on('click', select));
.append($("<input>")
.attr("id", "short_input")
.attr("type", "text")
.on("click", select));
$('<div>')
.attr('class', 'form-row share-tab')
$("<div>")
.attr("class", "form-row share-tab")
.appendTo($form)
.append(
$('<textarea>')
.attr('id', 'embed_html')
.on('click', select))
$("<textarea>")
.attr("id", "embed_html")
.on("click", select))
.append(
$('<p>')
.attr('class', 'deemphasize')
.text(I18n.t('javascripts.share.paste_html'))
$("<p>")
.attr("class", "deemphasize")
.text(I18n.t("javascripts.share.paste_html"))
.appendTo($linkSection));
// Geo URI
var $geoUriSection = $('<div>')
.attr('class', 'section share-geo-uri')
var $geoUriSection = $("<div>")
.attr("class", "section share-geo-uri")
.appendTo($ui);
$('<h4>')
.text(I18n.t('javascripts.share.geo_uri'))
$("<h4>")
.text(I18n.t("javascripts.share.geo_uri"))
.appendTo($geoUriSection);
$('<div>')
$("<div>")
.appendTo($geoUriSection)
.append($('<a>')
.attr('id', 'geo_uri'));
.append($("<a>")
.attr("id", "geo_uri"));
// Image
var $imageSection = $('<div>')
.attr('class', 'section share-image')
var $imageSection = $("<div>")
.attr("class", "section share-image")
.appendTo($ui);
$('<h4>')
.text(I18n.t('javascripts.share.image'))
$("<h4>")
.text(I18n.t("javascripts.share.image"))
.appendTo($imageSection);
$('<div>')
.attr('id', 'export-warning')
.attr('class', 'deemphasize')
.text(I18n.t('javascripts.share.only_standard_layer'))
$("<div>")
.attr("id", "export-warning")
.attr("class", "deemphasize")
.text(I18n.t("javascripts.share.only_standard_layer"))
.appendTo($imageSection);
$form = $('<form>')
.attr('id', 'export-image')
.attr('class', 'standard-form')
.attr('action', '/export/finish')
.attr('method', 'post')
$form = $("<form>")
.attr("id", "export-image")
.attr("class", "standard-form")
.attr("action", "/export/finish")
.attr("method", "post")
.appendTo($imageSection);
$('<div>')
.attr('class', 'form-row')
$("<div>")
.attr("class", "form-row")
.appendTo($form)
.append(
$('<label>')
.attr('for', 'image_filter')
$("<label>")
.attr("for", "image_filter")
.append(
$('<input>')
.attr('id', 'image_filter')
.attr('type', 'checkbox')
.bind('change', toggleFilter))
.append(I18n.t('javascripts.share.custom_dimensions')));
$("<input>")
.attr("id", "image_filter")
.attr("type", "checkbox")
.bind("change", toggleFilter))
.append(I18n.t("javascripts.share.custom_dimensions")));
$('<div>')
.attr('class', 'form-row')
$("<div>")
.attr("class", "form-row")
.appendTo($form)
.append(
$('<label>')
.attr('for', 'mapnik_format')
.text(I18n.t('javascripts.share.format')))
.append($('<select>')
.attr('name', 'mapnik_format')
.attr('id', 'mapnik_format')
.append($('<option>').val('png').text('PNG').prop('selected', true))
.append($('<option>').val('jpeg').text('JPEG'))
.append($('<option>').val('svg').text('SVG'))
.append($('<option>').val('pdf').text('PDF')));
$("<label>")
.attr("for", "mapnik_format")
.text(I18n.t("javascripts.share.format")))
.append($("<select>")
.attr("name", "mapnik_format")
.attr("id", "mapnik_format")
.append($("<option>").val("png").text("PNG").prop("selected", true))
.append($("<option>").val("jpeg").text("JPEG"))
.append($("<option>").val("svg").text("SVG"))
.append($("<option>").val("pdf").text("PDF")));
$('<div>')
.attr('class', 'form-row')
$("<div>")
.attr("class", "form-row")
.appendTo($form)
.append($('<label>')
.attr('for', 'mapnik_scale')
.text(I18n.t('javascripts.share.scale')))
.append('1 : ')
.append($('<input>')
.attr('name', 'mapnik_scale')
.attr('id', 'mapnik_scale')
.attr('type', 'text')
.on('change', update));
.append($("<label>")
.attr("for", "mapnik_scale")
.text(I18n.t("javascripts.share.scale")))
.append("1 : ")
.append($("<input>")
.attr("name", "mapnik_scale")
.attr("id", "mapnik_scale")
.attr("type", "text")
.on("change", update));
['minlon', 'minlat', 'maxlon', 'maxlat'].forEach(function(name) {
$('<input>')
.attr('id', 'mapnik_' + name)
.attr('name', name)
.attr('type', 'hidden')
["minlon", "minlat", "maxlon", "maxlat"].forEach(function(name) {
$("<input>")
.attr("id", "mapnik_" + name)
.attr("name", name)
.attr("type", "hidden")
.appendTo($form);
});
$('<input>')
.attr('name', 'format')
.attr('value', 'mapnik')
.attr('type', 'hidden')
$("<input>")
.attr("name", "format")
.attr("value", "mapnik")
.attr("type", "hidden")
.appendTo($form);
var csrf_param = $("meta[name=csrf-param]").attr("content"),
csrf_token = $("meta[name=csrf-token]").attr("content");
$('<input>')
.attr('name', csrf_param)
.attr('value', csrf_token)
.attr('type', 'hidden')
$("<input>")
.attr("name", csrf_param)
.attr("value", csrf_token)
.attr("type", "hidden")
.appendTo($form);
$('<p>')
.attr('class', 'deemphasize')
.html(I18n.t('javascripts.share.image_size') + ' <span id="mapnik_image_width"></span> x <span id="mapnik_image_height"></span>')
$("<p>")
.attr("class", "deemphasize")
.html(I18n.t("javascripts.share.image_size") + " <span id=\"mapnik_image_width\"></span> x <span id=\"mapnik_image_height\"></span>")
.appendTo($form);
$('<input>')
.attr('type', 'submit')
.attr('value', I18n.t('javascripts.share.download'))
$("<input>")
.attr("type", "submit")
.attr("value", I18n.t("javascripts.share.download"))
.appendTo($form);
locationFilter
.on('change', update)
.on("change", update)
.addTo(map);
marker.on('dragend', movedMarker);
map.on('move', movedMap);
map.on('moveend layeradd layerremove', update);
marker.on("dragend", movedMarker);
map.on("move", movedMap);
map.on("moveend layeradd layerremove", update);
options.sidebar.addPane($ui);
$ui
.on('hide', hidden);
.on("hide", hidden);
function hidden() {
map.removeLayer(marker);
@ -256,19 +256,19 @@ L.OSM.share = function (options) {
e.stopPropagation();
e.preventDefault();
$('#mapnik_scale').val(getScale());
$("#mapnik_scale").val(getScale());
marker.setLatLng(map.getCenter());
update();
options.sidebar.togglePane($ui, button);
$('.leaflet-control .control-button').tooltip('hide');
$(".leaflet-control .control-button").tooltip("hide");
}
function toggleMarker() {
if ($(this).is(':checked')) {
if ($(this).is(":checked")) {
marker.setLatLng(map.getCenter());
map.addLayer(marker);
map.options.scrollWheelZoom = map.options.doubleClickZoom = 'center';
map.options.scrollWheelZoom = map.options.doubleClickZoom = "center";
} else {
map.removeLayer(marker);
map.options.scrollWheelZoom = map.options.doubleClickZoom = true;
@ -277,7 +277,7 @@ L.OSM.share = function (options) {
}
function toggleFilter() {
if ($(this).is(':checked')) {
if ($(this).is(":checked")) {
locationFilter.setBounds(map.getBounds().pad(-0.2));
locationFilter.enable();
} else {
@ -293,27 +293,27 @@ L.OSM.share = function (options) {
function movedMarker() {
if (map.hasLayer(marker)) {
map.off('move', movedMap);
map.on('moveend', updateOnce);
map.off("move", movedMap);
map.on("moveend", updateOnce);
map.panTo(marker.getLatLng());
}
}
function updateOnce() {
map.off('moveend', updateOnce);
map.on('move', movedMap);
map.off("moveend", updateOnce);
map.on("move", movedMap);
update();
}
function escapeHTML(string) {
var htmlEscapes = {
'&': '&amp;',
'<': '&lt;',
'>': '&gt;',
'"': '&quot;',
"'": '&#x27;'
"&": "&amp;",
"<": "&lt;",
">": "&gt;",
"\"": "&quot;",
"'": "&#x27;"
};
return string === null ? '' : (string + '').replace(/[&<>"']/g, function(match) {
return string === null ? "" : (string + "").replace(/[&<>"']/g, function(match) {
return htmlEscapes[match];
});
}
@ -321,18 +321,18 @@ L.OSM.share = function (options) {
function update() {
var bounds = map.getBounds();
$('#link_marker')
.prop('checked', map.hasLayer(marker));
$("#link_marker")
.prop("checked", map.hasLayer(marker));
$('#image_filter')
.prop('checked', locationFilter.isEnabled());
$("#image_filter")
.prop("checked", locationFilter.isEnabled());
// Link / Embed
$('#short_input').val(map.getShortUrl(marker));
$('#long_input').val(map.getUrl(marker));
$('#short_link').attr('href', map.getShortUrl(marker));
$('#long_link').attr('href', map.getUrl(marker));
$("#short_input").val(map.getShortUrl(marker));
$("#long_input").val(map.getUrl(marker));
$("#short_link").attr("href", map.getShortUrl(marker));
$("#long_link").attr("href", map.getUrl(marker));
var params = {
bbox: bounds.toBBoxString(),
@ -341,20 +341,20 @@ L.OSM.share = function (options) {
if (map.hasLayer(marker)) {
var latLng = marker.getLatLng().wrap();
params.marker = latLng.lat + ',' + latLng.lng;
params.marker = latLng.lat + "," + latLng.lng;
}
$('#embed_html').val(
'<iframe width="425" height="350" frameborder="0" scrolling="no" marginheight="0" marginwidth="0" src="' +
escapeHTML(OSM.SERVER_PROTOCOL + '://' + OSM.SERVER_URL + '/export/embed.html?' + $.param(params)) +
'" style="border: 1px solid black"></iframe><br/>' +
'<small><a href="' + escapeHTML(map.getUrl(marker)) + '">' +
escapeHTML(I18n.t('javascripts.share.view_larger_map')) + '</a></small>');
$("#embed_html").val(
"<iframe width=\"425\" height=\"350\" frameborder=\"0\" scrolling=\"no\" marginheight=\"0\" marginwidth=\"0\" src=\"" +
escapeHTML(OSM.SERVER_PROTOCOL + "://" + OSM.SERVER_URL + "/export/embed.html?" + $.param(params)) +
"\" style=\"border: 1px solid black\"></iframe><br/>" +
"<small><a href=\"" + escapeHTML(map.getUrl(marker)) + "\">" +
escapeHTML(I18n.t("javascripts.share.view_larger_map")) + "</a></small>");
// Geo URI
$('#geo_uri')
.attr('href', map.getGeoUri(marker))
$("#geo_uri")
.attr("href", map.getGeoUri(marker))
.html(map.getGeoUri(marker));
// Image
@ -368,10 +368,10 @@ L.OSM.share = function (options) {
L.CRS.EPSG3857.project(bounds.getNorthEast())).getSize(),
maxScale = Math.floor(Math.sqrt(size.x * size.y / 0.3136));
$('#mapnik_minlon').val(bounds.getWest());
$('#mapnik_minlat').val(bounds.getSouth());
$('#mapnik_maxlon').val(bounds.getEast());
$('#mapnik_maxlat').val(bounds.getNorth());
$("#mapnik_minlon").val(bounds.getWest());
$("#mapnik_minlat").val(bounds.getSouth());
$("#mapnik_maxlon").val(bounds.getEast());
$("#mapnik_maxlat").val(bounds.getNorth());
if (scale < maxScale) {
scale = roundScale(maxScale);
@ -381,12 +381,12 @@ L.OSM.share = function (options) {
$("#mapnik_image_width").text(Math.round(size.x / scale / 0.00028));
$("#mapnik_image_height").text(Math.round(size.y / scale / 0.00028));
if (map.getMapBaseLayerId() === 'mapnik') {
$('#export-image').show();
$('#export-warning').hide();
if (map.getMapBaseLayerId() === "mapnik") {
$("#export-image").show();
$("#export-warning").hide();
} else {
$('#export-image').hide();
$('#export-warning').show();
$("#export-image").hide();
$("#export-warning").show();
}
}