Add functional tests for user blocks
Also fixes various issues in the code discovered while writing the tests, and adds some named routes for user blocks.
This commit is contained in:
Tom Hughes
parent
359371b31c
commit
e1d873cde9
8 changed files with 455 additions and 46 deletions
|
|
@ -1,6 +1,8 @@
|
|||
require File.dirname(__FILE__) + '/../test_helper'
|
||||
|
||||
class UserBlocksControllerTest < ActionController::TestCase
|
||||
fixtures :users, :user_roles, :user_blocks
|
||||
|
||||
##
|
||||
# test all routes which lead to this controller
|
||||
def test_routes
|
||||
|
|
@ -55,4 +57,331 @@ class UserBlocksControllerTest < ActionController::TestCase
|
|||
{ :controller => "user_blocks", :action => "blocks_by", :display_name => "username" }
|
||||
)
|
||||
end
|
||||
|
||||
##
|
||||
# test the index action
|
||||
def test_index
|
||||
get :index
|
||||
assert_response :success
|
||||
assert_select "table#block_list", :count => 1 do
|
||||
assert_select "tr", 4
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:active_block))}']", 1
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:expired_block))}']", 1
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:revoked_block))}']", 1
|
||||
end
|
||||
end
|
||||
|
||||
##
|
||||
# test the show action
|
||||
def test_show
|
||||
get :show
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID could not be found."
|
||||
|
||||
get :show, :id => 99999
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
|
||||
|
||||
get :show, :id => user_blocks(:active_block)
|
||||
assert_response :success
|
||||
|
||||
get :show, :id => user_blocks(:expired_block)
|
||||
assert_response :success
|
||||
|
||||
get :show, :id => user_blocks(:revoked_block)
|
||||
assert_response :success
|
||||
end
|
||||
|
||||
##
|
||||
# test the new action
|
||||
def test_new
|
||||
get :new, :display_name => users(:normal_user).display_name
|
||||
assert_redirected_to login_path(:referer => new_user_block_path(:display_name => users(:normal_user).display_name))
|
||||
|
||||
session[:user] = users(:public_user).id
|
||||
cookies["_osm_username"] = users(:public_user).display_name
|
||||
|
||||
get :new, :display_name => users(:normal_user).display_name
|
||||
assert_redirected_to user_blocks_path
|
||||
assert_equal "You need to be a moderator to perform that action.", flash[:error]
|
||||
|
||||
session[:user] = users(:moderator_user).id
|
||||
cookies["_osm_username"] = users(:moderator_user).display_name
|
||||
|
||||
get :new, :display_name => users(:normal_user).display_name
|
||||
assert_response :success
|
||||
assert_select "form#new_user_block", :count => 1 do
|
||||
assert_select "textarea#user_block_reason", :count => 1
|
||||
assert_select "select#user_block_period", :count => 1
|
||||
assert_select "input#user_block_needs_view[type='checkbox']", :count => 1
|
||||
assert_select "input#display_name[type='hidden']", :count => 1
|
||||
assert_select "input[type='submit'][value='Create block']", :count => 1
|
||||
end
|
||||
|
||||
get :new
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user does not exist"
|
||||
|
||||
get :new, :display_name => "non_existent_user"
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user non_existent_user does not exist"
|
||||
end
|
||||
|
||||
##
|
||||
# test the edit action
|
||||
def test_edit
|
||||
get :edit, :id => user_blocks(:active_block).id
|
||||
assert_redirected_to login_path(:referer => edit_user_block_path(:id => user_blocks(:active_block).id))
|
||||
|
||||
session[:user] = users(:public_user).id
|
||||
cookies["_osm_username"] = users(:public_user).display_name
|
||||
|
||||
get :edit, :id => user_blocks(:active_block).id
|
||||
assert_redirected_to user_blocks_path
|
||||
assert_equal "You need to be a moderator to perform that action.", flash[:error]
|
||||
|
||||
session[:user] = users(:moderator_user).id
|
||||
cookies["_osm_username"] = users(:moderator_user).display_name
|
||||
|
||||
get :edit, :id => user_blocks(:active_block).id
|
||||
assert_response :success
|
||||
assert_select "form#edit_user_block_#{user_blocks(:active_block).id}", :count => 1 do
|
||||
assert_select "textarea#user_block_reason", :count => 1
|
||||
assert_select "select#user_block_period", :count => 1
|
||||
assert_select "input#user_block_needs_view[type='checkbox']", :count => 1
|
||||
assert_select "input[type='submit'][value='Update block']", :count => 1
|
||||
end
|
||||
|
||||
get :edit
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID could not be found."
|
||||
|
||||
get :edit, :id => 99999
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
|
||||
end
|
||||
|
||||
##
|
||||
# test the create action
|
||||
def test_create
|
||||
post :create
|
||||
assert_response :forbidden
|
||||
|
||||
session[:user] = users(:public_user).id
|
||||
cookies["_osm_username"] = users(:public_user).display_name
|
||||
|
||||
post :create
|
||||
assert_response :forbidden
|
||||
|
||||
session[:user] = users(:moderator_user).id
|
||||
cookies["_osm_username"] = users(:moderator_user).display_name
|
||||
|
||||
assert_no_difference "UserBlock.count" do
|
||||
post :create,
|
||||
:display_name => users(:unblocked_user).display_name,
|
||||
:user_block_period => "99"
|
||||
end
|
||||
assert_redirected_to new_user_block_path(:display_name => users(:unblocked_user).display_name)
|
||||
assert_equal "The blocking period must be one of the values selectable in the drop-down list.", flash[:error]
|
||||
|
||||
assert_difference "UserBlock.count", 1 do
|
||||
post :create,
|
||||
:display_name => users(:unblocked_user).display_name,
|
||||
:user_block_period => "12",
|
||||
:user_block => { :needs_view => false, :reason => "Vandalism" }
|
||||
end
|
||||
assert_redirected_to user_block_path(:id => 4)
|
||||
assert_equal "Created a block on user #{users(:unblocked_user).display_name}.", flash[:notice]
|
||||
b = UserBlock.find(4)
|
||||
assert_in_delta Time.now, b.created_at, 1
|
||||
assert_in_delta Time.now, b.updated_at, 1
|
||||
assert_in_delta Time.now + 12.hour, b.ends_at, 1
|
||||
assert_equal false, b.needs_view
|
||||
assert_equal "Vandalism", b.reason
|
||||
assert_equal "markdown", b.reason_format
|
||||
assert_equal users(:moderator_user).id, b.creator_id
|
||||
|
||||
post :create
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user does not exist"
|
||||
|
||||
post :create, :display_name => "non_existent_user"
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user non_existent_user does not exist"
|
||||
end
|
||||
|
||||
##
|
||||
# test the update action
|
||||
def test_update
|
||||
put :update
|
||||
assert_response :forbidden
|
||||
|
||||
session[:user] = users(:public_user).id
|
||||
cookies["_osm_username"] = users(:public_user).display_name
|
||||
|
||||
put :update
|
||||
assert_response :forbidden
|
||||
|
||||
session[:user] = users(:second_moderator_user).id
|
||||
cookies["_osm_username"] = users(:second_moderator_user).display_name
|
||||
|
||||
assert_no_difference "UserBlock.count" do
|
||||
put :update,
|
||||
:id => user_blocks(:active_block).id,
|
||||
:user_block_period => "12",
|
||||
:user_block => { :needs_view => true, :reason => "Vandalism" }
|
||||
end
|
||||
assert_redirected_to edit_user_block_path(:id => user_blocks(:active_block).id)
|
||||
assert_equal "Only the moderator who created this block can edit it.", flash[:error]
|
||||
|
||||
session[:user] = users(:moderator_user).id
|
||||
cookies["_osm_username"] = users(:moderator_user).display_name
|
||||
|
||||
assert_no_difference "UserBlock.count" do
|
||||
put :update,
|
||||
:id => user_blocks(:active_block).id,
|
||||
:user_block_period => "99"
|
||||
end
|
||||
assert_redirected_to edit_user_block_path(:id => user_blocks(:active_block).id)
|
||||
assert_equal "The blocking period must be one of the values selectable in the drop-down list.", flash[:error]
|
||||
|
||||
assert_no_difference "UserBlock.count" do
|
||||
put :update,
|
||||
:id => user_blocks(:active_block).id,
|
||||
:user_block_period => "12",
|
||||
:user_block => { :needs_view => true, :reason => "Vandalism" }
|
||||
end
|
||||
assert_redirected_to user_block_path(:id => user_blocks(:active_block).id)
|
||||
assert_equal "Block updated.", flash[:notice]
|
||||
b = UserBlock.find(user_blocks(:active_block).id)
|
||||
assert_in_delta Time.now, b.updated_at, 1
|
||||
assert_equal true, b.needs_view
|
||||
assert_equal "Vandalism", b.reason
|
||||
|
||||
put :update
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID could not be found."
|
||||
|
||||
put :update, :id => 99999
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
|
||||
end
|
||||
|
||||
##
|
||||
# test the revoke action
|
||||
def test_revoke
|
||||
get :revoke, :id => user_blocks(:active_block).id
|
||||
assert_redirected_to login_path(:referer => revoke_user_block_path(:id => user_blocks(:active_block).id))
|
||||
|
||||
session[:user] = users(:public_user).id
|
||||
cookies["_osm_username"] = users(:public_user).display_name
|
||||
|
||||
get :revoke, :id => user_blocks(:active_block).id
|
||||
assert_redirected_to user_blocks_path
|
||||
assert_equal "You need to be a moderator to perform that action.", flash[:error]
|
||||
|
||||
session[:user] = users(:moderator_user).id
|
||||
cookies["_osm_username"] = users(:moderator_user).display_name
|
||||
|
||||
get :revoke, :id => user_blocks(:active_block).id
|
||||
assert_response :success
|
||||
assert_template "revoke"
|
||||
assert_select "form", :count => 1 do
|
||||
assert_select "input#confirm[type='checkbox']", :count => 1
|
||||
assert_select "input[type='submit'][value='Revoke!']", :count => 1
|
||||
end
|
||||
|
||||
post :revoke, :id => user_blocks(:active_block).id, :confirm => true
|
||||
assert_redirected_to user_block_path(:id => user_blocks(:active_block).id)
|
||||
b = UserBlock.find(user_blocks(:active_block).id)
|
||||
assert_in_delta Time.now, b.ends_at, 1
|
||||
|
||||
get :revoke
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID could not be found."
|
||||
|
||||
get :revoke, :id => 99999
|
||||
assert_response :not_found
|
||||
assert_template "not_found"
|
||||
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
|
||||
end
|
||||
|
||||
##
|
||||
# test the blocks_on action
|
||||
def test_blocks_on
|
||||
get :blocks_on
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user does not exist"
|
||||
|
||||
get :blocks_on, :display_name => "non_existent_user"
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user non_existent_user does not exist"
|
||||
|
||||
get :blocks_on, :display_name => users(:normal_user).display_name
|
||||
assert_response :success
|
||||
assert_select "table#block_list", false
|
||||
assert_select "p", "#{users(:normal_user).display_name} has not been blocked yet."
|
||||
|
||||
get :blocks_on, :display_name => users(:blocked_user).display_name
|
||||
assert_response :success
|
||||
assert_select "table#block_list", :count => 1 do
|
||||
assert_select "tr", 3
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:active_block))}']", 1
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:revoked_block))}']", 1
|
||||
end
|
||||
|
||||
get :blocks_on, :display_name => users(:unblocked_user).display_name
|
||||
assert_response :success
|
||||
assert_select "table#block_list", :count => 1 do
|
||||
assert_select "tr", 2
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:expired_block))}']", 1
|
||||
end
|
||||
end
|
||||
|
||||
##
|
||||
# test the blocks_by action
|
||||
def test_blocks_by
|
||||
get :blocks_by
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user does not exist"
|
||||
|
||||
get :blocks_by, :display_name => "non_existent_user"
|
||||
assert_response :not_found
|
||||
assert_template "user/no_such_user"
|
||||
assert_select "h2", "The user non_existent_user does not exist"
|
||||
|
||||
get :blocks_by, :display_name => users(:moderator_user).display_name
|
||||
assert_response :success
|
||||
assert_select "table#block_list", :count => 1 do
|
||||
assert_select "tr", 2
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:active_block))}']", 1
|
||||
end
|
||||
|
||||
get :blocks_by, :display_name => users(:second_moderator_user).display_name
|
||||
assert_response :success
|
||||
assert_select "table#block_list", :count => 1 do
|
||||
assert_select "tr", 3
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:expired_block))}']", 1
|
||||
assert_select "a[href='#{user_block_path(user_blocks(:revoked_block))}']", 1
|
||||
end
|
||||
|
||||
get :blocks_by, :display_name => users(:normal_user).display_name
|
||||
assert_response :success
|
||||
assert_select "table#block_list", false
|
||||
assert_select "p", "#{users(:normal_user).display_name} has not made any blocks yet."
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue