removed comments which apparently no-one bothers to read anyway. since no-one reads the comments, changed changeset model to use Time instead of DateTime. will probably have to change it back later, when someone else who doesn't read comments comes along.

This commit is contained in:
Matt Amos 2008-12-23 15:59:56 +00:00
parent 62b6d15967
commit d6a1ccf6b4

View file

@ -27,15 +27,11 @@ class Changeset < ActiveRecord::Base
# maximum number of elements allowed in a changeset # maximum number of elements allowed in a changeset
MAX_ELEMENTS = 50000 MAX_ELEMENTS = 50000
# maximum time a changeset is allowed to be open for (note that this # maximum time a changeset is allowed to be open for.
# is in days - so one hour is Rational(1,24)).
MAX_TIME_OPEN = 1.day MAX_TIME_OPEN = 1.day
# idle timeout increment, one hour as a rational number of days. # idle timeout increment, one hour seems reasonable.
# NOTE: DO NOT CHANGE THIS TO 1.hour! when this was done the idle IDLE_TIMEOUT = 1.hour
# timeout changed to 1 second, which meant all changesets closed
# almost immediately.
IDLE_TIMEOUT = 1.hour # Rational(1,24)
# Use a method like this, so that we can easily change how we # Use a method like this, so that we can easily change how we
# determine whether a changeset is open, without breaking code in at # determine whether a changeset is open, without breaking code in at
@ -46,12 +42,12 @@ class Changeset < ActiveRecord::Base
# note that this may not be a hard limit - due to timing changes and # note that this may not be a hard limit - due to timing changes and
# concurrency it is possible that some changesets may be slightly # concurrency it is possible that some changesets may be slightly
# longer than strictly allowed or have slightly more changes in them. # longer than strictly allowed or have slightly more changes in them.
return ((closed_at > DateTime.now) and (num_changes <= MAX_ELEMENTS)) return ((closed_at > Time.now) and (num_changes <= MAX_ELEMENTS))
end end
def set_closed_time_now def set_closed_time_now
unless is_open? unless is_open?
self.closed_at = DateTime.now self.closed_at = Time.now
end end
end end
@ -156,7 +152,7 @@ class Changeset < ActiveRecord::Base
if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT) if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
self.closed_at = created_at + MAX_TIME_OPEN self.closed_at = created_at + MAX_TIME_OPEN
else else
self.closed_at = DateTime.now + IDLE_TIMEOUT self.closed_at = Time.now + IDLE_TIMEOUT
end end
self.save! self.save!