cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Speed up tests by making fewer random changes

Browse source 
The old_node_controller#test_version in particular was slow, since
it saves a huge number of tags when adding a tag 30 times over. Since
the tests are random and not based on the number of iterations, this
reduces the iteration counts.
This commit is contained in:
Andy Allan 2018-06-06 13:54:09 +08:00
parent 892c30aa8c
commit d336523738
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/controllers/changeset_controller_test.rb
View file

@ -557,7 +557,7 @@ CHANGESET
end end
def test_repeated_changeset_create def test_repeated_changeset_create
30.times do 3.times do
basic_authorization create(:user).email, "test" basic_authorization create(:user).email, "test"
# create a temporary changeset # create a temporary changeset

8
test/controllers/old_node_controller_test.rb
View file

@ -55,7 +55,7 @@ class OldNodeControllerTest < ActionController::TestCase
versions[xml_node["version"]] = xml_doc.to_s versions[xml_node["version"]] = xml_doc.to_s
# randomly move the node about # randomly move the node about
20.times do 3.times do
# move the node somewhere else # move the node somewhere else
xml_node["lat"] = precision(rand * 180 - 90).to_s xml_node["lat"] = precision(rand * 180 - 90).to_s
xml_node["lon"] = precision(rand * 360 - 180).to_s xml_node["lon"] = precision(rand * 360 - 180).to_s
@ -70,7 +70,7 @@ class OldNodeControllerTest < ActionController::TestCase
end end
# add a bunch of random tags # add a bunch of random tags
30.times do 3.times do
xml_tag = XML::Node.new("tag") xml_tag = XML::Node.new("tag")
xml_tag["k"] = random_string xml_tag["k"] = random_string
xml_tag["v"] = random_string xml_tag["v"] = random_string
@ -105,7 +105,7 @@ class OldNodeControllerTest < ActionController::TestCase
versions[xml_node["version"]] = xml_doc.to_s versions[xml_node["version"]] = xml_doc.to_s
# randomly move the node about # randomly move the node about
20.times do 3.times do
# move the node somewhere else # move the node somewhere else
xml_node["lat"] = precision(rand * 180 - 90).to_s xml_node["lat"] = precision(rand * 180 - 90).to_s
xml_node["lon"] = precision(rand * 360 - 180).to_s xml_node["lon"] = precision(rand * 360 - 180).to_s
@ -120,7 +120,7 @@ class OldNodeControllerTest < ActionController::TestCase
end end
# add a bunch of random tags # add a bunch of random tags
30.times do 3.times do
xml_tag = XML::Node.new("tag") xml_tag = XML::Node.new("tag")
xml_tag["k"] = random_string xml_tag["k"] = random_string
xml_tag["v"] = random_string xml_tag["v"] = random_string