cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use assert_content instead of assert page.has_content?

Browse source 
The assert_content comes from capybara, and gives a much more helpful
error message if the test fails.
This commit is contained in:
Andy Allan 2022-01-06 13:16:47 +00:00
parent 89d9690982
commit d257c21740
10 changed files with 72 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

20
test/system/report_diary_entry_test.rb
View file

@ -8,19 +8,19 @@ class ReportDiaryEntryTest < ApplicationSystemTestCase
def test_no_link_when_not_logged_in
visit diary_entry_path(@diary_entry.user.display_name, @diary_entry)
assert page.has_content?(@diary_entry.title)
assert_content @diary_entry.title
assert_not page.has_content?(I18n.t("diary_entries.diary_entry.report"))
assert_no_content I18n.t("diary_entries.diary_entry.report")
end
def test_it_works
sign_in_as(create(:user))
visit diary_entry_path(@diary_entry.user.display_name, @diary_entry)
assert page.has_content? @diary_entry.title
assert_content @diary_entry.title
click_on I18n.t("diary_entries.diary_entry.report")
assert page.has_content? "Report"
assert page.has_content? I18n.t("reports.new.disclaimer.intro")
assert_content "Report"
assert_content I18n.t("reports.new.disclaimer.intro")
choose I18n.t("reports.new.categories.diary_entry.spam_label")
fill_in "report_details", :with => "This is advertising"
@ -28,7 +28,7 @@ class ReportDiaryEntryTest < ApplicationSystemTestCase
click_on "Create Report"
end
assert page.has_content? "Your report has been registered successfully"
assert_content "Your report has been registered successfully"
assert_equal @diary_entry, Issue.last.reportable
assert_equal "administrator", Issue.last.assigned_role
@ -40,11 +40,11 @@ class ReportDiaryEntryTest < ApplicationSystemTestCase
sign_in_as(create(:user))
visit diary_entry_path(@diary_entry.user.display_name, @diary_entry)
assert page.has_content? @diary_entry.title
assert_content @diary_entry.title
click_on I18n.t("diary_entries.diary_entry.report")
assert page.has_content? "Report"
assert page.has_content? I18n.t("reports.new.disclaimer.intro")
assert_content "Report"
assert_content I18n.t("reports.new.disclaimer.intro")
choose I18n.t("reports.new.categories.diary_entry.spam_label")
fill_in "report_details", :with => "This is advertising"
@ -60,6 +60,6 @@ class ReportDiaryEntryTest < ApplicationSystemTestCase
def test_missing_report_params
sign_in_as(create(:user))
visit new_report_path
assert page.has_content? I18n.t("reports.new.missing_params")
assert_content I18n.t("reports.new.missing_params")
end
end