cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor the user list test to use factory-built users and explicit assertions.

Browse source
This commit is contained in:
Andy Allan 2017-05-31 18:40:13 +01:00
parent 0a1834af63
commit cea6f9c4cf
1 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/controllers/user_controller_test.rb
View file

@ -1348,44 +1348,55 @@ class UserControllerTest < ActionController::TestCase
end end
def test_list_get def test_list_get
user = create(:user)
moderator_user = create(:moderator_user)
administrator_user = create(:administrator_user)
suspended_user = create(:user, :suspended)
ip_user = create(:user, :creation_ip => "1.2.3.4")
# There are now 7 users - the five above, plus two extra "granters" for the
# moderator_user and administrator_user
assert_equal 7, User.count
# Shouldn't work when not logged in # Shouldn't work when not logged in
get :list get :list
assert_response :redirect assert_response :redirect
assert_redirected_to :action => :login, :referer => users_path assert_redirected_to :action => :login, :referer => users_path
session[:user] = create(:user).id session[:user] = user.id
# Shouldn't work when logged in as a normal user # Shouldn't work when logged in as a normal user
get :list get :list
assert_response :redirect assert_response :redirect
assert_redirected_to :action => :login, :referer => users_path assert_redirected_to :action => :login, :referer => users_path
session[:user] = create(:moderator_user).id session[:user] = moderator_user.id
# Shouldn't work when logged in as a moderator # Shouldn't work when logged in as a moderator
get :list get :list
assert_response :redirect assert_response :redirect
assert_redirected_to :action => :login, :referer => users_path assert_redirected_to :action => :login, :referer => users_path
session[:user] = create(:administrator_user).id session[:user] = administrator_user.id
# Note there is a header row, so all row counts are users + 1
# Should work when logged in as an administrator # Should work when logged in as an administrator
get :list get :list
assert_response :success assert_response :success
assert_template :list assert_template :list
assert_select "table#user_list tr", :count => User.count + 1 assert_select "table#user_list tr", :count => 7 + 1
# Should be able to limit by status # Should be able to limit by status
get :list, :status => "suspended" get :list, :status => "suspended"
assert_response :success assert_response :success
assert_template :list assert_template :list
assert_select "table#user_list tr", :count => User.where(:status => "suspended").count + 1 assert_select "table#user_list tr", :count => 1 + 1
# Should be able to limit by IP address # Should be able to limit by IP address
get :list, :ip => "1.2.3.4" get :list, :ip => "1.2.3.4"
assert_response :success assert_response :success
assert_template :list assert_template :list
assert_select "table#user_list tr", :count => User.where(:creation_ip => "1.2.3.4").count + 1 assert_select "table#user_list tr", :count => 1 + 1
end end
def test_list_get_paginated def test_list_get_paginated