cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't compare changeset bbox coordinates when they may be nil

Browse source 
The code assumed that the changeset bounding box would only be
updated with a valid bounding box, but this isn't the case when
dealing with certain corner cases, including when removing
deleted members from relations.
This commit is contained in:
Matt Amos 2011-07-06 01:45:14 +01:00 • committed by Tom Hughes
parent f0bd9de191
commit cb4f1e62a0
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
app/models/changeset.rb
View file

@ -115,16 +115,21 @@ class Changeset < ActiveRecord::Base
# nils, just use the bounding box update to write over them. # nils, just use the bounding box update to write over them.
@bbox = bbox.zip(array).collect { |a, b| a.nil? ? b : a } @bbox = bbox.zip(array).collect { |a, b| a.nil? ? b : a }
# FIXME - this looks nasty and violates DRY... is there any prettier # only try to update the bbox if there is a value for every coordinate
# way to do this? # which there will be from the previous line as long as both array and
@bbox[0] = [-180 * GeoRecord::SCALE, array[0] + EXPAND * (@bbox[0] - @bbox[2])].max if array[0] < @bbox[0] # bbox are all non-nil.
@bbox[1] = [ -90 * GeoRecord::SCALE, array[1] + EXPAND * (@bbox[1] - @bbox[3])].max if array[1] < @bbox[1] if has_valid_bbox? and array.all?
@bbox[2] = [ 180 * GeoRecord::SCALE, array[2] + EXPAND * (@bbox[2] - @bbox[0])].min if array[2] > @bbox[2] # FIXME - this looks nasty and violates DRY... is there any prettier
@bbox[3] = [ 90 * GeoRecord::SCALE, array[3] + EXPAND * (@bbox[3] - @bbox[1])].min if array[3] > @bbox[3] # way to do this?
@bbox[0] = [-180 * GeoRecord::SCALE, array[0] + EXPAND * (@bbox[0] - @bbox[2])].max if array[0] < @bbox[0]
@bbox[1] = [ -90 * GeoRecord::SCALE, array[1] + EXPAND * (@bbox[1] - @bbox[3])].max if array[1] < @bbox[1]
@bbox[2] = [ 180 * GeoRecord::SCALE, array[2] + EXPAND * (@bbox[2] - @bbox[0])].min if array[2] > @bbox[2]
@bbox[3] = [ 90 * GeoRecord::SCALE, array[3] + EXPAND * (@bbox[3] - @bbox[1])].min if array[3] > @bbox[3]
# update active record. rails 2.1's dirty handling should take care of # update active record. rails 2.1's dirty handling should take care of
# whether this object needs saving or not. # whether this object needs saving or not.
self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox
end
end end
## ##