Move remaining inline changeset JS to changeset.js

app/assets/javascripts/changeset.js

@@ -1,34 +1,34 @@
-var highlight;
+$(document).ready(function () {
+  var highlight;
 
-function highlightChangeset(id) {
+  function highlightChangeset(id) {
-  var feature = vectors.getFeatureByFid(id);
+    var feature = vectors.getFeatureByFid(id);
-  var bounds = feature.geometry.getBounds();
+    var bounds = feature.geometry.getBounds();
 
-  if (bounds.containsBounds(map.getExtent())) {
+    if (bounds.containsBounds(map.getExtent())) {
-    bounds = map.getExtent().scale(1.1);
+      bounds = map.getExtent().scale(1.1);
+    }
+
+    if (highlight) vectors.removeFeatures(highlight);
+
+    highlight = new OpenLayers.Feature.Vector(bounds.toGeometry(), {}, {
+      strokeWidth: 2,
+      strokeColor: "#ee9900",
+      fillColor: "#ffff55",
+      fillOpacity: 0.5
+    });
+
+    vectors.addFeatures(highlight);
+
+    $("#tr-changeset-" + id).addClass("selected");
   }
 
-  if (highlight) vectors.removeFeatures(highlight);
+  function unHighlightChangeset(id) {
+    vectors.removeFeatures(highlight);
 
-  highlight = new OpenLayers.Feature.Vector(bounds.toGeometry(), {}, {
+    $("#tr-changeset-" + id).removeClass("selected");
-    strokeWidth: 2,
+  }
-    strokeColor: "#ee9900",
-    fillColor: "#ffff55",
-    fillOpacity: 0.5
-  });
 
-  vectors.addFeatures(highlight);
-
-  $("#tr-changeset-" + id).addClass("selected");
-}
-
-function unHighlightChangeset(id) {
-  vectors.removeFeatures(highlight);
-
-  $("#tr-changeset-" + id).removeClass("selected");
-}
-
-$(document).ready(function () {
   var map = createMap("changeset_list_map", {
     controls: [
       new OpenLayers.Control.Navigation(),
@@ -72,4 +72,12 @@ $(document).ready(function () {
   } else {
     map.zoomToExtent(proj(bounds));
   }
+
+  $("[data-changeset]").mouseover(function() {
+    highlightChangeset($(this).data("changeset").id);
+  });
+
+  $("[data-changeset]").mouseout(function() {
+    unHighlightChangeset($(this).data("changeset").id);
+  });
 });

app/views/changeset/_changeset.html.erb

@@ -48,13 +48,3 @@
     <% end %>
   </td>
 <% end %>
-
-<script type="text/javascript">
-$("#tr-changeset-<%= changeset.id%>").mouseover(function() {
-  highlightChangeset("<%= changeset.id %>");
-});
-
-$("#tr-changeset-<%= changeset.id%>").mouseout(function() {
-  unHighlightChangeset("<%= changeset.id %>");
-});
-</script>