cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Convert issue search tests to system tests

Browse source
This commit is contained in:
Andy Allan 2017-11-29 18:58:51 +00:00
parent 9ce00608a4
commit ca032e0b44
2 changed files with 26 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/controllers/issues_controller_test.rb
View file

@ -66,26 +66,4 @@ class IssuesControllerTest < ActionController::TestCase
assert_equal true, Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored? assert_equal true, Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?
assert_response :redirect assert_response :redirect
end end
def test_search_issues
good_user = create(:user)
bad_user = create(:user)
create(:issue, :reportable => bad_user, :reported_user => bad_user, :issue_type => "administrator")
# Login as administrator
session[:user] = create(:administrator_user).id
# No issues against the user
get :index, :params => { :search_by_user => good_user.display_name }
assert_response :redirect
assert_redirected_to issues_path
# User doesn't exist
get :index, :params => { :search_by_user => "test1000" }
assert_response :redirect
assert_redirected_to issues_path
# Find Issue against bad_user
get :index, :params => { :search_by_user => bad_user.display_name }
assert_response :success
end
end end

26
test/system/issues_test.rb
View file

@ -23,6 +23,32 @@ class IssuesTest < ApplicationSystemTestCase
assert page.has_content?(issues.first.reported_user.display_name) assert page.has_content?(issues.first.reported_user.display_name)
end end
def test_search_issues_by_user
good_user = create(:user)
bad_user = create(:user)
create(:issue, :reportable => bad_user, :reported_user => bad_user, :issue_type => "administrator")
sign_in_as(create(:administrator_user))
# No issues against the user
visit issues_path
fill_in "search_by_user", :with => good_user.display_name
click_on "Search"
assert page.has_content?(I18n.t(".issues.index.search.issues_not_found"))
# User doesn't exist
visit issues_path
fill_in "search_by_user", :with => "Nonexistant User"
click_on "Search"
assert page.has_content?(I18n.t(".issues.index.search.user_not_found"))
# Find Issue against bad_user
visit issues_path
fill_in "search_by_user", :with => bad_user.display_name
click_on "Search"
assert !page.has_content?(I18n.t(".issues.index.search.issues_not_found"))
end
def test_commenting def test_commenting
issue = create(:issue) issue = create(:issue)
sign_in_as(create(:moderator_user)) sign_in_as(create(:moderator_user))