Prefer string interpolation to concatenation in erb files

This commit is contained in:
Andy Allan 2020-11-11 14:44:42 +00:00
parent 52c688f55a
commit c8e1b3c662
7 changed files with 9 additions and 9 deletions

View file

@ -1,6 +1,6 @@
<% member_class = link_class(relation_member.member_type.downcase, relation_member.member)
linked_name = link_to printable_name(relation_member.member), { :action => relation_member.member_type.downcase, :id => relation_member.member_id.to_s }, { :title => link_title(relation_member.member), :rel => link_follow(relation_member.member) }
type_str = t ".type." + relation_member.member_type.downcase %>
type_str = t ".type.#{relation_member.member_type.downcase}" %>
<li class="<%= member_class %>">
<%= if relation_member.member_role.blank?
t ".entry_html", :type => type_str, :name => linked_name

View file

@ -6,8 +6,8 @@
<%= @issue.assigned_role %>
| <%= t ".reports", :count => @issue.reports.count %>
| <%= t ".report_created_at", :datetime => l(@issue.created_at.to_datetime, :format => :friendly) %>
<%= " | " + t(".last_resolved_at", :datetime => l(@issue.resolved_at.to_datetime, :format => :friendly)) if @issue.resolved_at? %>
<%= " | " + t(".last_updated_at", :datetime => l(@issue.updated_at.to_datetime, :format => :friendly), :displayname => @issue.user_updated.display_name) if @issue.user_updated %>
<%= " | #{t('.last_resolved_at', :datetime => l(@issue.resolved_at.to_datetime, :format => :friendly))}" if @issue.resolved_at? %>
<%= " | #{t('.last_updated_at', :datetime => l(@issue.updated_at.to_datetime, :format => :friendly), :displayname => @issue.user_updated.display_name)}" if @issue.user_updated %>
</small>
</p>
<p>

View file

@ -5,7 +5,7 @@
<%= javascript_include_tag "es5" unless browser.es5? %>
<%= javascript_include_tag "es6" unless browser.es6? %>
<%= javascript_include_tag "application" %>
<%= javascript_include_tag "i18n/" + I18n.locale.to_s %>
<%= javascript_include_tag "i18n/#{I18n.locale}" %>
<%= stylesheet_link_tag "screen-#{dir}", :media => "screen" %>
<%= stylesheet_link_tag "print-#{dir}", :media => "print" %>
<%= stylesheet_link_tag "leaflet-all", :media => "screen, print" %>
@ -14,5 +14,5 @@
<%= yield :auto_discovery_link_tag %>
<%= csrf_meta_tag %>
<%= csp_meta_tag %>
<title><%= @title + " | " if @title %><%= t "layouts.project_name.title" %></title>
<title><%= "#{@title} | " if @title %><%= t "layouts.project_name.title" %></title>
<% end %>

View file

@ -19,7 +19,7 @@
<p><%= t ".requests" %></p>
<ul>
<% @client_application.permissions.each do |perm| %>
<li><%= t("activerecord.attributes.client_application." + perm.to_s) %></li>
<li><%= t("activerecord.attributes.client_application.#{perm}") %></li>
<% end %>
</ul>
<p><%= t ".support_notice" %></p>

View file

@ -21,7 +21,7 @@
when "public", "identifiable" then "success"
else "danger"
end %>
<span class="badge badge-<%= badge_class %> text-white"><%= t("." + trace.visibility) %></span>
<span class="badge badge-<%= badge_class %> text-white"><%= t(".#{trace.visibility}") %></span>
<br />
<%= trace.description %>

View file

@ -1,5 +1,5 @@
<div class="user_popup">
<%= user_thumbnail popup %>
<p><%= t("." + type) %></p>
<p><%= t(".#{type}") %></p>
<p><%= link_to popup.display_name, user_path(popup) %></p>
</div>

View file

@ -23,7 +23,7 @@
<div class="standard-form-row">
<label for="legale_<%= legale %>">
<%= radio_button_tag "legale", legale, @legale == legale, :data => { :url => url_for(:legale => legale) } %>
<%= t(".legale_names." + name) %>
<%= t(".legale_names.#{name}") %>
</label>
</div>
<% end %>