cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stop the data browser leaking details of redactions

Browse source 
Altered styling of redacted versions in changeset list so that they
appear deleted and don't leak tag information.
This commit is contained in:
Matt Amos 2012-04-02 14:30:57 +01:00 • committed by Tom Hughes
parent ac0603d055
commit c8d3257fa5
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/helpers/browse_helper.rb
View file

@ -13,6 +13,9 @@ module BrowseHelper
if version
name = t 'printable_name.with_version', :id => name, :version => object.version.to_s
end
# stop here if redacted to avoid giving away redacted version tags.
return name if object.redacted?
if object.tags.include? "name:#{I18n.locale}"
name = t 'printable_name.with_name', :name => object.tags["name:#{I18n.locale}"].to_s, :id => name
elsif object.tags.include? 'name'
@ -22,11 +25,19 @@ module BrowseHelper
end
def link_class(type, object)
return type + " " + h(icon_tags(object).join(' ')) + (object.visible == false ? ' deleted' : '')
if object.redacted?
type + " deleted"
else
type + " " + h(icon_tags(object).join(' ')) + (object.visible == false ? ' deleted' : '')
end
end
def link_title(object)
return h(icon_tags(object).map { |k,v| k + '=' + v }.to_sentence)
if object.redacted?
""
else
h(icon_tags(object).map { |k,v| k + '=' + v }.to_sentence)
end
end
def format_key(key)