cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Share button unusable on a cell phone

Browse source
This commit is contained in:
nertc 2024-07-04 16:17:56 +04:00
parent f9db802c7b
commit c66851f474
4 changed files with 40 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/assets/javascripts/leaflet.share.js
View file

@ -8,6 +8,7 @@ L.OSM.share = function (options) {
control.onAddPane = function (map, button, $ui) { control.onAddPane = function (map, button, $ui) {
// Link / Embed // Link / Embed
$("#content").addClass("overlay-right-sidebar");
var $linkSection = $("<div>") var $linkSection = $("<div>")
.attr("class", "share-link p-3 border-bottom border-secondary-subtle") .attr("class", "share-link p-3 border-bottom border-secondary-subtle")

2
app/assets/javascripts/leaflet.sidebar.js
View file

@ -31,9 +31,11 @@ L.OSM.sidebar = function (selector) {
map.panBy([-paneWidth, 0], { animate: false }); map.panBy([-paneWidth, 0], { animate: false });
} }
$(sidebar).hide(); $(sidebar).hide();
$("#content").addClass("overlay-right-sidebar");
current = currentButton = $(); current = currentButton = $();
} else { } else {
$(sidebar).show(); $(sidebar).show();
$("#content").removeClass("overlay-right-sidebar");
current = pane; current = pane;
currentButton = button || $(); currentButton = button || $();
if ($("html").attr("dir") === "rtl") { if ($("html").attr("dir") === "rtl") {

4
app/assets/stylesheets/common.scss
View file

@ -395,7 +395,7 @@ body.small-nav {
overflow-y: scroll; overflow-y: scroll;
} }
.overlay-sidebar { .overlay-sidebar.overlay-right-sidebar {
#sidebar { #sidebar {
position: absolute; position: absolute;
width: 350px; width: 350px;
@ -403,7 +403,7 @@ body.small-nav {
overflow: hidden; overflow: hidden;
} }
#map, #map-ui { #map {
height: 100%; height: 100%;
} }
} }

35
test/system/index_test.rb
View file

@ -1,6 +1,41 @@
require "application_system_test_case" require "application_system_test_case"
class IndexTest < ApplicationSystemTestCase class IndexTest < ApplicationSystemTestCase
test "should remove and add an overlay on share button click" do
node = create(:node)
visit node_path(node)
assert_selector "#content.overlay-right-sidebar"
find(".icon.share").click
assert_no_selector "#content.overlay-right-sidebar"
find(".icon.share").click
assert_selector "#content.overlay-right-sidebar"
end
test "should add an overlay on close" do
node = create(:node)
visit node_path(node)
find(".icon.share").click
assert_no_selector "#content.overlay-right-sidebar"
find(".share-ui .btn-close").click
assert_selector "#content.overlay-right-sidebar"
end
test "should not add overlay when not closing right menu popup" do
node = create(:node)
visit node_path(node)
find(".icon.share").click
find(".icon.key").click
assert_no_selector "#content.overlay-right-sidebar"
find(".icon.layers").click
assert_no_selector "#content.overlay-right-sidebar"
find(".icon.key").click
assert_no_selector "#content.overlay-right-sidebar"
find(".icon.key").click
assert_selector "#content.overlay-right-sidebar"
end
test "node included in edit link" do test "node included in edit link" do
node = create(:node) node = create(:node)
visit node_path(node) visit node_path(node)