cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Convert json changeset tags and comments test to tags test

Browse source 
There are other tests that check comments.
This commit is contained in:
Anton Khorev 2025-02-17 05:04:46 +03:00
parent 79f5ccca31
commit c3dc1b7770
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
test/controllers/api/changesets_controller_test.rb
View file

@ -358,26 +358,22 @@ module Api
assert js["changeset"]["comments"][2]["visible"] assert js["changeset"]["comments"][2]["visible"]
end end
def test_show_tag_and_discussion_json def test_show_tags_json
changeset = create(:changeset, :closed) changeset = create(:changeset, :closed)
create(:changeset_tag, :changeset => changeset, :k => "created_by", :v => "JOSM/1.5 (18364)") create(:changeset_tag, :changeset => changeset, :k => "created_by", :v => "JOSM/1.5 (18364)")
create(:changeset_tag, :changeset => changeset, :k => "comment", :v => "changeset comment") create(:changeset_tag, :changeset => changeset, :k => "comment", :v => "changeset comment")
create_list(:changeset_comment, 3, :changeset_id => changeset.id)
get changeset_show_path(changeset), :params => { :format => "json", :include_discussion => true } get changeset_show_path(changeset, :format => "json")
assert_response :success, "cannot get closed changeset with comments"
assert_response :success
js = ActiveSupport::JSON.decode(@response.body) js = ActiveSupport::JSON.decode(@response.body)
assert_not_nil js assert_not_nil js
assert_equal Settings.api_version, js["version"] assert_equal Settings.api_version, js["version"]
assert_equal Settings.generator, js["generator"] assert_equal Settings.generator, js["generator"]
assert_single_changeset_json changeset, js assert_single_changeset_json changeset, js
assert_equal 2, js["changeset"]["tags"].count assert_equal 2, js["changeset"]["tags"].count
assert_equal 3, js["changeset"]["comments"].count assert_equal "JOSM/1.5 (18364)", js["changeset"]["tags"]["created_by"]
assert_not_nil js["changeset"]["comments"][0]["uid"] assert_equal "changeset comment", js["changeset"]["tags"]["comment"]
assert_not_nil js["changeset"]["comments"][0]["user"]
assert_not_nil js["changeset"]["comments"][0]["text"]
end end
def test_show_bbox_json def test_show_bbox_json