cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove assert_response when followed by assert_redirected_to

Browse source
This commit is contained in:
Anton Khorev 2024-03-02 13:48:49 +03:00
parent fad9a10dc2
commit bde2faac58
29 changed files with 0 additions and 368 deletions
Download patch file Download diff file Expand all files Collapse all files

11
test/controllers/redactions_controller_test.rb
View file

@ -47,7 +47,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
def test_new
get new_redaction_path
assert_response :redirect
assert_redirected_to login_path(:referer => new_redaction_path)
end
@ -63,7 +62,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
session_for(create(:user))
get new_redaction_path
assert_response :redirect
assert_redirected_to :controller => "errors", :action => "forbidden"
end
@ -71,7 +69,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
session_for(create(:moderator_user))
post redactions_path(:redaction => { :title => "Foo", :description => "Description here." })
assert_response :redirect
assert_redirected_to(redaction_path(Redaction.find_by(:title => "Foo")))
end
@ -87,7 +84,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
session_for(create(:user))
post redactions_path(:redaction => { :title => "Foo", :description => "Description here." })
assert_response :redirect
assert_redirected_to :controller => "errors", :action => "forbidden"
end
@ -98,7 +94,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
redaction = create(:redaction)
delete redaction_path(:id => redaction)
assert_response :redirect
assert_redirected_to(redactions_path)
end
@ -110,7 +105,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
create(:old_node, :redaction => redaction)
delete redaction_path(:id => redaction)
assert_response :redirect
assert_redirected_to(redaction_path(redaction))
assert_match(/^Redaction is not empty/, flash[:error])
end
@ -119,7 +113,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
session_for(create(:user))
delete redaction_path(:id => create(:redaction))
assert_response :redirect
assert_redirected_to :controller => "errors", :action => "forbidden"
end
@ -127,7 +120,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
redaction = create(:redaction)
get edit_redaction_path(:id => redaction)
assert_response :redirect
assert_redirected_to login_path(:referer => edit_redaction_path(redaction))
end
@ -142,7 +134,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
session_for(create(:user))
get edit_redaction_path(:id => create(:redaction))
assert_response :redirect
assert_redirected_to :controller => "errors", :action => "forbidden"
end
@ -152,7 +143,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
redaction = create(:redaction)
put redaction_path(:id => redaction, :redaction => { :title => "Foo", :description => "Description here." })
assert_response :redirect
assert_redirected_to(redaction_path(redaction))
end
@ -172,7 +162,6 @@ class RedactionsControllerTest < ActionDispatch::IntegrationTest
redaction = create(:redaction)
put redaction_path(:id => redaction, :redaction => { :title => "Foo", :description => "Description here." })
assert_response :redirect
assert_redirected_to :controller => "errors", :action => "forbidden"
end
end