cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Split api old element redacted index tests

Browse source
This commit is contained in:
Anton Khorev 2025-02-09 06:44:10 +03:00
parent 6edb8dae05
commit bd0f5a1932
3 changed files with 45 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

26
test/controllers/api/old_nodes_controller_test.rb
View file

@ -52,22 +52,26 @@ module Api
##
# test that redacted nodes aren't visible in the history
def test_index_redacted
def test_index_redacted_unauthorised
node = create(:node, :with_history, :version => 2)
node_v1 = node.old_nodes.find_by(:version => 1)
node_v1.redact!(create(:redaction))
node.old_nodes.find_by(:version => 1).redact!(create(:redaction))
get api_node_versions_path(node)
assert_response :success, "Redaction shouldn't have stopped history working."
assert_select "osm node[id='#{node_v1.node_id}'][version='#{node_v1.version}']", 0,
"redacted node #{node_v1.node_id} version #{node_v1.version} shouldn't be present in the history."
# not even to a logged-in user
auth_header = bearer_authorization_header
get api_node_versions_path(node), :headers => auth_header
assert_response :success, "Redaction shouldn't have stopped history working."
assert_select "osm node[id='#{node_v1.node_id}'][version='#{node_v1.version}']", 0,
"redacted node #{node_v1.node_id} version #{node_v1.version} shouldn't be present in the history, even when logged in."
assert_dom "osm node[id='#{node.id}'][version='1']", 0,
"redacted node #{node.id} version 1 shouldn't be present in the history."
end
def test_index_redacted_normal_user
node = create(:node, :with_history, :version => 2)
node.old_nodes.find_by(:version => 1).redact!(create(:redaction))
get api_node_versions_path(node), :headers => bearer_authorization_header
assert_response :success, "Redaction shouldn't have stopped history working."
assert_dom "osm node[id='#{node.id}'][version='1']", 0,
"redacted node #{node.id} version 1 shouldn't be present in the history, even when logged in."
end
def test_show

26
test/controllers/api/old_relations_controller_test.rb
View file

@ -55,22 +55,26 @@ module Api
##
# test that redacted relations aren't visible in the history
def test_index_redacted
def test_index_redacted_unauthorised
relation = create(:relation, :with_history, :version => 2)
relation_v1 = relation.old_relations.find_by(:version => 1)
relation_v1.redact!(create(:redaction))
relation.old_relations.find_by(:version => 1).redact!(create(:redaction))
get api_relation_versions_path(relation)
assert_response :success, "Redaction shouldn't have stopped history working."
assert_select "osm relation[id='#{relation_v1.relation_id}'][version='#{relation_v1.version}']", 0,
"redacted relation #{relation_v1.relation_id} version #{relation_v1.version} shouldn't be present in the history."
# not even to a logged-in user
auth_header = bearer_authorization_header
get api_relation_versions_path(relation), :headers => auth_header
assert_response :success, "Redaction shouldn't have stopped history working."
assert_select "osm relation[id='#{relation_v1.relation_id}'][version='#{relation_v1.version}']", 0,
"redacted relation #{relation_v1.relation_id} version #{relation_v1.version} shouldn't be present in the history, even when logged in."
assert_dom "osm relation[id='#{relation.id}'][version='1']", 0,
"redacted relation #{relation.id} version 1 shouldn't be present in the history."
end
def test_index_redacted_normal_user
relation = create(:relation, :with_history, :version => 2)
relation.old_relations.find_by(:version => 1).redact!(create(:redaction))
get api_relation_versions_path(relation), :headers => bearer_authorization_header
assert_response :success, "Redaction shouldn't have stopped history working."
assert_dom "osm relation[id='#{relation.id}'][version='1']", 0,
"redacted relation #{relation.id} version 1 shouldn't be present in the history, even when logged in."
end
def test_show

26
test/controllers/api/old_ways_controller_test.rb
View file

@ -62,22 +62,26 @@ module Api
##
# test that redacted ways aren't visible in the history
def test_index_redacted
def test_index_redacted_unauthorised
way = create(:way, :with_history, :version => 2)
way_v1 = way.old_ways.find_by(:version => 1)
way_v1.redact!(create(:redaction))
way.old_ways.find_by(:version => 1).redact!(create(:redaction))
get api_way_versions_path(way)
assert_response :success, "Redaction shouldn't have stopped history working."
assert_select "osm way[id='#{way_v1.way_id}'][version='#{way_v1.version}']", 0,
"redacted way #{way_v1.way_id} version #{way_v1.version} shouldn't be present in the history."
# not even to a logged-in user
auth_header = bearer_authorization_header
get api_way_versions_path(way), :headers => auth_header
assert_response :success, "Redaction shouldn't have stopped history working."
assert_select "osm way[id='#{way_v1.way_id}'][version='#{way_v1.version}']", 0,
"redacted node #{way_v1.way_id} version #{way_v1.version} shouldn't be present in the history, even when logged in."
assert_dom "osm way[id='#{way.id}'][version='1']", 0,
"redacted way #{way.id} version 1 shouldn't be present in the history."
end
def test_index_redacted_normal_user
way = create(:way, :with_history, :version => 2)
way.old_ways.find_by(:version => 1).redact!(create(:redaction))
get api_way_versions_path(way), :headers => bearer_authorization_header
assert_response :success, "Redaction shouldn't have stopped history working."
assert_dom "osm way[id='#{way.id}'][version='1']", 0,
"redacted node #{way.id} version 1 shouldn't be present in the history, even when logged in."
end
def test_show