cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move Relation.to_xml and to_xml_node out of the model and into tests

Browse source
This commit is contained in:
Andy Allan 2019-11-20 15:45:28 +01:00
parent 2b1bac1279
commit bc850d1d37
4 changed files with 47 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

25
app/models/relation.rb
View file

@ -121,31 +121,6 @@ class Relation < ActiveRecord::Base
relation
end
def to_xml
doc = OSM::API.new.get_xml_doc
doc.root << to_xml_node
doc
end
def to_xml_node(changeset_cache = {}, user_display_name_cache = {})
el = XML::Node.new "relation"
el["id"] = id.to_s
add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
relation_members.each do |member|
member_el = XML::Node.new "member"
member_el["type"] = member.member_type.downcase
member_el["ref"] = member.member_id.to_s
member_el["role"] = member.member_role
el << member_el
end
add_tags_to_xml_node(el, relation_tags)
el
end
# FIXME: is this really needed?
def members
@members ||= relation_members.map do |member|