cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change tests to expect a successful (empty) response even if the user is not visible anymore

Browse source
This commit is contained in:
ENT8R 2023-08-26 09:37:06 +02:00
parent b9c85c2697
commit bc71737f05
1 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

24
test/controllers/api/users_controller_test.rb
View file

@ -419,13 +419,15 @@ module Api
check_json_details(js["users"][1], user3, false, false) check_json_details(js["users"][1], user3, false, false)
get api_users_path, :params => { :users => create(:user, :suspended).id } get api_users_path, :params => { :users => create(:user, :suspended).id }
assert_response :not_found assert_response :success
get api_users_path, :params => { :users => create(:user, :deleted).id } get api_users_path, :params => { :users => create(:user, :deleted).id }
assert_response :not_found assert_response :success
get api_users_path, :params => { :users => 0 } get api_users_path, :params => { :users => 0 }
assert_response :not_found assert_response :success
assert_equal "application/xml", response.media_type
assert_select "user", :count => 0
end end
def test_index_oauth1 def test_index_oauth1
@ -506,13 +508,15 @@ module Api
check_json_details(js["users"][1], user3, false, false) check_json_details(js["users"][1], user3, false, false)
signed_get api_users_path, :params => { :users => create(:user, :suspended).id }, :oauth => { :token => good_token } signed_get api_users_path, :params => { :users => create(:user, :suspended).id }, :oauth => { :token => good_token }
assert_response :not_found assert_response :success
signed_get api_users_path, :params => { :users => create(:user, :deleted).id }, :oauth => { :token => good_token } signed_get api_users_path, :params => { :users => create(:user, :deleted).id }, :oauth => { :token => good_token }
assert_response :not_found assert_response :success
signed_get api_users_path, :params => { :users => 0 }, :oauth => { :token => good_token } signed_get api_users_path, :params => { :users => 0 }, :oauth => { :token => good_token }
assert_response :not_found assert_response :success
assert_equal "application/xml", response.media_type
assert_select "user", :count => 0
end end
def test_index_oauth2 def test_index_oauth2
@ -593,13 +597,15 @@ module Api
check_json_details(js["users"][1], user3, false, false) check_json_details(js["users"][1], user3, false, false)
get api_users_path, :params => { :users => create(:user, :suspended).id }, :headers => bearer_authorization_header(good_token.token) get api_users_path, :params => { :users => create(:user, :suspended).id }, :headers => bearer_authorization_header(good_token.token)
assert_response :not_found assert_response :success
get api_users_path, :params => { :users => create(:user, :deleted).id }, :headers => bearer_authorization_header(good_token.token) get api_users_path, :params => { :users => create(:user, :deleted).id }, :headers => bearer_authorization_header(good_token.token)
assert_response :not_found assert_response :success
get api_users_path, :params => { :users => 0 }, :headers => bearer_authorization_header(good_token.token) get api_users_path, :params => { :users => 0 }, :headers => bearer_authorization_header(good_token.token)
assert_response :not_found assert_response :success
assert_equal "application/xml", response.media_type
assert_select "user", :count => 0
end end
def test_gpx_files def test_gpx_files